Commit Graph

48506 Commits

Author SHA1 Message Date
6033a825ed Ensure BeatmapInfo Difficulty and Metadata is non-null 2022-01-12 17:49:11 +09:00
a7958b1d31 Fix edge cases in online availability tracker and combine query code 2022-01-12 17:49:10 +09:00
ca7e11057c Use better method to ensure online availability tracker is in a clean state 2022-01-12 17:49:10 +09:00
ac3b7aa893 Fix more incorrect test access to ILive 2022-01-12 17:49:10 +09:00
c15efaeff2 Fix OnlinePlayBeatmapAvailabilityTracker not correctly tracking beatmap import changes 2022-01-12 17:49:10 +09:00
b531cd0207 Fix donwload trackers not considering deleted scores 2022-01-12 17:49:10 +09:00
902dc0eaec Detach rather than consume live when presenting a beatmap 2022-01-12 17:49:10 +09:00
8e79898e26 Fix a couple of minor issues with TestSceneBeatmapRecommendations 2022-01-12 17:49:10 +09:00
5cbd731864 Add RulesetInfo hashcode implementation and tidy up equality 2022-01-12 17:49:10 +09:00
c33e163178 Bind ruleset to toolbar later for safety 2022-01-12 17:49:10 +09:00
605898ec53 Add missing "non-null" elements missing from some tests 2022-01-12 17:49:10 +09:00
02d0ca2741 Fix protected beatmaps showing up in the song select carousel 2022-01-12 17:49:10 +09:00
4b690703b3 Remove unnecessary DI dependencies from cache test 2022-01-12 17:49:10 +09:00
41d90cd0b5 Fix beatmap carousel test failures 2022-01-12 17:49:10 +09:00
a0f8debafe Add note about BeatmapMetadata.Author being weird 2022-01-12 17:49:10 +09:00
8ecfb9172e Fix multiple tests with incorrect access to beatmap imports 2022-01-12 17:49:10 +09:00
f4a1fa85a1 Fix incorrect conditional for deciding whether scores can be deleted from UI 2022-01-12 17:49:10 +09:00
ae8f522c20 Add support for persisting score's mods to realm 2022-01-12 17:49:10 +09:00
af5d3af664 Remove test coverage of scores being deleted when beatmaps are
This is not supported in realm for now. Probably best suited to a
separate pass, similar to files, using backlink count.
2022-01-12 17:49:10 +09:00
d8e75a9de4 Reimplmeent IsAvailableLocally as an abstract method 2022-01-12 17:49:10 +09:00
47390d7ec3 Update handling of ruleset nullability when handling a game-wide change 2022-01-12 17:49:10 +09:00
43c7b0d2c8 Fix unsupported realm operations in multiple tests 2022-01-12 17:49:10 +09:00
ba62d2c756 Fix ScoreInfo oversights causing automapper to fail
Parameter in ctor *has* to be named `realmUser` else automapper will try
to map to the `User` property.
2022-01-12 17:48:49 +09:00
5d868c41d4 Merge pull request #16330 from peppy/mouse-button-disable-disables-touch
Allow "disable mouse button" setting to apply to touch as well
2022-01-12 17:40:43 +09:00
52e240230b Merge branch 'master' into mouse-button-disable-disables-touch 2022-01-12 17:14:39 +09:00
c534a27ee7 Merge pull request #16425 from frenzibyte/update-macos-version-limit
Update macOS minimum supported version in line with .NET 5
2022-01-12 17:11:25 +09:00
c8641389af Update macOS minimum supported version in line with .NET 5 2022-01-12 11:08:12 +03:00
33b5fa3473 Detach score during import tests to ensure original object doesn't get managed 2022-01-12 17:00:17 +09:00
463a185605 Fix many instances of User being null in score import tests 2022-01-12 17:00:17 +09:00
d19a9a0ba3 Remove assertion of ScoreInfo.Combo being database persisted 2022-01-12 17:00:17 +09:00
83ccbc1d13 Mention safety failures of Beatmap/Score constructors 2022-01-12 17:00:17 +09:00
c831e9107a Fix BeatmapInfo.Clone potentially not cloning if already detached 2022-01-12 17:00:17 +09:00
5dd0bb1218 Ensure Score created by GameplayState has a valid ruleset 2022-01-12 17:00:17 +09:00
82259ee072 Improve legibility of RulesetInfo.Equals 2022-01-12 17:00:17 +09:00
fa7dddcf3c Fix TestScenePresentScore sharing metadata/difficulty across multiple beatmaps 2022-01-12 17:00:17 +09:00
6251713796 Add missing Ruleset in ReplayRecorder tests 2022-01-12 17:00:17 +09:00
7e7784b78a Fix incorrect access to ILive in BeatmapSkinResources tests 2022-01-12 17:00:17 +09:00
e5af673b01 Fix incorrect BeatmapInfo.ToString implementation 2022-01-12 17:00:17 +09:00
f2f1adb792 Update FilterMatchingTest and filter code to use ruleset's OnlineID 2022-01-12 17:00:17 +09:00
ba4ef0926f Remove incorrect test fixture specification 2022-01-12 17:00:17 +09:00
a3c70ccdfc Fix OnlineAvailabilityTracker referencing a value in query that could potentially be null 2022-01-12 17:00:17 +09:00
b619ff1264 Reattach detached items on delete/undelete 2022-01-12 17:00:17 +09:00
e74a5022c9 Fix multiple tests via null checks and changing ToLive to Detach
flow
2022-01-12 17:00:17 +09:00
13401a8846 Better handle Statistics to avoid losing data 2022-01-12 17:00:17 +09:00
76670a8faa Fix BeatmapDifficultyCache not working with detached beatmaps 2022-01-12 17:00:17 +09:00
52ca649159 Fix results screen test failures due to relation query 2022-01-12 17:00:17 +09:00
6919df18fa Fix incorrect ordering and grouping of difficulties at song select 2022-01-12 17:00:17 +09:00
aaefd72c69 Handle ignored mappings locally in Detach configuration 2022-01-12 17:00:17 +09:00
2b8706b6ce Detach and reattach scores to make work 2022-01-12 17:00:16 +09:00
60d2de8a3b Fix potential nullref when song select filters to no results 2022-01-12 17:00:16 +09:00