15f65c7897
Rename lambda param to avoid name shadowing
2022-03-03 20:28:19 +01:00
2e24e7ef56
Use property expression rather than block
2022-03-03 20:28:00 +01:00
edd361d256
Trim unused using directives
2022-03-03 20:21:48 +01:00
cecc746f9e
Update existing usages to use SubscribeToPropertyChanged
2022-03-03 17:42:50 +09:00
3848964faa
Add tooltip text for offset adjustment slider
2022-03-03 17:07:46 +09:00
9c43500ad3
Add ability for player loading screen settings to scroll
...
As we add more items here this is going to become necessary. Until the design no doubt gets changed.
2022-03-03 16:23:31 +09:00
a06d806fb9
Fix hit distribution graph midpoint rounding not looking great around zero
...
Not sure this will be accepted and it's likely only ever going to show
in tests, but seems to be a better approach to midpoint rounding for
this case?
2022-03-03 15:43:02 +09:00
ab0ee26540
Remove padding from distribution graph bars to fix some bars becoming invisible at low sizes
2022-03-03 15:13:42 +09:00
a38eb426ef
Merge pull request #17026 from peppy/beatmap-offset-control
...
Add basic beatmap offset adjustment
2022-03-03 14:23:19 +09:00
42e07b7308
Convert to extension method to avoid recursive calls
2022-03-03 14:15:37 +09:00
fab9323707
Replace all legacy ruleset checks with a helper property call
2022-03-03 14:08:48 +09:00
cbb8dc2891
Fix storyboard samples rate not adjusted from actual gameplay mods
2022-03-02 20:56:18 +03:00
f15b8781bb
Move editor mode selector out of EditorMenuBar
to allow for better reuse
2022-03-02 20:05:01 +09:00
763f881d4a
Use more correct mod check to encompass more than just autoplay
2022-03-02 14:42:10 +09:00
e184b26cdd
Remove Precision
call for database write shortcutting
...
Shouldn't be required.
2022-03-02 14:39:29 +09:00
8bd66f1ed7
Fix incorrect precision specification for button disable check
2022-03-02 14:36:49 +09:00
3cbcb702f6
Fix calibration button disabled state not checking in corrrect direction
2022-03-02 14:36:15 +09:00
c07f754565
Enable nullable
on BeatmapOffsetControl
2022-03-02 14:34:24 +09:00
c342030b2c
Add specific placeholder message for custom rulesets rather than showing network error
2022-03-02 14:10:59 +09:00
97c54de3bf
Fix performance statistic not handling rulesets with unimplemented calculator
2022-03-01 20:43:20 +03:00
222f50d211
Fix calibration being back-to-front
2022-03-01 20:41:54 +09:00
6c09237956
Reorder fields in BeatmapOffsetControl
and MasterGameplayClockContainer
2022-03-01 20:16:55 +09:00
9792f0653a
Don't show calibration controls for autoplay
2022-03-01 20:12:59 +09:00
4aee57c9c1
Add localisation of all beatmap offset strings
2022-03-01 20:12:59 +09:00
4d9efe771b
Don't display calibration options when the previous play was too short to be useful
2022-03-01 20:12:59 +09:00
bc2a15db96
Handle cases of beatmaps not existing in realm for tests
2022-03-01 20:12:59 +09:00
99c1ba19aa
Allow BeatmapOffsetControl
to react to external changes to offset
2022-03-01 20:12:59 +09:00
bb8caabb8b
Subscribe to changes in offset
2022-03-01 20:12:59 +09:00
071ba5c1df
Make writes asynchronously to avoid synchronous overhead
2022-03-01 20:12:59 +09:00
047e801da9
Store and retrieve offset from realm
2022-03-01 20:12:59 +09:00
2901d2a650
Hook offset adjustment control up to last play via PlayerLoader
2022-03-01 18:44:15 +09:00
350b0b488c
TODO: Get score from previous play session for further analysis
2022-03-01 18:44:15 +09:00
1847f69bf9
Add basic beatmap offset adjustment control
2022-03-01 18:44:15 +09:00
4117a6adf7
Move player loader audio settings to new group
2022-03-01 18:44:15 +09:00
a41e1c80f1
Show hit error on results screen
...
Leading up to implementation of "local offset", this feels like a good
thing to have visible first and foremost.
2022-02-28 19:11:06 +09:00
2be40f36f7
Reword popup text to read better (or more vaguely)
...
Removed some words but also don't mention "smaller" because it's...
musically incorrect and also functionally incorrect – entering 1/[8]
will result in 1/16 also being populated for instance.
2022-02-28 15:26:50 +09:00
368eadd8d1
Remove unused using statement
2022-02-28 15:24:02 +09:00
3634e12e66
Automatically focus divisor textbox and hide popover after successful change
2022-02-28 15:23:01 +09:00
7de5dad4f0
Add test coverage for divisor behaviour
2022-02-27 19:23:02 +01:00
423838a649
Add flow for specifying entirely custom snaps
2022-02-27 17:55:20 +01:00
d0c01afc2e
Add flow for changing set of valid divisors between presets
2022-02-27 15:37:51 +01:00
36137e0619
Add simple carousel divisor type selector
2022-02-27 15:37:51 +01:00
387ae59bc4
Fix nullref in tests
2022-02-25 16:12:25 +09:00
48ed9c6144
Enable high chat polling rate
2022-02-25 16:03:56 +09:00
f9d9ad388b
Add chat display to multiplayer spectator screen
2022-02-25 16:03:28 +09:00
a9e7e8fb18
Merge pull request #16924 from Susko3/android-allow-exiting
...
Allow exiting/minimizing the game on Android when on the initial screen
2022-02-25 11:01:35 +09:00
33a87976a8
Rewrite to read better
...
Co-authored-by: Dean Herbert <pe@ppy.sh >
2022-02-24 21:11:49 +01:00
16a3bbbcb4
Merge pull request #16944 from peppy/rooms-request-faster
...
Update playlists/multiplayer to use new compact response
2022-02-24 23:20:07 +09:00
6f29cbccd1
Remove unused using
2022-02-24 10:36:10 +01:00
255b3b067b
Remove track fade
2022-02-24 10:13:27 +01:00