Commit Graph

3093 Commits

Author SHA1 Message Date
5b98a73edc Apply nullability to SkinComponentToolbox and split out reflection method to get all skinnable components 2022-08-01 14:04:08 +09:00
38a8b9cf0a Add battery info for desktop platforms 2022-07-30 14:26:19 +02:00
3bc1774c87 Merge branch 'master' into pie-chart-progress 2022-07-29 16:54:59 +03:00
905bbdc8ee Remove caching of GameplayClockContainer in favour of GameplayClock
Also fixes `SongProgress` being displayed in skin editor on non-gameplay
screens, due to `GameplayClock` not marked as a required dependency.
2022-07-29 16:45:29 +03:00
3f72e76348 Expose StartTime from gameplay clock 2022-07-29 16:18:05 +03:00
3005ff1b9f Merge branch 'master' into pie-chart-progress 2022-07-28 22:19:27 +09:00
ce694123eb Move spectator begin/end playing to SubmittingPlayer 2022-07-28 20:44:04 +09:00
86c2b7e449 Apply nullability to DefaultSongProgress and clean up more stuff 2022-07-28 18:37:17 +09:00
ea027eda46 Move initial show to base implementation and add transition for legacy version 2022-07-28 18:29:49 +09:00
d5e5761892 Fix DefaultSongProgress graph not resetting if time is in intro 2022-07-28 18:25:24 +09:00
7108553883 Tidy up various things everywhere 2022-07-28 18:25:14 +09:00
0d36907cad apply code quality fixes 2022-07-28 15:30:45 +08:00
bca3994d91 set FirstHitTime and LastHitTime once 2022-07-28 15:25:12 +08:00
db62d4be3a apply suggestions
- refactor `SongProgress`
- make`UpdateProgress` more readable
- enable NRT on new classes
- refactor `TestSceneSongProgress` to use `GameplayClockContainer`
2022-07-28 15:15:41 +08:00
9088caa377 move LegacyComboCounter to osu.Game.Skinning 2022-07-28 08:36:26 +08:00
45c11f2b7b account for gameplay start time 2022-07-28 08:01:38 +08:00
37e642b0bd make SongProgress abstract
- move unrelated logic to `DefaultSongProgress`
- make `LegacySongProgress` inherit `SongProgress`
2022-07-27 15:19:21 +08:00
fa9daa6899 Fix TestSceneReplayRecorder not using score provided by gameplay state 2022-07-25 05:21:27 +03:00
ad09e728fd Move Passed assignment inside FailScore 2022-07-21 08:12:06 +03:00
0f0b19da4a Populate score with remaining "miss" statistics on fail/exit 2022-07-21 06:01:36 +03:00
6f37487528 Replace calls to defective Humanizer methods with correct version 2022-07-18 22:34:58 +02:00
e6236ba088 Update save score button to check availability after import
Previously was relying on whether `SaveReplay` returns null, but since
I've changed it to use the standard "prepare score for import" path, the
button has to check for local availability after import since that path
doesn't return null on fail.
2022-07-15 23:39:52 +03:00
6285442b7d Fix failed scores not prepared before import 2022-07-15 22:57:12 +03:00
2beed6d7b7 Allow failed scores to fail in replay playback 2022-07-15 20:45:48 +09:00
d325c534ab Check whether score is already imported and show correct state for save button 2022-07-15 20:45:37 +09:00
0200ef1d48 Make delegate firing more safe to being set later than BDL 2022-07-15 19:06:44 +09:00
0e788ac714 Simplify bindable logic greatly 2022-07-15 19:02:12 +09:00
8a48cb701d Tidy up implementation and remove unnecessary enum 2022-07-15 19:02:04 +09:00
ab6665d88c Merge branch 'master' into Save-Score-Failed 2022-07-15 18:02:58 +09:00
937692604e Remove mention of autoplay mod for now 2022-07-13 22:37:20 +09:00
ab3ec80159 Update LastPlayed on gameplay starting in a SubmittingPlayer 2022-07-13 16:43:43 +09:00
b52ea16133 Show basic error message when score submission fails 2022-07-12 15:10:59 +09:00
d2406242ae rename updateTooltip to updateState 2022-07-09 00:38:17 +09:00
91f471ebe0 disabled button instead of shake
removed `ShakeContainer`
2022-07-09 00:37:53 +09:00
a38c6704c2 Use ContinueWith, Check is Task empty 2022-07-09 00:23:32 +09:00
e4ebab92c6 Rename lots of weird variables 2022-07-08 18:37:03 +09:00
f3a6e646a6 Merge branch 'master' into Save-Score-Failed 2022-07-08 18:32:13 +09:00
9d730f8440 Fix custom rulesets not importing scores at all
Replaces the error with the ability to import, minus replays.

Closes https://github.com/ppy/osu/issues/17350 (arguably, but let's go with it for now).
2022-07-07 14:49:23 +09:00
1ccfd69690 Merge pull request #18978 from peppy/send-beatmap-hash-to-server
Send beatmap hash to server on solo score request
2022-07-03 13:18:17 +09:00
19d300e311 Fix player loader not accepting star difficulty updates after display 2022-07-02 09:17:38 +03:00
634b6cdbbe Send beatmap has to server on solo score request
Right now, the client does nothing to ensure a beatmap is in a valid
state before requesting to submit a score. There is further work to be
done client-side so it is more aware of this state (already handled for
playlists, but not for the solo gameplay loop), but the solution I have
in mind for that is a bit more involved.

This is not used server-side yet, but I want to get this sending so we
can start using it for some very basic validation.

Will resolve the basic portion of #11922 after implemented server-side.
2022-07-02 12:16:17 +09:00
33209ecd25 remove useless value change 2022-06-30 19:51:58 +09:00
fd0d8b1ce3 Add button state, fix async issues, watch replay method
Most borrowed from `ReplayDownloadButton`
2022-06-29 22:50:47 +09:00
6bfd351dec Add logging of GameplayClockContainer seeks 2022-06-28 15:23:29 +09:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
f71f6302fd Remove unnecessary null casts 2022-06-24 14:50:11 +09:00
bff35cb348 Shake button when replay already save 2022-06-22 01:19:20 +09:00
f2eb7e0551 Use better design and fix some problem
Let saveReplay async but still void
Make failed score's rank = F
2022-06-21 19:06:38 +08:00
b3e5642dfd Use WaitingOnFrames instead 2022-06-21 12:23:43 +09:00
43ead5820a deal with test 2022-06-21 00:54:50 +09:00