Commit Graph

602 Commits

Author SHA1 Message Date
3b49b7461e Schedule entire operation for safety
Also removes a redundant list copy.
2021-01-19 19:35:53 +01:00
78e590d25d Refactor skin sorting method
* Rename to `sortUserSkins` to convey meaning better.
* Sort in-place instead of slicing the list.
* Change to `void` to avoid misleading users that the method returns
  a new list instance.
* Fix typo in comment.
2021-01-19 18:36:42 +01:00
b00c6a1d60 Make first non-default skin index a property
The previous code was very brittle - it was not always updating
properly, and seems to have worked either by a carefully crafted set of
circumstances, or just plain coincidence.

Having this be a get-only property avoids potential error in the future
caused by not updating the index properly, at the expense of an added
linear lookup.
2021-01-19 18:31:37 +01:00
206a0b8bac Fix firstNonDefault staying as -1 2021-01-19 16:55:50 +00:00
a880b8d21d Satisfy AppVeyor 2021-01-19 16:11:16 +00:00
b265d2dab4 Remove another whitespace 2021-01-19 14:16:22 +00:00
1d4c813ff6 Merge branch 'sort-skins-alphabetically' of https://github.com/rednir/osu into sort-skins-alphabetically 2021-01-19 14:03:31 +00:00
31e61326e1 Only user skins are sorted 2021-01-19 14:00:17 +00:00
f1894a8bac fixed itemUpdated() 2021-01-19 12:17:56 +00:00
0b65c0cd25 Remove whitespace 2021-01-18 20:17:42 +00:00
da89426a3b Merge branch 'master' of https://github.com/ppy/osu into sort-skins-alphabetically 2021-01-18 20:09:15 +00:00
7476cb3047 Sort SkinSection in alphabetical order 2021-01-18 19:51:42 +00:00
1364de1166 Merge branch 'master' into beatmap-colour-setting 2021-01-18 16:07:46 +09:00
5278cad393 Reword setting to make more sense 2021-01-17 22:42:48 +09:00
5fd644fc57 Unify variable names 2021-01-17 22:42:48 +09:00
5f10bcce02 Added beatmap colour settings checkbox and associated tests. 2021-01-13 00:09:22 -05:00
24c1839739 Add global web setting for allowing explicit content 2021-01-12 11:10:25 +03:00
866fb28d6c Merge pull request #11411 from LavaDesu/feature/discord-presence-toggle
Add ability to toggle discord rich presence
2021-01-07 00:52:38 +09:00
15dd7a87a6 Move gameplay preview event binding to LoadComplete 2021-01-06 15:19:12 +09:00
d0d2e41b28 Fix display settings binding to configuration bindables in async load 2021-01-05 18:19:28 +09:00
2e5c67be3f Add ability to toggle discord rich presence
There are 3 modes: enabled, limited, and disabled.

The limited mode hides identifiable information such as username, rank, and
(if participating in one) multiplayer lobby name.
2021-01-03 10:37:28 +07:00
4f02928601 Change sorting to better handle portrait screens 2020-12-22 17:36:56 +09:00
3d5783a0ea Improve variable names 2020-12-22 17:34:51 +09:00
a1d67f0cf6 Merge branch 'master' into fix-resolution-dropdown 2020-12-22 17:26:53 +09:00
dab5924a63 Fix resolution dropdown not respecting current display changes 2020-12-22 08:02:42 +03:00
7c5964fad8 Revert window modes to previous code to correctly apply framework restrictions 2020-12-22 13:04:39 +09:00
5b8e35c98c Make settings dropdown abstract 2020-12-19 19:04:14 -08:00
b87f89986a Fix selected item not being highlighted on some setting dropdowns 2020-12-19 19:04:13 -08:00
26fa010fed Merge branch 'master' into import-screen 2020-12-15 12:37:27 +09:00
f4eb17d398 Update osu.Game/Overlays/Settings/Sections/Input/MouseSettings.cs
Set mouse confine mode at initialization

Co-authored-by: Dean Herbert <pe@ppy.sh>
2020-12-07 16:09:14 +09:00
2469608c10 Fix possible null reference due to bindable change before variable is initialized 2020-12-07 15:19:18 +09:00
71edada623 Hide confine setting entirely in fullscreen 2020-12-05 22:15:41 +01:00
60d8102a77 Merge branch 'master' into import-screen 2020-12-04 21:20:14 +08:00
7fd385efe6 Remove unused using directive 2020-12-02 20:01:58 +01:00
a2a10d4e13 Don't use nameof(MouseHandler) 2020-12-02 19:45:59 +01:00
bbde1f6b9c Fix MouseHandler not being ignored when raw input is enabled 2020-12-02 18:56:59 +01:00
285e62be9a Bring code in line with SDL2 defaults 2020-12-01 17:47:07 +09:00
965cc1f511 Remove unnecessary usings #2 2020-11-30 17:57:25 +09:00
fe48b2279c Adjust various paddings and spacings in settings to make them easier to visually parse 2020-11-30 17:50:35 +09:00
a3dd22f5c2 Merge branch 'master' into settings-remove-transparency 2020-11-30 17:50:26 +09:00
bf2c6dc241 Remove unused usings rider couldn't see 2020-11-30 17:49:55 +09:00
a4e061cb11 Remove semi-transparent backgrounds from settings and notifications overlays
I tried also updating the colours to the "new" versions from designs but
they don't match due to colour profile differences (so I'm not yet sure
if they are correct or not) and also don't look great without all the UI
elements also being updated.
2020-11-30 17:19:55 +09:00
4e1e45f3e7 Move hold-to-confirm back to UI section 2020-11-30 16:15:35 +09:00
55c8aa5d5f Move menu cursor size to UI section 2020-11-30 16:14:15 +09:00
e0a84ff1dc Move hold-to-confirm setting back to gameplay section 2020-11-29 22:07:34 +01:00
a5c4a8d2e9 Create "User Interface" settings section 2020-11-29 22:07:33 +01:00
579e61eab9 Allow null 2020-11-28 16:31:24 +08:00
9a3dd12f30 Move to debug settings 2020-11-18 18:15:56 +08:00
610ed99ae3 Add null checks to unguarded resolved-as-null fields 2020-11-14 14:52:58 +01:00
a2c81a3a52 Add back setting to toggle "always play first combo break" 2020-11-13 13:42:00 +09:00