7cd3f5656d
Cleanups
2019-10-14 16:43:43 +03:00
7ac87494e0
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api
2019-10-14 16:21:34 +03:00
89f270a19a
SortSelector -> SortTabControl
2019-10-14 21:32:41 +09:00
ae1a361f9f
Merge branch 'master' into commenst_header
2019-10-14 21:20:05 +09:00
2f209d1dfa
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api
2019-10-13 14:53:41 +03:00
a44cc2e70b
Implement CommentsShowMoreButton
2019-10-13 14:43:30 +03:00
27e3ffd293
Update dependencies
2019-10-13 11:23:49 +03:00
7f867562ca
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api
2019-10-13 11:15:43 +03:00
00f0957cc3
Merge branch 'master' into editor-grids-2
2019-10-12 23:28:51 +09:00
7ffe5ac539
Merge remote-tracking branch 'refs/remotes/ppy/master' into commenst_header
2019-10-12 15:02:12 +03:00
26a33bfa4e
Merge branch 'master' into fix-resume-from-player-audio
2019-10-11 19:21:14 +09:00
631f155554
Add grid to make the test not appear empty
2019-10-11 18:24:33 +09:00
050d86a741
Always use the local coordinate space
2019-10-11 18:24:33 +09:00
9ecec806c2
Rename grid creation method + parameter
2019-10-11 18:24:33 +09:00
5f0cd356d7
Rename startPosition to centrePosition
2019-10-11 18:24:33 +09:00
824595427d
Remove extra whitespace
2019-10-11 18:24:33 +09:00
2aa3d0bb39
Implement base class for beat snapping grids
2019-10-11 18:24:33 +09:00
c7eb0b401b
Merge branch 'master' into ignore-macosx-folder-in-archives
2019-10-11 14:36:52 +09:00
f6e1e5b2ed
Merge branch 'master' into fix-line-buffered-reader-tests
2019-10-11 12:42:58 +09:00
11acd177f1
Add import test with files to be filtered out
...
Add a test case reproducing the conditions encountered "in the wild"
wherein a skin import would be performed incorrectly due to a __MACOSX
resource fork directory present next to a directory with the actual skin
files in the archive.
2019-10-10 23:54:17 +02:00
c8ffc134d4
Use nameof when instantiating headless game hosts
...
As a purely cosmetic code improvement, substitute string literals
in constructor calls of HeadlessGameHost in ImportBeatmapTest for nameof
operator usages.
2019-10-10 22:36:43 +02:00
cb1f7e2dc7
Fix platform dependency in buffered reader test
...
Tests for the line-buffered reader added in 7b1ff38
were subtly
dependent on the execution environment due to differing end-of-line
markers on Windows and Unix-based systems.
Because StreamReader discards all newlines when reading line-by-line,
LineBufferedReader used a StringBuilder to patch the peeked lines
back together with the remaining contents of the file being read.
As StringBuilder.AppendLine uses the environment-specific newline
delimiter, the delimiters after the peeked-but-unconsumed lines can
therefore be substituted by the platform-specific variants, causing
the test failures due to the overly-simplified way they were written.
Reformulate the test to avoid such issues from resurfacing again
by splitting lines by \r or \n and then testing each line individually.
Additionally remove all raw literals in favour of explicitly mixing
various line delimiter character sequences for additional coverage.
2019-10-10 15:33:18 +02:00
8255a94cd4
Merge branch 'master' into fix-resume-from-player-audio
2019-10-10 22:08:20 +09:00
b45e7246b8
Rename SortCommentsBy to CommentsSortCriteria
2019-10-10 15:56:08 +03:00
5eba33e876
Simplify logic and add test coverage for remaining case
2019-10-10 20:12:47 +09:00
64f62bd2bf
Implement CommentsHeader component
2019-10-10 12:06:25 +03:00
5d6648d9c9
Update 2.2 references
2019-10-10 17:45:38 +09:00
8df2e359c4
Fix tests on CI
2019-10-10 17:42:15 +09:00
371b7841d0
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api
2019-10-10 11:27:44 +03:00
f74c79c2b8
Fix audio playback position being reset after resuming to song select
2019-10-10 11:58:43 +09:00
107d39c3e9
Add DeletedChildsPlaceholder to the bottom of the comments container
2019-10-09 14:10:05 +03:00
7e3c97f496
Implement DeletedChildsPlaceholder component
2019-10-09 13:37:07 +03:00
0a56b041fd
Implement ShowChildsButton
2019-10-09 11:07:56 +03:00
f2adae8fd1
Rename test case to better match underlying class
2019-10-09 16:05:38 +09:00
6deafc04bf
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api
2019-10-09 10:00:20 +03:00
69b9e359bf
Merge branch 'master' into fix-ss-track-playback
2019-10-09 12:26:07 +09:00
e8276dc562
Merge branch 'master' into fix-ignored-test
2019-10-09 11:39:40 +09:00
29b0eacc82
Implement SortSelector component
2019-10-08 22:46:42 +03:00
574170124c
Implement HeaderButton component
2019-10-08 21:38:19 +03:00
b9ad079bf8
Move CommentsHeader to it's own file
2019-10-08 20:57:55 +03:00
1c89841949
Move all the logic to it's own namespace
2019-10-08 14:51:12 +03:00
275648ee4f
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api
2019-10-08 13:31:52 +03:00
4446a2972c
Move WaveContainer test out of editor namespace
2019-10-08 18:08:05 +09:00
8ebccfe31f
Add comprehensive audio state tests
2019-10-08 17:03:13 +09:00
f284d096b7
Fix ignored song select test
2019-10-08 16:37:47 +09:00
aa8df0fa20
Hook up api and implement some visual comments representation
2019-10-07 18:26:07 +03:00
e772822bd5
Basic implementation
2019-10-07 17:49:20 +03:00
46d6c5ec3b
Add failing test
2019-10-07 15:17:03 +09:00
62c4c1266e
Move private functions to bottom
2019-10-07 15:17:03 +09:00
93c0cf14c1
Merge branch 'master' into allow-fallback-decoder-overwrite
2019-10-05 10:56:57 +08:00