Commit Graph

26251 Commits

Author SHA1 Message Date
660bf50dc7 Clarify multiple coordinate systems
- Fix wrong position is set for DHOs for down/right scrolling direction.
2021-06-14 13:13:27 +09:00
09f1cbde7e Fix TimeAtPosition doc comment 2021-06-14 13:13:27 +09:00
fdb09ef4d7 Simplify flipPositionIfRequired using scrollLength 2021-06-14 13:13:27 +09:00
8cf4454780 Use Direction enum instead of int
The property is named `scrollingAxis` to distinguish from `direction`, which is of `ScrollingDirection` type (unfortunate name crash).
2021-06-14 13:13:27 +09:00
17347401cf Remove unused RankingType enum
We have `BeatmapLeaderboardScope` instead.
2021-06-14 11:27:46 +09:00
ef9cb2c958 Rename nested classes 2021-06-12 18:37:31 +02:00
b79d57b68c Move OsuSettingsNumberBox into SettingsNumberBox 2021-06-12 17:57:40 +02:00
c728f673d6 Rename classes 2021-06-12 17:37:01 +02:00
29f3880415 Move classes into SettingsTextBox 2021-06-12 17:34:02 +02:00
bb661abfa6 Clean up OsuModSettingsTextBox 2021-06-12 17:25:22 +02:00
fe39a47797 Add OsuModSettingsTextBox and OsuModSettingsNumberBox 2021-06-12 00:34:53 +02:00
902bb84ca8 Merge branch 'master' into fix-wave-overlay-sound-on-switch 2021-06-11 22:05:08 +02:00
f773ea475d Update framework 2021-06-12 01:37:13 +09:00
c2759121b9 Merge pull request #13454 from nekodex/change-default-hover-click-sample
Change default HoverSounds/HoverClickSounds samples
2021-06-12 01:01:35 +09:00
121df57dca Fix focused overlays playing their "appear" sound when not necessarily changing state 2021-06-12 00:26:33 +09:00
0dbe5dd219 Remove unused using statement 2021-06-12 00:23:18 +09:00
d9ea8d64d4 Remove weird local sample logic in ChangelogOverlay 2021-06-12 00:05:49 +09:00
8de0d33c5a Revert "Move collection change bind to LoadComplete"
This reverts commit d6d87e1975.

Actually that broke things due to the "disableable" instances not added early enough, revert for now.
2021-06-11 17:59:29 +03:00
b6947c25ec Fix potentially adding the same skin multiple times 2021-06-11 17:55:07 +03:00
e098cac1cf Minor code reformatting / moving 2021-06-11 23:49:14 +09:00
5887b4a27c Update stand-alone usage of hover/select sounds in DrawableOsuMenuItem 2021-06-11 23:46:42 +09:00
d6d87e1975 Move collection change bind to LoadComplete
Best practice anyways
2021-06-11 17:35:33 +03:00
97bb3de1c9 Update resources 2021-06-11 23:03:27 +09:00
9c6c1dd237 Merge branch 'master' into change-default-hover-click-sample 2021-06-11 23:03:23 +09:00
108a3deb27 Also handle null Ruleset.CreateLegacySkinProvider values
Let's just go this way for now, maybe it's a better choice to always create transformers and disallow null, but it's too much work and out of scope at this point
2021-06-11 16:26:54 +03:00
dca001a72d Upgraed localisation analyser packages 2021-06-11 22:22:47 +09:00
550d566bf9 Simplify member access 2021-06-11 14:24:17 +02:00
876a357bf2 Add support for animated colour fill in new style legacy health bar 2021-06-11 14:24:17 +02:00
0b95d07390 Change 'default' hover/click samples into 'button' samples and make 'soft' the new 'default' 2021-06-11 20:47:57 +09:00
3389c4830b Merge branch 'master' into refactor-scrolling-hoc-1 2021-06-11 20:35:19 +09:00
4f80a3b66d Add fallback-to-default logic for HoverSounds and HoverClickSounds 2021-06-11 20:14:35 +09:00
0c8851f4b7 Extract drawable.ScreenSpaceDrawQuad to a variable 2021-06-11 07:06:22 -04:00
26312bf60a Merge branch 'master' into chat-mention 2021-06-11 20:03:44 +09:00
a6774eb5b5 Inline getOriginPositionFromQuad 2021-06-11 06:59:00 -04:00
c9b4f9eb71 Make getOriginPositionFromQuad local 2021-06-11 06:55:47 -04:00
1bc8460902 Rename getTieredComponent to getAnchorFromPosition
Also rename parameter `component` to `xOrY`.
2021-06-11 06:53:40 -04:00
6e181a6b63 Rename parameters of getTieredComponent 2021-06-11 06:53:04 -04:00
a76eaeb52d Make getTieredComponent local 2021-06-11 06:51:12 -04:00
15d3b4444d Rename HoverSounds and HoverClickSounds samples 2021-06-11 19:34:54 +09:00
635300b311 Recalculate closest anchor when origin is changed 2021-06-11 06:28:30 -04:00
a506f2a776 Revert rename of lambda variables 2021-06-11 06:22:24 -04:00
f20146d446 Fix potentially adding null skin sources 2021-06-11 12:58:38 +03:00
e59beffc4e Forward all base transformer lookup methods to Skin 2021-06-11 12:44:25 +03:00
9e16359f18 Refactor disallowing in SkinProvidingContainer to become per source
Fixes `FindProvider` becoming completely broken, because of no way to perform the checks on one skin source.
2021-06-11 12:29:29 +03:00
af3f253b21 Refactor ScrollingHitObjectContainer and expose more useful methods 2021-06-11 18:28:48 +09:00
8eab7df955 Move BindCollectionChanged out of async load 2021-06-11 17:51:58 +09:00
2e01e61177 Move TODO comment to correct location 2021-06-11 11:46:30 +03:00
8132852753 Add other affectable change action cases 2021-06-11 11:34:22 +03:00
a985e3b8d3 Apply documentation settings for better readability
Co-authored-by: Dean Herbert <pe@ppy.sh>
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-06-11 11:25:07 +03:00
20759657de Rename configuration variables and refactor lots more 2021-06-11 16:37:31 +09:00