ee5eb9576f
Fix completely wrong conditional logic
2021-05-28 18:38:50 +09:00
581a86b91a
Revert "Revert "Fix editor tests failing due to empty files being specified""
...
This reverts commit 1af684c4b2
2021-05-28 14:33:06 +09:00
41733af0ed
Revert "Revert "Make BeatmapSetInfo.Files non-nullable""
...
This reverts commit 9c4f39e968
2021-05-28 14:33:05 +09:00
b349ff8693
Revert "Add temporary accounting for tests with null files"
...
This reverts commit e52c0a34f8
2021-05-28 14:33:04 +09:00
f1b5aced6f
Merge branch 'master' into editor-exit-stability
2021-05-28 14:32:32 +09:00
e52c0a34f8
Add temporary accounting for tests with null files
2021-05-28 14:31:26 +09:00
9c4f39e968
Revert "Make BeatmapSetInfo.Files non-nullable"
...
This reverts commit c24712642c
2021-05-28 14:15:28 +09:00
1af684c4b2
Revert "Fix editor tests failing due to empty files being specified"
...
This reverts commit fdbd421040
2021-05-28 14:15:28 +09:00
b13b732e02
Remove incorrect DefaultSkin usage
2021-05-27 14:50:56 +09:00
14a4095140
Merge branch 'master' into beatmap-skin
2021-05-26 18:39:47 +09:00
29e1737f0d
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-24 15:51:03 +09:00
4f6de6fdc6
Implement GetSkin() for other working beatmaps
2021-05-21 20:21:29 +03:00
318e5fc60b
Mark WorkingBeatmap.GetSkin() as abstract
2021-05-21 20:14:26 +03:00
c24712642c
Make BeatmapSetInfo.Files non-nullable
2021-05-20 17:39:52 +09:00
fdbd421040
Fix editor tests failing due to empty files being specified
2021-05-20 17:09:55 +09:00
7980bdd384
Revert incorrectly changed requery code
2021-05-20 15:41:58 +09:00
825d61e22c
Separate default beatmap skins from DefaultSkin
2021-05-19 12:06:10 +03:00
a639132825
Avoid doing any re-fetch on beatmap from test scenes
2021-05-19 17:58:28 +09:00
ce7c503e6e
Merge branch 'master' into playlist-unicode
2021-05-17 11:47:10 +09:00
dc56250a3c
Merge branch 'master' into player-loader-star-rating
2021-05-15 15:39:57 +09:00
e0728a6e19
Make BeatmapDifficultyCache.GetDifficultyAsync virtual
2021-05-14 15:52:36 +03:00
32ff406289
Add database tracking of beatmap creator user_ids
2021-05-14 15:40:29 +09:00
77e422409c
Add SkinInfo.InstantiationInfo to allow creating different skin types
2021-05-11 23:37:06 +09:00
c7325f0f77
Add missing load delay
...
That was a bad one... `ModelBackedDrawable` has a default of 0ms load delay, while previously the wrapper created for beatmap set cover used default 500ms, this change is bringing the load delay back, to avoid firing hundreds of web requests just when doing a quick long scroll on beatmap listing.
2021-05-07 08:09:02 +03:00
283488ea53
Use TransformImmediately instead at beatmap listing search control
...
Applies two changes:
- Use `TransformImmediately` which achieves the same wanted transition behaviour without any issues.
- Move the transition behaviour override into `BeatmapListingSearchControl` in a nested subclass of `UpdateableBeatmapSetCover`.
2021-05-07 03:36:32 +03:00
6fb9eb8b33
Move legacy beatmap combo offset to osu! processor
...
Better suited there, I intiailly wanted the whole legacy interface to reside in `osu.Game.Rulesets.Osu` but it's required in `ConvertHitObjectParser` and that's in the main game project, so had to leave the interface as-is for now.
2021-05-05 14:24:14 +03:00
cd6d070b4a
Consider "combo offsets" as legacy logic and separate from combo information
2021-05-05 07:43:08 +03:00
32b3ea70b9
Fix both covers showing if cover is not fully opaque
2021-05-04 21:12:50 +02:00
f52375eed2
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-03 15:58:13 +02:00
2e24b69d62
Merge pull request #12617 from Joehuu/fix-pp-column-approved-maps
...
Fix approved maps not displaying pp column on score table
2021-05-02 13:27:39 +09:00
0d077b7a5d
Fix GetClosestBeatDivisor returning the wrong divisor
2021-05-01 14:13:42 +08:00
786ab163f6
Rename extension and move to bottom of file
2021-04-30 12:40:16 -07:00
eeb66a955e
Merge branch 'master' into mbd-beatmap-set-cover
2021-04-30 08:14:33 +09:00
cfbf95b433
Add HasPerformancePoints extension method
2021-04-29 14:11:35 -07:00
859898d98f
Refactor lookup methods to avoid linq and reduce TimingPointAt calls
2021-04-28 17:16:05 +09:00
c5186b6a69
Revert return values to non-rounded doubles
2021-04-28 16:59:49 +09:00
f3c7694eeb
Rename methods to match generally how these find-methods are named elsewhere
2021-04-28 16:57:52 +09:00
48d6c9ac4b
Move snap/divisor helper methods to inside ControlPointInfo
2021-04-28 16:47:30 +09:00
217ff8238e
Add snapping time comment
2021-04-27 01:23:03 +02:00
6d5883abcb
Return result of local variable instead
2021-04-27 01:19:38 +02:00
7b9ed924be
Rename snapping methods
...
Further separates them from `IBeatSnapProvider`'s `SnapTime`, and groups them together more, to prevent confusion between the two interfaces.
Also changes the xmldoc of the reference time to that of `IBeatSnapProvider` for consistency.
2021-04-26 16:07:30 +02:00
049e42fa85
Move snapping responsibility to IBeatmap
...
Seems `EditorBeatmap` already implements a different kind of `SnapTime` from `IBeatSnapProvider`, so method names here aren't great.
This is very similar to what https://github.com/ppy/osu/pull/12558 is doing, so may need to do some duplicate resolution later, especially surrounding `ClosestBeatSnapDivisor`.
Worth noting that this change makes 1/7, 1/5, etc unsupported for now, as we now rely on `BindableBeatDivisor.VALID_DIVISORS`.
2021-04-26 05:07:24 +02:00
e9dfa2860a
Add xmldoc note about path being relative
2021-04-20 13:44:06 +02:00
d7a81471c8
Add xmldoc to GetPathForFile
2021-04-20 13:40:38 +02:00
0e6b66f457
Merge branch 'master' into bg-audio-quality-checks
2021-04-20 02:36:13 +02:00
1478bcfa8e
Improve xmldoc consistency
2021-04-20 02:30:27 +02:00
67e4fe4284
Add xmldoc to GetStream
2021-04-20 02:28:38 +02:00
f168247254
Add Track as a property to IWorkingBeatmap
...
This is implemented by `WorkingBeatmap` already, and is much better to use than loading the track every time we need it.
2021-04-20 01:35:41 +02:00
d5829fe638
Merge branch 'master' into playlist-unicode
2021-04-19 19:24:04 +02:00
a10a8680d0
Add new display for timing row attributes
2021-04-19 16:23:06 +09:00
