Commit Graph

2283 Commits

Author SHA1 Message Date
e4758c9dbb Mark LabelledTimeSignature as public 2022-01-23 10:14:37 +03:00
54f7b1b8d0 Use new time signature control on timing screen 2022-01-22 20:50:32 +01:00
f39f2c93b5 Add control for arbitrary-numerator time signatures 2022-01-22 20:50:31 +01:00
735414bc49 Replace TimeSignatures enum with struct for storage of arbitrary meter 2022-01-22 20:50:31 +01:00
5f5765d6a2 Reduce redundancy time range to create a bit more visual blending on the timeline 2022-01-19 14:57:01 +09:00
03ac91a3ee Consider all points in a group to meet redundancy check 2022-01-19 14:56:44 +09:00
93cd07f7fb Merge branch 'master' into summary-timeline-control-point-optimisation 2022-01-19 14:50:45 +09:00
67bf95bc91 Remove all usage of AuthorString 2022-01-18 23:30:40 +09:00
d10d657073 Merge pull request #16421 from Susko3/textbox-AllowIme-false
Add `AllowIme => false` to text boxes where applicable
2022-01-18 18:02:47 +09:00
39c9c4985b Merge branch 'master' into textbox-AllowIme-false 2022-01-18 17:03:51 +09:00
566d341b1e Split conditions out for readability 2022-01-16 22:04:29 +09:00
565611ee00 Fix typo in inline comment 2022-01-15 23:57:20 +09:00
236fa6da7e Rename ControlPointVisualisation interface type to be less specific 2022-01-15 23:56:00 +09:00
c5cae4e3ee Rename methods and add xmldoc 2022-01-15 23:55:11 +09:00
03e4ec4214 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-15 14:45:42 +01:00
64c499d9d6 Revert unintended temporary commenting (was used during benchmarking) 2022-01-15 15:24:30 +09:00
19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
c64a919a9d Reduce number of redundant control points displayed on summary timeline
As pointed out in https://github.com/ppy/osu/discussions/16435, beatmaps
with too many control points (usually added via external automation
apps) could cause the lazer editor to grind to a halt.

The overheads here are mostly from the GL side. An eventual goal would
be to render this in a smarter way, rather than using thousands of
drawables. Until that, this optimisation should help reduce the overhead
by omitting control points in close proximity that are redundant for
display purposes.

I've tried to contain this in the display logic directly, with the goal
that it can be ripped out as fast as it was added. Certainly required
more changes than I hoped for, but I don't think it's too ugly.
2022-01-14 17:13:26 +09:00
51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
7509a9ff8f Update BeatmapModelManager.Save to work for editor scenarios 2022-01-12 17:49:11 +09:00
3811bd8520 Fix some null inspections 2022-01-12 17:00:16 +09:00
a3276758b8 Remove unnecessary re-query of beatmap set in editor menu construction 2022-01-12 17:00:16 +09:00
b8cd3cdbbc Various updates to ruleset and primary key usages to move closer to realm support 2022-01-12 16:57:13 +09:00
83cbee39de Mark cases where BeatmapSet is generally guaranteed to be non-null 2022-01-12 16:39:36 +09:00
a0842838e7 Add AllowIme => false where applicable
Also adds `AllowWordNavigation => false` to password text box.
2022-01-12 00:15:17 +01:00
d76c674abc Add tooltip with relative rotation in degrees to rotation handles 2022-01-08 20:24:15 +01:00
24d377fddb Move implementation of drag handle operations to concrete classes 2022-01-08 20:24:00 +01:00
9370e84460 Fix effect point multiplier text box displaying too much decimal digits 2022-01-08 16:12:52 +01:00
6779503e57 Refactor logic to avoid TimelineSelectionHandler having to block base calls 2022-01-05 16:56:54 +09:00
866ae3472b Add global flip hotkeys 2022-01-05 16:48:07 +09:00
13cce50fa7 Remove existing handling of flip hotkeys 2022-01-05 16:30:42 +09:00
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
98524d60a4 Fix clear identifier typos 2021-12-27 20:26:28 -08:00
7ab1c0c99d Improve contrast of timeline blueprint foreground content for pastel combo colours 2021-12-21 12:54:17 +01:00
63a017bc8e Use Array.Empty instead 2021-12-11 19:33:37 +09:00
c1b3ee6bb2 Fix editor not resetting mods when entering
Would leave the user potentially in a test mode that is in a weird
state (ie. if cinema mod was enabled). Eventually we'll add the ability
to choose mods for test play, but that will be done in a saner way.

Closes #15870.
2021-12-10 18:57:45 +09:00
10dd64e07c Fix being able to paste objects while composer is loading
Would lead to exceptions due to modification of `Beatmap.HitObjects`
during its enumeration by `DrawableRuleset`, which was happening as an
async load via `EditorScreenWithTimeline.CreateMainContent()`.
2021-12-07 21:00:25 +01:00
1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
a7e4e7be3a Remove the ability to specify a filename in ReplaceFile 2021-11-29 18:11:51 +09:00
e2ebcf7a26 Remove unnecessary manager parameter
Confused why I added this in the first place..
2021-11-25 18:36:03 +09:00
cc1b91e4bd Split out legacy model export logic into LegacyModelExporter classes 2021-11-25 16:41:12 +09:00
0eea026afb Remove null checks on CreateInstance() calls 2021-11-24 12:23:09 +09:00
7599efac30 Update editor cases where repeat should not be handled 2021-11-18 13:13:36 +09:00
5471994450 Merge branch 'master' into sample-point-multiple 2021-11-15 14:13:58 +09:00
6b4b6de554 Fix test gameplay starting in a hidden state 2021-11-13 22:11:00 +01:00
2562412125 Propagate clock state from gameplay test back to editor 2021-11-13 22:11:00 +01:00
d2ddc25ab3 Propagate clock state from editor to gameplay test 2021-11-13 22:10:59 +01:00
9a19a516f9 Adjust spacings on sample point piece popover 2021-11-13 21:59:45 +01:00
73ca1d39a2 Improve sample bank text box UX in case of multiple selection 2021-11-13 21:59:44 +01:00
3fee6b0938 Add support for setting sample bank & volume for multiple objects at once 2021-11-13 21:24:59 +01:00