13ef097a53
Annotate potentially null parameters in protected ctor of LegacySkin
2020-12-22 12:08:40 +09:00
10c2745682
Add region specifications around implicit interface implementations
2020-12-22 12:01:09 +09:00
a5bcf1dc20
Expose resources to skin via interface (and share common pieces with beatmap)
2020-12-21 15:18:52 +09:00
c002184768
Clamp osu!mania's HitPosition offset to match osu-stable implementation
...
Closes #11184 .
2020-12-16 18:08:19 +09:00
ca11eeefdf
Merge branch 'master' into mania-legacyskin-scoreposition
2020-12-14 11:25:34 +09:00
3741c2339a
simplify implementation and adjust the default values
2020-12-13 22:43:36 +06:00
2108844319
apply ScorePosition to the judgement container
2020-12-13 22:01:08 +06:00
b3d8347315
add support for ScorePosition into LegacyManiaSkin
2020-12-10 20:11:08 +06:00
f6d15b9757
Invert back-to-front logic
2020-12-06 18:59:38 +01:00
fcd9483ffa
Merge branch 'master' into fix-multiple-playback-on-skin-change
2020-12-06 18:21:24 +01:00
a0f92628ac
Merge branch 'master' into fix-sample-expire
2020-12-04 13:49:08 +09:00
6c46046c24
Fix DHO expires while hit sound is playing
2020-12-03 12:32:49 +09:00
2c57deea2b
Trim double full-stop in xmldoc
2020-11-30 19:43:20 +01:00
c29ad8edf8
Better API for dealing with the contained drawable samples
2020-11-30 19:26:25 +09:00
f5e8d1d14d
Lose old reference immediately on updateSample()
2020-11-30 19:19:24 +09:00
afb8eb636d
Apply simple PR reviews
2020-11-30 18:40:22 +09:00
4bbeb9ebd4
Merge branch 'master' into hit-sample-pooling
2020-11-30 18:31:58 +09:00
1c31a4a6b6
Expose animation start time as mutable in interface
2020-11-22 13:11:22 +01:00
a3b1d14f17
Apply similar fix to PoolableSkinnableSound
2020-11-22 14:44:39 +09:00
240c1b0aef
Add support for changing animation start time after load
2020-11-21 20:06:30 +01:00
8080fe942c
Fix samples being played more than once on skin change
2020-11-20 20:38:26 +09:00
a00e0d7279
Move CanBeNull specification to the interface
2020-11-20 16:30:48 +09:00
7fe0923fcf
Show main judgement content above hitobjects
2020-11-20 16:25:48 +09:00
7c83a27002
Add more xmldocs
2020-11-19 22:48:21 +09:00
8a656f7cee
Fix missing SkinChanged event + safety
2020-11-19 22:42:44 +09:00
d388c44428
Cleanup, refactoring, and restart sample on skin change
2020-11-19 22:30:21 +09:00
0287269b2f
Fix volume discrepancies
2020-11-19 21:21:30 +09:00
70cb197957
Cleanups
2020-11-19 20:38:36 +09:00
812d5d59b1
Fix looping not being propagated
2020-11-19 20:29:09 +09:00
003fed857c
Separate files
2020-11-19 19:52:34 +09:00
730b14b5bb
Add initial hit sample pooling
2020-11-19 19:51:09 +09:00
9d04ce75cc
Make particles additive and consume in judgement explosions
2020-11-19 15:47:02 +09:00
85c5c68dfa
Provide particle drawable as a function (for future use)
2020-11-19 13:20:21 +09:00
24d7fa03d8
Merge branch 'master' into legacy-jugement-match-stable-transforms
2020-11-18 20:33:58 +01:00
5156de3a10
Merge branch 'master' into fix-judgement-transform-logic
2020-11-18 19:20:11 +01:00
c47e70da9b
Update animations for new/old miss style and add fades
2020-11-18 19:03:34 +09:00
9d0a6de26e
Fix SkinnableSprite initialising a drawable even when the texture is not available
2020-11-18 19:03:34 +09:00
5bd4ace37f
Split out new and old style legacy judgement pieces
2020-11-18 19:03:34 +09:00
8be31f4805
Adjust legacy skin judgement transforms to match stable
2020-11-18 19:03:05 +09:00
bb1aacb360
Fix SkinnableSprite initialising a drawable even when the texture is not available
2020-11-18 18:07:00 +09:00
57eaee27ae
Rename param to match type better
2020-11-17 20:12:04 +01:00
dd4b69feab
Add legacy judgement implementation which doesn't transform on animations
2020-11-17 15:46:57 +09:00
9a7fdb2b7e
Move skin deletion logic to OsuGameBase to promote thread safety
...
`CurrentSkinInfo` is used in multiple places expecting thread safety,
while ItemRemoved events are explicitly mentioning they are not thread
safe. As SkinManager itself doesn't have the ability to schedule to the
update thread, I've just moved the logic to `OsuGameBase`. We may want
to move the current skin bindable out of the manager class in the
future to match things like `BeatmapManager`.
Closes https://github.com/ppy/osu/issues/10837 .
2020-11-16 16:43:19 +09:00
8d38d9cc93
Add hotkey to select random skin
2020-11-11 13:05:03 +09:00
6b548ef5e4
Split out SkinInfo ID constants and fix random logic
2020-11-11 11:54:40 +09:00
a5e13e4d2c
Merge branch 'master' into shuffle-skin
2020-11-11 11:34:48 +09:00
8706b51b77
Merge pull request #10717 from smoogipoo/dho-apply
2020-11-11 10:54:24 +09:00
7b0e387dfc
apply different offset based on whether the marker is newStyle or not
2020-11-09 08:20:19 +01:00
490fbd1dd8
Fix ki* textures having an incorrect vertical position
2020-11-09 05:54:48 +01:00
248d342a2f
Initial Apply()/FreeAfterUse() DHO implementation
2020-11-06 23:02:37 +09:00
