326ff3b6e9
Fix CurrentDialog being updated twice, unsafe variable access
2022-05-05 14:55:05 +09:00
86aa2125fe
Add test coverage for multiplayer mod validity methods
2022-05-05 08:13:29 +03:00
e3c7c5d0b9
Improve validity methods to include system, non-implemented, and multi mods
2022-05-05 08:13:06 +03:00
a26793cd65
Add missing Test prefix
2022-05-05 06:12:24 +03:00
f28978b856
Handle against playlists which disallow selection
...
`SelectedItem.Disabled` is also not checked against in the select-via-click flow inside `DrawableRoomPlaylistItem` (only `AllowSelection` is checked).
2022-05-05 05:48:35 +03:00
464b3af5f3
Rename local correctly
2022-05-05 05:42:20 +03:00
81b4622620
fixed autoplay not showing compat, + relax compat
2022-05-04 22:25:34 +01:00
a27fcda9f1
Fix failing tests due to CurrentDialog being unexpectedly not set after Push
2022-05-05 01:52:39 +09:00
d0df9e8051
Inline CheckCompatibleSet method to avoid ugly boolean flag
2022-05-04 18:56:30 +03:00
8488a29e9e
Renew obsoletion date
2022-05-04 17:22:11 +03:00
8f04db5df5
Bring back behaviour of checking incompatibility on gameplay validity
2022-05-04 17:21:19 +03:00
20e277d2e5
Apply proposed naming changes
2022-05-04 17:12:17 +03:00
e9ecf26b6a
Merge branch 'master' into multiplayer-disable-adaptive-speed
2022-05-04 17:12:03 +03:00
e294069e2f
Merge branch 'master' into beatmap-selection-keybinding
2022-05-04 16:48:49 +03:00
9416346c94
Globalise beatmap selection key bindings as "group" selection
2022-05-04 16:46:32 +03:00
1a85e1267b
Ensure focus is directed to ChatTextBox from ChatOverlay and add tests
2022-05-04 14:43:40 +01:00
ddab3c6d80
Tidy up state variables
2022-05-04 21:00:11 +09:00
81ce0e6565
Reimplement sliderticks
2022-05-04 12:55:22 +01:00
e6fdef2d7a
Fix test failures due to selection/item collection desyncs
2022-05-04 13:51:47 +02:00
e920bbd497
Merge pull request #18081 from bdach/mod-overlay/test-coverage-parity
...
Port test coverage from old mod select overlay to new design
2022-05-04 20:24:50 +09:00
383245f43a
Fix dialoged pushed to DialogOverlay too early potentially doing cross-thread transforms
...
As seen at https://github.com/ppy/osu/runs/6287700705?check_suite_focus=true .
2022-05-04 20:23:36 +09:00
cf220f171b
Add test coverage of cross-thread transforms if a dialog is pushed too early
2022-05-04 20:23:36 +09:00
0405c1c34a
Ensure selected playlist item is always scrolled into view
2022-05-04 13:15:26 +02:00
ec27fa8e85
Add test coverage for keyboard selection
2022-05-04 13:15:10 +02:00
e4ac714c6d
Merge pull request #18088 from peppy/fix-editor-toolbox-click-through
...
Fix clicks and drags around editor toolboxes resulting in unexpected interactions
2022-05-04 19:42:32 +09:00
5f11ff564b
Merge branch 'master' into mod-overlay/test-coverage-parity
2022-05-04 19:40:56 +09:00
3eead5a6a3
Rename FlushAnimation to FlushPendingSelections to better match purpose
2022-05-04 19:40:08 +09:00
3b04daddaa
Fix self-reference in region name
2022-05-04 12:36:43 +02:00
df1f4aecdc
Add support for traversing playlist items using next/previous bindings
...
Addresses https://github.com/ppy/osu/discussions/18061 .
2022-05-04 19:09:44 +09:00
2f12c7d9e1
Change ChatTextBox to not handle up/down arrows
2022-05-04 19:09:22 +09:00
bf80dd864c
Merge branch 'master' into fix-editor-toolbox-click-through
2022-05-04 11:57:32 +02:00
6380216263
Nudge click location to avoid placement failures
2022-05-04 11:56:44 +02:00
a759e641eb
Enforce composer aspect ratio to avoid depending on ambient window size
2022-05-04 11:56:29 +02:00
0018408bdb
Merge pull request #18071 from frenzibyte/distance-spacing-osd
...
Display toast notification on editor distance spacing changes
2022-05-04 18:42:00 +09:00
4e0f899159
Rename value changed variable
2022-05-04 18:13:30 +09:00
f5d4f02200
Use ToUpper for key binding text
2022-05-04 11:59:29 +03:00
f899c3e68f
Add test coverage of circle placement around editor toolboxes
2022-05-04 17:56:53 +09:00
0b8fd2e39f
Improve distance spacing toast inline with key binding changes
2022-05-04 11:43:19 +03:00
b325f0ee0b
Combine editor toolbox container implementation and fix input blocking
...
Until now, toolbox scroll areas would block input from arriving behind
them, even when no visible element was clicked.
In addition, clicking on a button inside a toolbox would still send a
`MouseDown` event to things behind it. Specifically, the editor's
`HitObjectComposer` would receive these events and also place objects
when the user does not expect them to be placed.
This fixes another regression that occurred due to `ScrollContainer`s no
longer blocking input theirselves.
2022-05-04 17:41:30 +09:00
3d2072498e
Merge branch 'master' into distance-spacing-osd
2022-05-04 11:41:12 +03:00
a66743266f
Remove unused ScrollingToolboxGroup class
2022-05-04 17:20:58 +09:00
6f52a0b5eb
Merge branch 'master' into distance-spacing-osd
2022-05-04 11:10:18 +03:00
f64a6305af
Merge pull request #18070 from frenzibyte/distance-spacing-keybinding
...
Add keybind for handling distance spacing scrolls in editor
2022-05-04 17:03:06 +09:00
40f1ceca0a
Merge branch 'master' into distance-spacing-keybinding
2022-05-04 16:34:01 +09:00
732739715a
Remove "grid" from strings
2022-05-04 16:31:20 +09:00
504ca5be31
Fix scrolling no longer adjusting distance spacing by amount
2022-05-04 09:52:33 +03:00
1122ee967c
Merge pull request #18085 from peppy/fix-editor-grid-rendering
...
Improve editor grid rendering
2022-05-04 08:23:39 +02:00
a17bbd62b7
Disable EnforceCodeStyleInBuild in Xamarin CI run
2022-05-04 14:06:01 +08:00
813d6fed48
Split activation keybind to separate increase/decrease keybinds
2022-05-04 09:00:54 +03:00
35eeeba4c6
Disable code style analysis on Xamarin projects
2022-05-04 13:57:53 +08:00
