Commit Graph

56221 Commits

Author SHA1 Message Date
5946124278 Merge pull request #19612 from bdach/mod-overlay/common-delete-dialog
Unify implementations of deletion dialogs
2022-08-07 12:18:03 +09:00
b2557a8d2d Refactor KPS
- Remove '#nullable disable' in KeysPerSecondCalculator and
  KeysPerSecondCounter
- Remove KeysPerSecondCalculator IDisposable implementation
- Make KeysPerSecondCalculator static instance initialized once by
  KeysPerSecondCounters
- Auto transfer dependencies from KeysPerSecondCounter to
  KeysPerSecondCalculator using Resolved properties
- Add internal reset logic to KeysPerSecondCalculator and make it
  independent from Player
- Use GameplayClock.TrueGameplayRate to get real-time rate. If 0 then it
  defaults to the last non 0 rate if no such mod is enabled
2022-08-07 00:53:00 +02:00
6f6beddab5 Add test coverage for mod preset deletion flow 2022-08-06 21:58:55 +02:00
9b3183b2b4 Implement mod preset deletion flow 2022-08-06 21:58:55 +02:00
26b9adbe0c Adjust collection deletion test to match new expectations 2022-08-06 21:07:21 +02:00
a0d093be5c Extract common implementation of delete dialog 2022-08-06 21:04:12 +02:00
ca7aa7d21d Merge pull request #19323 from LukynkaCZE/add-missing-icons-to-recent-profile-section
Add missing icons to UserProfileRecentSection
2022-08-07 02:37:43 +09:00
bd43a9e96e Add missing type specification 2022-08-06 18:49:07 +02:00
fa6d55b5b5 Remove redundant lambda signature parentheses 2022-08-06 18:47:11 +02:00
ab1b38242f Reorder enum cases to match web order 2022-08-06 18:34:30 +02:00
6a9c30c47a Fix some more wrong icon colours 2022-08-06 18:34:00 +02:00
2ba127b6fc Fix wrong icon for approval event 2022-08-06 18:30:49 +02:00
f1e0dd2da3 Match approval type-dependent icon appearance with web 2022-08-06 18:29:24 +02:00
f3ecd73e0b Add references to web source in recent activity icon 2022-08-06 18:23:15 +02:00
cc353b872c Add test coverage for other approval events 2022-08-06 18:21:57 +02:00
0d418559bc Skip song intro only in case of a quick restart 2022-08-06 17:02:45 +02:00
e411a2d187 Revert reduced wait time commit 2022-08-06 15:12:36 +02:00
3000d9b9c6 Inline everything in RecentActivityIcon 2022-08-06 07:16:34 +02:00
bd27995c71 Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section 2022-08-06 05:55:51 +02:00
789e8b4d8d Fix multi-spectator test updating state after removing user
Removing user triggers `playingUsers.Remove`, but doing so before
updating the state leads to `EndGameplay` being called with `State ==
Playing` rather than `Quit`.
2022-08-06 05:41:26 +03:00
84ef24c341 Fix multi-spectator potentially getting stuck for passed players 2022-08-06 05:41:26 +03:00
445f921756 Move IsSkippable event into load method 2022-08-05 23:21:03 +02:00
0b886a79f1 Merge branch 'ppy:master' into improve_retry_behaviour 2022-08-05 23:16:35 +02:00
d8d7423698 Reduce "wait time" in case restarting the map 2022-08-05 23:04:43 +02:00
99e07aa09a Skip intro if the map gets restarted 2022-08-05 23:01:52 +02:00
6717f0606c Add property to SkipOverlay 2022-08-05 23:00:37 +02:00
0886137e39 Prevent KeysPerSecondCounter from NRE when no instance is initialized 2022-08-05 21:03:00 +02:00
0c07df2c26 Remove DT from KPS test 2022-08-05 21:02:37 +02:00
e0426836c1 Make swells and drumrolls optional by default 2022-08-05 16:30:07 +02:00
b46bc5d65b Remove empty line 2022-08-05 14:57:33 +01:00
b4e0fa7c53 Rewrite tests for KPS 2022-08-05 15:53:06 +02:00
24c29b7e2f Do not add KPS calculation when gameplay rate is 0 2022-08-05 15:51:07 +02:00
0243f8d6ac Clean up 2022-08-05 14:28:15 +01:00
9ac322d337 Merge pull request #19587 from peppy/adjust-hit-object-pooling
Adjust pooling to reduce stutters during gameplay on unique hit objects
2022-08-05 21:39:41 +09:00
e6761ef6b1 Merge branch 'master' into classic_drumrolls 2022-08-05 12:17:44 +00:00
cf362a6b4f Merge pull request #19529 from peppy/locally-modified-pill
Show "locally modified" pill when local modifications have been made
2022-08-05 21:12:13 +09:00
12ef99a1a1 Fix text position 2022-08-05 12:56:08 +01:00
8618d9ea0d Implement GrowToFitContainer 2022-08-05 12:55:41 +01:00
6afff72865 Fix CI inspections / refactor to single enumeration 2022-08-05 20:54:10 +09:00
15fb4d8dd5 Change Implementation and name of KeepUprightAndUnstretched 2022-08-05 12:53:14 +01:00
802dc90cb1 Adjust using directives for vertices 2022-08-05 20:37:33 +09:00
c4b9b2a14b Merge branch 'master' into irenderer-glwrapper 2022-08-05 20:35:06 +09:00
4544df5978 Leave client.realm around to handle pull requests without this change merged 2022-08-05 18:27:29 +09:00
ad3d00b1dc Don't add version suffixes when running unit tests 2022-08-05 18:23:41 +09:00
a682a823f4 Fix test failures where Beatmap is not provided 2022-08-05 18:20:37 +09:00
9a4d0494de Adjust various pooling defaults to better handle more intense beatmaps 2022-08-05 18:09:07 +09:00
8ae5429602 Adjust slider pooling based on beatmap
Handles edge cases like mentioned in https://github.com/ppy/osu/issues/19585.
2022-08-05 18:08:05 +09:00
3c84b1a389 Change order of application to use original client.realm last 2022-08-05 17:48:51 +09:00
84a3fbd25c Version realm files for debug executions
To make it easier for developers to test out pull requests which bump
the realm schema version, realm files are now stored with the schema
version in the filename.

Note that this means any changes made to a newer version will not be
applied to previous ones.
2022-08-05 17:36:49 +09:00
a81a2517b2 Merge pull request #19583 from peppy/fix-preview-track-disposal
Fix `PreviewTrack`s not being disposed correctly
2022-08-05 15:16:22 +09:00