Commit Graph

56221 Commits

Author SHA1 Message Date
2465e8ed68 Merge pull request #19508 from gutyina70/fix-tags-overflow
Prevent tags overflowing on beatmap info overlay
2022-08-01 13:16:04 +03:00
2a127c6ef8 Merge branch 'master' into fix-tags-overflow 2022-08-01 12:40:43 +03:00
d4eec9122f Merge pull request #19516 from peppy/fix-editor-track-disposal-crash
Fix editor potentially playing a track post-disposal
2022-08-01 18:12:21 +09:00
e0940c6c22 Update animations to final versions 2022-08-01 18:03:32 +09:00
0b8d3cbce9 Merge branch 'master' into stable-slider-tick-anims 2022-08-01 18:03:22 +09:00
225033c3b2 Merge pull request #19517 from peppy/add-more-missing-realm-refreshres
Add more missing realm `Refresh()` calls to new beatmap import tests
2022-08-01 17:54:51 +09:00
14c2348df7 Merge pull request #19514 from peppy/dont-throw-copy-failure-migration
Fix migration failing on single file copy failure
2022-08-01 17:43:05 +09:00
0d9edcfa24 Merge branch 'master' into stable-slider-tick-anims 2022-08-01 17:40:16 +09:00
c65747d1b8 Use masking instead of scrollable container to prevent tags overflow 2022-08-01 10:36:53 +02:00
5f9c3b42e8 Merge pull request #19513 from peppy/isolate-development-storage
Isolate development builds' storage from release builds
2022-08-01 17:30:25 +09:00
1d27c4f020 Merge pull request #19504 from peppy/skin-serialisation-test-coverfage
Add test coverage of deserialisation of skin layouts
2022-08-01 17:17:16 +09:00
e0aaacc419 Merge pull request #19467 from frenzibyte/taiko-samples-priority
Allow osu!taiko hitsounds to fall back to classic skin rather than use non-taiko samples
2022-08-01 17:10:50 +09:00
ee68113913 Add more missing realm Refresh() calls to new beatmap import tests
As noticed at https://github.com/ppy/osu/runs/7605101313?check_suite_focus=true
2022-08-01 17:06:46 +09:00
cc8a71b65d Re-query file existence before failing a recursive copy operation during migration 2022-08-01 17:01:19 +09:00
59210ecc9d Revert "Fix migration failing on single file copy failure"
This reverts commit fc8835d43a.
2022-08-01 16:57:50 +09:00
6e7c298aaf Fix changes to audio / background not triggering an editor state change 2022-08-01 16:53:49 +09:00
2f60f91a0e Fix editor potentially using a track post-disposal
This changes the editor to track the current track as it is *loaded* by
`MusicController`, rather than haphazardly following the current global
`WorkingBeatmap` (with a potentially unloaded track) or relying on local
immediate-load behaviour (as implemented in `ResourcesSection`).
2022-08-01 16:53:49 +09:00
2519706ad6 Add test coverage of editor crash 2022-08-01 16:53:49 +09:00
47860bb966 Remove unused using 2022-08-01 16:33:59 +09:00
fc8835d43a Fix migration failing on single file copy failure
No longer throw if copying of single files fails during data migration.

Aiming to fix https://github.com/ppy/osu/runs/7601653833?check_suite_focus=true, which could also affect end users. I've left a limit before an exception is still thrown, to handle cases like the user running out of disk space (where we probably *do* want to bail, so they can continue to use their still-intact original storage location).

If this isn't seen as a good direction, an alternative will be to make the migration code aware of the structure of the temporary files created by `Storage` (but doesn't guarantee this will cover all cases of such temporary files – there could for isntance be metadata files created by the host operating system).

Another option would be to mark those temporary files as hidden and skip any hidden files during iteration.
2022-08-01 15:02:39 +09:00
5335d60748 Merge pull request #19407 from andy840119/remove-nullable-disable-in-the-mods-for-osu-ruleset
Remove nullable disable annotation in mods for osu ruleset.
2022-08-01 14:51:48 +09:00
8ee4f1e60b Merge pull request #19510 from bdach/mod-overlay/presets-persistence
Add persistence of mod presets to realm
2022-08-01 14:43:52 +09:00
a5f48e336a Isolate development builds' storage from release builds 2022-08-01 14:38:02 +09:00
3b6349a145 Add test coverage of remaining components which weren't already included 2022-08-01 14:16:26 +09:00
d112743cea Improve test coverage of skin serialisation to ensure full coverage
Will fail when new skinnable components are added until they have
coverage in resources.
2022-08-01 14:04:12 +09:00
5b98a73edc Apply nullability to SkinComponentToolbox and split out reflection method to get all skinnable components 2022-08-01 14:04:08 +09:00
415d6def2d Remove unnecessary AsNonNull() 2022-08-01 13:22:58 +09:00
195396309a Merge pull request #19507 from naipofo/playlist-capture-fix
Prevent capturing arrow keys on playlist creation.
2022-08-01 11:46:00 +09:00
85f77abee1 Fix code quality inspection about ambiguous equality 2022-07-31 23:53:46 +02:00
5a34122a85 Fix test breakage after realm migration 2022-07-31 23:53:46 +02:00
9d3cdae4bb Fix test scene to handle restarts properly 2022-07-31 23:53:46 +02:00
9dea8e3d12 Add test coverage of preset soft deletion 2022-07-31 23:53:46 +02:00
c837848238 Add extended test coverage of preset realm subscription 2022-07-31 23:53:45 +02:00
345f103119 Migrate mod preset column to use realm 2022-07-31 23:53:45 +02:00
fa3b9ee32f remove unneded guard 2022-07-31 23:42:20 +02:00
cbabc4886c Convert ModPreset to realm object 2022-07-31 22:10:15 +02:00
98214beb6c Prevent overflow on beatmap info using scrollable container 2022-07-31 21:24:41 +02:00
57b43e0065 Stop capturing arrow keys on Playlist 2022-07-31 19:12:29 +02:00
f9f9b65c86 Add test coverage of deserialisation skin layouts 2022-08-01 01:14:05 +09:00
db4c6aa3d3 Add test skin layout json resources 2022-08-01 01:13:47 +09:00
5dd641bc60 Remove the nullable disable annotation in the test project. 2022-07-31 22:02:07 +08:00
094793bbe3 Mark the GetTrack() return type as nullable. 2022-07-31 22:01:30 +08:00
6c964dee30 Rename the nullable disable annotation in the Audio namespace and mark some properties as nullable. 2022-07-31 22:00:14 +08:00
632577389d Mark the property as non-nullable. 2022-07-31 21:43:16 +08:00
89855cc1d6 Change KPS Counter implementation base and add better replay integration
The counter implementaiton is now list based, and will not invalidate
previous hits by removing them but by testing if they are within the 1
second span, allowing better integration with replays and spectators.
2022-07-31 01:29:57 +02:00
998e3b74d6 Merge pull request #19481 from peppy/fix-skin-migration
Fix previous skins not loading due to namespace changes
2022-07-30 21:56:28 +03:00
93b783d9ea Fix previous skins not loading due to namespace changes 2022-07-31 03:25:38 +09:00
faefda9143 Fix song select not updating selected beatmap card on editor resume 2022-07-30 19:47:42 +03:00
498c796c81 Merge pull request #19478 from peppy/fix-collection-migration
Fix collection migration potentially deleting the database before finishing migration
2022-07-30 19:44:22 +03:00
6ad86ce5b7 Run collection import process asynchronously
Actually required to avoid deadlocking..
2022-07-31 01:06:57 +09:00