Commit Graph

14601 Commits

Author SHA1 Message Date
194e501f86 Merge branch 'master' into snapping-refactor 2019-10-26 14:20:08 +09:00
c2f6cd9c24 Merge branch 'master' into comments-vote-pill 2019-10-25 19:19:44 +09:00
c9505f89dd Merge branch 'master' into markdown-inline-links 2019-10-25 18:52:11 +09:00
3692846367 Merge branch 'master' into snapping-refactor 2019-10-25 18:26:14 +09:00
ae011e8ee8 Fix distance snap grid test scenes 2019-10-25 17:25:46 +09:00
4ca6a5a0cc Interface the distance snap provider 2019-10-25 16:50:21 +09:00
607b4d874a Refactor flow of snapping through HitObjectComposer 2019-10-25 16:40:30 +09:00
e5b5d286fd Increase spacing to closer match the design 2019-10-25 12:48:34 +09:00
07f7944fc6 Fix DateTime display sizing on results screen 2019-10-25 12:22:19 +09:00
661dfbefaf Change containment check to overlap
Due to scenarios wherein a formatted link ended up as part of a larger
raw link after parsing, change the containment check to an overlap check
and add appropriate tests for these edge cases.
2019-10-25 00:42:58 +02:00
85769982a0 Refactor LoadingButton 2019-10-24 17:49:34 +03:00
4f79ac8095 Merge remote-tracking branch 'refs/remotes/ppy/master' into comments-vote-pill 2019-10-24 17:38:50 +03:00
0b3c7f28af Merge branch 'master' into fix-dragbox-first-frame 2019-10-24 23:01:32 +09:00
fa3350ce2d Refactor blueprint movement and selection events (#6588)
Refactor blueprint movement and selection events
2019-10-24 22:58:03 +09:00
cbd99cc767 Resolve link-in-link edge case
Testing with #6542 surfaced a crash scenario, caused by formatted links
that had URLs in the display text, for example

    [mean example - https://osu.ppy.sh](https://osu.ppy.sh)

In that case the outer Markdown link would get picked up once, and then
reduced to the link text when looking for other links, leading to it
being picked up again the second time when the raw link is found.

Add a check in the raw link parsing path that ensures that the found
URL is not a part of a bigger, pre-existing link.
2019-10-24 15:52:55 +02:00
24b7160522 Add support for parsing Markdown inline links
Extend the Markdown parsing regex to allow parsing so-called inline
links. Within the parenthesis () part of the Markdown URL syntax,
introduce a new capturing group:

    (
      \s+              // whitespace between actual URL and inline title
      (?<title>        // start of "title" named group
        ""             // opening double quote (doubled inside @ string)
        (
          [^""]        // any character but a double quote
          |            // or
          (?<=\\)      // the next character should be preceded by a \
          ""           // a double quote
        )*             // zero or more times
        ""             // closing double quote
      )
    )?                 // the whole group is optional

This allows for parsing the inline links as-provided by web. Correctness
is displayed by the passing tests.
2019-10-24 15:52:55 +02:00
a969914d6e Mention coordinate space 2019-10-24 18:24:22 +09:00
d83b9ef0e4 Rename grid snapping methods 2019-10-24 18:18:04 +09:00
f45f17339c Implement slider path distance snapping 2019-10-24 18:17:30 +09:00
7a71352684 Fix drag box being positioned incorrectly for 1 frame 2019-10-24 17:22:14 +09:00
fb88001c0e Reorder blueprint addition/removal + add regions 2019-10-24 16:53:34 +09:00
45bd91f63f Add special cases for click-selection 2019-10-24 16:14:29 +09:00
8e4a21bee7 Separate out mouse down/click/up handling 2019-10-24 15:58:22 +09:00
a07e5a269b Extract drag events into multiple methods 2019-10-24 15:33:08 +09:00
f128e99fb2 Remove unused methods 2019-10-24 15:07:04 +09:00
e04c77178c Move selection events to BlueprintContainer 2019-10-24 14:58:02 +09:00
714c89faa4 Move selection drag events to BlueprintContainer 2019-10-24 14:57:58 +09:00
b310fd9d44 Adjust naming inside the LoadingButton 2019-10-23 13:39:42 +03:00
a6d5a2024a Merge remote-tracking branch 'refs/remotes/ppy/master' into comments-vote-pill 2019-10-23 13:27:45 +03:00
cef2318cf5 Move drag box drag handling to BlueprintContainer 2019-10-23 18:38:06 +09:00
fa9690d16c Merge pull request #6582 from smoogipoo/grid-centre
Show centre point of distance snap grid
2019-10-23 18:28:05 +09:00
f61d7e4fbe Add smoothing and tidy code a touch 2019-10-23 17:56:09 +09:00
c03fa01fd9 Remove unnecessary set 2019-10-23 17:51:16 +09:00
2c9b11cdfd Move variable outside of if block 2019-10-23 17:49:21 +09:00
c9fec50f63 Remove unnecessary whitespace 2019-10-23 17:00:17 +09:00
97383b4a37 Show centre point of distance snap grid 2019-10-23 16:58:56 +09:00
64682611bb Fix distance snapping grid not updating on scroll 2019-10-23 16:39:14 +09:00
40c202c394 Merge branch 'master' into comments-vote-pill 2019-10-23 15:41:54 +09:00
e836364add Update framework 2019-10-23 15:13:52 +09:00
21e0bd2a5a Merge branch 'fix-wave-container' into apply-framework-fixes 2019-10-23 15:13:41 +09:00
851773a842 Apply adjustments for framework changes 2019-10-23 14:04:06 +09:00
7b7a87afa8 Put back mobile conditional 2019-10-22 19:51:29 -07:00
8154cc1b16 Fix registration textboxes always focusing after pressing escape 2019-10-22 14:40:56 -07:00
c3375071ad Fix formatting issue 2019-10-23 00:26:47 +09:00
e9aa7f3218 Subclass and use yellow for stand-alone chat display 2019-10-23 00:24:19 +09:00
3b4823abe7 Use foreach 2019-10-23 00:17:37 +09:00
0ba287a7fd Rename variable 2019-10-23 00:14:22 +09:00
7084aa7b81 Merge branch 'master' into chat-day-separator 2019-10-22 15:48:42 +09:00
001eae2c02 Merge remote-tracking branch 'upstream/master' into make-most-textbox-carets-movable 2019-10-22 15:04:16 +09:00
5d0d83b6bf Add basic xmldoc 2019-10-22 15:04:10 +09:00