2dcaf7cfd8
Fix memory leak due to missing event unbind
2022-09-18 14:25:31 +09:00
c075d3de08
Create a test and a check if initial zoom value of ZoomableScrollContainer is in range
2022-09-17 22:43:40 +02:00
9d94343317
Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com >
2022-09-17 19:51:44 +02:00
c8768eb399
Changed == to <= on TimelineZoom check
2022-09-17 19:00:50 +02:00
3c7ea5c8fa
Update
2022-09-17 18:57:09 +02:00
41e69fbca6
Remove "default" prefix from naming
2022-09-18 00:15:26 +09:00
51841988bf
Rename references to DefaultSkin to have Triangles suffix
2022-09-17 23:57:25 +09:00
2dfa89c62e
Clean up
2022-09-17 15:05:25 +01:00
0b6a77bc8b
EditorBeatmap's TimelineZoom should never be zero
2022-09-17 15:59:42 +02:00
d580b07063
Refactor update condition logic
2022-09-17 14:40:36 +01:00
e3d5ba5301
Check if graph DrawSize changed
2022-09-17 11:44:25 +01:00
0d76f4501d
Revert "Set InvalidationSource to Self"
...
This reverts commit 2092008251
2022-09-17 10:10:20 +01:00
4c4fdfd153
Provide scores directly to Player instance rather than relying on DI
2022-09-16 18:15:17 +09:00
0227eddda1
Merge branch 'master' into gameplay-leaderboards
2022-09-16 15:44:58 +09:00
d9499abc33
Refactor to avoid passing around bindables
2022-09-16 13:14:25 +09:00
4f208416be
Fixed irresponsiveness of score panel timestamp to time format
2022-09-16 13:50:18 +14:00
2092008251
Set InvalidationSource to Self
2022-09-15 11:16:00 +01:00
8286ab0d04
Revert "Fix SongProgress invalidating too often"
...
This reverts commit 2b4b14ca99
2022-09-15 11:11:58 +01:00
40a60f7145
Remove all entity framework code and migrations
2022-09-15 16:58:58 +09:00
eb18d3661d
Merge pull request #20309 from mk56-spn/dead_class_removal
...
Unused class KeyCounterState.cs Removal
2022-09-15 03:38:39 +09:00
d6db82283a
Removes unused class
2022-09-14 18:01:29 +02:00
fcf54f1bc8
Fix gameplay leaderboard not being sorted correctly in tie situations
2022-09-14 14:18:12 +09:00
8a6977213a
Fix displayed scores in gameplay leaderboard not tracking display mode changes
2022-09-14 14:02:35 +09:00
b4e6a20846
Fix song select status prefix matching no longer working
...
Regressed in #19275 due to weird logic.
Closes #20289 .
2022-09-14 12:59:05 +09:00
81b5e4a865
Fix back-to-front condition on leaderboard always show configuration
2022-09-13 19:57:40 +09:00
94693a4667
Fix oversight when making interface implementation explicit
2022-09-13 19:55:57 +09:00
e15a25ea49
Fix leaderboard positioning logic to actually consider elements on the left side
2022-09-13 18:45:11 +09:00
678eec1c67
Move LeaderboardFlow to HUDOverlay to share positioning logic
2022-09-13 18:45:11 +09:00
5894d2f0bc
Ensure gameplay leaderboard hides with rest of HUD when it should
2022-09-13 18:45:11 +09:00
6d167070f8
Add back DI leaderboard retrieval via bindable pathway
2022-09-13 18:45:11 +09:00
70e6b595f1
Refactor SoloGameplayLeaderboard to not read scores via DI
...
Also allows updating scores if they arrive late.
2022-09-13 18:00:21 +09:00
d2b80645ab
Change Leaderboard to use IUser instead of APIUser
2022-09-13 18:00:21 +09:00
d251c0b2ac
Move leaderboard implementation to Player itself
2022-09-13 18:00:21 +09:00
368faa0084
Make constructor protected in base implementation
2022-09-13 18:00:21 +09:00
4c669e2bce
Track local Player.Score's user rather than using APIProvider
2022-09-13 18:00:21 +09:00
3490b16056
Add simplified SoloGameplayLeaderboard implementation
...
Note that this doesn't support waiting until leaderboard finishes fetching scores.
2022-09-13 18:00:21 +09:00
27a81dfb9f
Merge pull request #20270 from OliBomby/fix-selectionblueprint-order
...
Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes
2022-09-13 17:18:58 +09:00
0e2155303e
Merge branch 'master' into fix-song-progress-invalidations
2022-09-13 16:07:05 +09:00
f53507828c
Rename event to be more generic (and add comprehensive xmldoc)
2022-09-13 14:59:30 +09:00
ac034bffeb
Fix potential crash if multiplayer spectator load is aborted early
2022-09-13 14:21:54 +09:00
fd48249eef
fix with new event
2022-09-13 02:20:52 +02:00
718f8c4ee2
revert the fix
2022-09-13 01:09:42 +02:00
8400de4b2e
invoking hitobject updated before invoking removed
2022-09-12 17:50:11 +02:00
2b4b14ca99
Fix SongProgress invalidating too often
...
This regressed with https://github.com/ppy/osu/pull/19556 . Rather than
try and figure whether that new container needs to handle size
differently, this is a simple solution.
Height was taken from a runtime check (maxes out at about 14.5).
Closes #20235 .
2022-09-12 20:06:53 +09:00
cb6d02ec3a
Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset
...
Remove the nullable disable annotation in the ruleset class
2022-09-12 19:07:23 +09:00
4b37330316
Merge pull request #20248 from acid-chicken/fix/stats/td
...
Fix new hit distribution graph didn't account for size changes
2022-09-12 18:11:18 +09:00
3cfacb5e39
Merge pull request #20257 from peppy/update-button-show-login
...
Show login overlay when attempting to update a beatmap while logged out
2022-09-12 17:51:45 +09:00
4f298db066
fix(osu.Game): reset Y axis of the bars in hit distribution graph at the first drawing
2022-09-12 16:25:29 +09:00
0d0e2e7bcc
fix(osu.Game): bars in hit distribution graph stretching in the opposite direction when DrawHeight is less than DrawWidth
2022-09-12 16:20:33 +09:00
31225066a1
Merge pull request #19308 from frenzibyte/top-rank-badge-order
...
Fix best rank badge not handling legacy scores properly
2022-09-12 16:20:21 +09:00
