15feb17da8
Change difficulty cache storage type to nullable
...
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.
To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
2021-11-20 17:00:50 +01:00
51a353e12d
Rename BeatmapInfo.Version to DifficultyName to match underlying interface
2021-11-11 17:20:53 +09:00
86540d1fb6
Update existing usages of Author as string to access Username directly
2021-11-04 18:57:54 +09:00
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
853cf6feaa
Rename last remaining BeatmapInfo Beatmap usage
2021-10-04 17:35:53 +09:00
d4399f10f9
Merge both variants of the star rating display
2021-08-04 18:19:28 +03:00
8e1f8c28bd
Use default value to denote no play date, rather than null
2021-07-20 19:05:08 +09:00
662822a40c
Avoid showing time of play on results screen when autoplay
...
Closes https://github.com/ppy/osu/issues/13940 .
2021-07-20 15:19:44 +09:00
e1c646b9b2
Remove redundant arguments
2021-07-05 23:52:39 +08:00
4a4a561ca4
Merge pull request #13330 from nekodex/results-screen-sfx
...
Add sound effects to the results screen
2021-06-10 18:27:17 +09:00
7774344f0e
Remove "Unranked" text from ModDisplay
2021-06-09 13:45:09 +09:00
9ad87ee5dc
add sfx for results screen + sound design tool
2021-06-03 18:34:22 +09:00
d05ffdf120
Added constants for delay value
2021-05-18 20:19:18 +02:00
e82eaffaed
Flip order back to original for romanisable strings
2021-02-25 14:14:07 +09:00
8a97e2e28d
Update LocalisedString usages to RomanisedString
2021-02-22 19:01:42 +09:00
1fd76ea3fb
Apply changes to UI components overriding functions with changing signatures
2021-02-22 19:01:42 +09:00
c5b172d0dd
Remove synchronous lookup path from BeatmapDifficultyCache
2020-11-06 14:53:15 +09:00
5113d4af8f
Rename BeatmapDifficultyManager to BeatmapDifficultyCache
2020-11-06 13:14:29 +09:00
73b290aca3
Merge branch 'master' into results-dynamic-pp-calc
2020-11-02 14:47:33 +09:00
6a293dd536
Add missing ctor parameters back
2020-10-31 18:56:30 +09:00
0c1d12460f
Remove unused parameter
2020-10-30 10:30:11 +09:00
0a0239a7c7
Only play results panel animation once (and only for the local user)
2020-10-29 17:08:59 +09:00
71e373ff51
Make results panels aware of whether they are a local score that has just been set
2020-10-29 17:08:59 +09:00
9141f48b04
Remove beatmap-based ctor to promote single flow
2020-10-23 14:57:27 +09:00
ba818e3ae0
Merge branch 'master' into results-dynamic-pp-calc
2020-10-19 21:41:07 +02:00
7f5cf04b2b
Fix merge conflicts.
2020-10-07 13:28:49 +02:00
67398b5d95
Move timestamp text out of flow and attach to bottom edge
2020-10-07 16:30:14 +09:00
c0bc6a75b3
Show auxiliary judgements on next line
2020-10-07 16:17:17 +09:00
e281d724b8
Consume display name logic
2020-10-07 15:43:52 +09:00
77a9d92f42
Add dynamic pp calculation to score panels for local scores
2020-09-25 19:15:40 +02:00
a07597c369
Adjust displays to use new results/orderings
2020-09-25 20:22:59 +09:00
37a659b2af
Refactor/add xmldocs
2020-09-09 17:36:47 +09:00
c1838902a6
Add to more places
2020-08-28 22:51:48 +09:00
7b012f1def
Fix test failures
2020-06-11 14:55:49 +09:00
05b1edb9d8
Fix incorrect beatmap showing
2020-06-09 19:01:02 +09:00
5d7bb8cb4e
Change format of date on score panel
2020-06-04 21:33:38 +09:00
700214d249
Truncate beatmap title and artist on score panel
2020-04-30 22:13:38 -07:00
88cc552534
Fix results star rating display not being centered when no mods are present
...
Needed or the spacing will apply to the fill flow container, causing alignment issues.
2020-04-03 11:30:22 -07:00
493b654011
Remove horizontal margin from mod display
...
Can skew center alignment on fill flow containers.
Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.
2020-04-03 11:30:02 -07:00
25983cfe0e
Merge pull request #8340 from smoogipoo/results-date-played
...
Add date played to score panel
2020-03-18 18:55:26 +09:00
6c45694f01
Merge pull request #8338 from smoogipoo/colourise-hit-statistics
...
Colourise results screen hit statistics
2020-03-18 18:55:10 +09:00
63531a8564
Add date played to score panel
2020-03-18 17:59:44 +09:00
66558ca8c5
Colourise hit result statistics
2020-03-18 17:26:17 +09:00
fdcb60706b
Use TryGetValue to make tests happy
2020-03-18 15:49:24 +09:00
44cfed8af1
Fix perfect display showing when misses are present
2020-03-18 15:03:01 +09:00
27f7808a86
Merge pull request #8320 from recapitalverb/fix-mapper-alignment
...
Fix mapper info alignment in score panel
2020-03-18 10:59:05 +09:00
3c07f73c7b
Fix results' beatmap title and artist language setting being swapped
2020-03-17 17:32:58 -07:00
139ae2bc1e
Use existing variables instead
2020-03-18 01:24:58 +07:00
431571dfa0
Check nulls
2020-03-18 00:15:43 +07:00
d18b21ba32
Use local variable for metadata instead
2020-03-17 23:23:51 +07:00
