Commit Graph

24604 Commits

Author SHA1 Message Date
048677846b Change HealthDisplay to be a CompositeDrawable 2021-05-11 23:10:30 +09:00
7d9cdd3bc2 Merge branch 'master' into skin-components-list 2021-05-11 17:27:48 +09:00
4bee8c23f0 Fix idle tracker not accounting global actions 2021-05-10 21:40:29 -07:00
0f00ee8640 Change failure text
Although this is not visible anywhere.
2021-05-11 11:35:08 +09:00
8c9390dc75 Remove replay condition 2021-05-11 11:33:21 +09:00
6db9e26d48 Fix score submission failures with autoplay 2021-05-11 11:28:09 +09:00
32f7691349 Fix token failure preventing base.LoadAsyncComplete() 2021-05-11 11:24:35 +09:00
f5aff780ca Merge branch 'master' into text-flow-md 2021-05-10 22:34:20 +02:00
f1aa47f6df Update framework 2021-05-10 23:15:38 +09:00
6bb52ebcf8 Merge pull request #12570 from frenzibyte/corner-rotation-controls
Add rotation controls to editor selection box corners
2021-05-10 23:09:44 +09:00
1492ad750a Merge pull request #12735 from smoogipoo/fix-toolbar-queuing-sounds
Fix toolbar queuing ruleset sounds
2021-05-10 23:05:49 +09:00
bca5bee72e remove duplicate CreateSpriteText in OsuMarkdownTextFlowContainer 2021-05-10 19:28:32 +07:00
e7355da201 Merge branch 'master' into osu-markdown 2021-05-10 20:02:04 +09:00
1b701adfef Add score/health processors to fill in default values 2021-05-10 18:15:39 +09:00
2ecd638f7f Merge branch 'master' into skin-components-list 2021-05-10 18:13:10 +09:00
fa872858b5 Remove unnecessary check 2021-05-10 16:40:06 +09:00
97e72849af Fix regressed HitErrorDisplay behaviour (and localise binding to meter implementations) 2021-05-10 15:24:13 +09:00
78952c07b0 Merge branch 'master' into remove-hud-overlay-unused-pieces 2021-05-10 14:39:32 +09:00
5a6c7c30e0 Merge pull request #12707 from peppy/skin-components-bind-outwards-health
Update `HealthDisplay` components to use DI to attach data source
2021-05-10 14:39:17 +09:00
332cb74cad Fix toolbar queuing ruleset sounds 2021-05-10 13:58:13 +09:00
149f2bcc1c Merge pull request #12701 from ekrctb/framed-auto-generator
Factor out common logic of frame-based replay `AutoGenerator`
2021-05-10 13:43:53 +09:00
35a7226cd8 Add newline 2021-05-10 13:41:04 +09:00
3c3500d070 Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces 2021-05-10 12:23:18 +09:00
1bbbe80420 Fix missing instances of HealthProcessor caching 2021-05-10 12:22:24 +09:00
b274fdf20d Merge branch 'master' into skin-components-bind-outwards-health 2021-05-10 11:13:44 +09:00
002622a92c Merge pull request #12732 from Joehuu/ss-sort-by-source
Add ability to sort by source in song select
2021-05-10 10:10:56 +09:00
ab6239fd5f change math for displaying volume "MAX" 2021-05-10 00:51:58 +02:00
a71e52da4c Fix enum ordering after adding source 2021-05-09 15:39:59 -07:00
a21718f1cd Move source case to a better spot 2021-05-09 14:26:45 -07:00
8964d51de9 Add ability to sort by source in song select 2021-05-09 14:10:38 -07:00
2bcf1ed306 Merge pull request #12715 from Cublibre/fix-early-exit-crash
Fix InvalidOperationException when exiting a map at the end
2021-05-09 23:21:19 +09:00
eb716455b7 Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-09 12:13:18 +02:00
dde9fd28e6 Hide ShowMore button if there's nothing to load 2021-05-09 04:57:24 +03:00
0e91e6a155 Merge pull request #12724 from bdach/remove-current-from-legacyscorecounter
Remove vestigial `Current` reimplementation from `LegacyScoreCounter`
2021-05-09 05:01:53 +09:00
ea066cddc9 Merge pull request #12722 from bdach/fix-beatmap-listing-temporary-files
Fix temporary files from beatmap downloads not being cleaned up
2021-05-09 04:51:48 +09:00
67cea6e762 Remove explicit binding to accuracy counter from overlay 2021-05-08 21:38:06 +02:00
0bc6a026eb Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-08 21:08:53 +02:00
c3bf6a0287 Remove weird vestigial Current reimplementation
Has no functional purpose anymore since the changes in the HUD element
data binding flow.
2021-05-08 21:01:37 +02:00
dec5400c0a Merge branch 'master' into skin-components-bind-outwards-score-display 2021-05-08 19:58:19 +02:00
9e0ea494fd Merge branch 'master' into skin-components-bind-outwards 2021-05-08 19:04:56 +02:00
25312b3e88 Don't restart completion delegate on exit, revert exit behavior to lazer 2021-05-08 11:47:44 -04:00
fe86ee629e Fix temp files from beatmap listing imports not being cleaned up
As reported in #12718, it turns out that temporary files from beatmap
set downloads performed via the beatmap listing overlay could remain in
the user's filesystem even after the download has concluded.

The reason for the issue is a failure in component integration.
In the case of online downloads, files are first downloaded to a
temporary directory (`C:/Temp` or `/tmp`), with a randomly generated
filename, which ends in an extension of `.tmp`.

On the other side, `ArchiveModelManager`s have a `ShouldDeleteArchive()`
method, which determines whether a file should be deleted after
importing. At the time of writing, in the case of beatmap imports the
file is only automatically cleaned up if the extension of the file is
equal to `.osz`, which was not the case for temporary files.

As it turns out, `APIDownloadRequest` has a facility for adjusting the
file's extension, via the protected `FileExtension` property. Therefore,
use it in the case of `DownloadBeatmapSetRequest` to specify `.osz`,
which then will make sure that the `ShouldDeleteArchive()` check in
`BeatmapManager` picks it up for clean-up.
2021-05-08 17:09:14 +02:00
8c564a69ed Fix InvalidOperationException when exiting a map at the end 2021-05-07 21:11:03 -04:00
495eb04e2f Merge pull request #12488 from Denrage/add-missing-author-links
Add missing author links in Beatmap Details
2021-05-08 05:41:40 +09:00
5b2f786f97 Update framework 2021-05-07 19:16:00 +09:00
a1aeac5677 Remove remaining cruft from SkinnableAccuracyCounter 2021-05-07 18:12:18 +09:00
68de870986 Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces 2021-05-07 18:11:14 +09:00
9fe6e1096a Remove cruft from SkinnableHealthDisplay 2021-05-07 18:11:08 +09:00
111b501ced Revert accidental removal of UTF-8 BOM 2021-05-07 18:04:38 +09:00
1cb10c2a22 Remove unnecessary binding logic from HUDOverlay 2021-05-07 17:51:46 +09:00