Commit Graph

8917 Commits

Author SHA1 Message Date
75d0deef72 Apply proposed changes to remove inheritance from MasterGameplayClockContainer 2022-09-07 17:49:05 +09:00
bc1212f4e6 Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method 2022-09-06 22:26:46 +09:00
a70fc10d06 Fix mock track construction failure 2022-09-02 16:30:04 +09:00
6a35b233e5 Merge branch 'master' into remove-dispose-updates 2022-09-01 23:03:19 +09:00
148e487c02 Add failing test of date submitted search failing 2022-09-01 19:59:27 +09:00
ba20044af4 Fix missing nullability consideraition 2022-08-31 23:24:39 +09:00
837b19ab24 Merge pull request #19919 from khang06/nan-sv
Emulate osu!stable's NaN slider velocity behavior
2022-08-31 19:06:49 +09:00
6cadcc206b Merge pull request #20032 from peppy/toast-notification-tray
Add toast notification tray
2022-08-31 16:57:37 +09:00
000412c50f Merge pull request #20014 from peppy/fix-resume-skip-forward
Fix gameplay skipping forward during resume operation
2022-08-31 16:30:37 +09:00
afe2862df4 Merge branch 'master' into toast-notification-tray 2022-08-31 16:07:11 +09:00
e984dc4a19 Merge pull request #20042 from peppy/fix-composer-test-scenes
Test editor `ComposeScreen` tests not adding beatmap to hierarchy
2022-08-31 15:59:48 +09:00
e9463f3c19 Test editor ComposeScreen tests not adding beatmap to hierarchy
Makes it hard to test anything because `EditorBeatmap`'s `Update` method
updates whether a beatmap has timing or not (enabling the placement
controls).

Also adds a basic timing point to allow for better testing.
2022-08-31 14:07:56 +09:00
7ce1cf7560 Add test coverage of skip button failure with equal time 2022-08-31 13:22:51 +09:00
c573396ab6 Fix IntroTestScene not clearing previous notifications hard enough 2022-08-31 12:46:54 +09:00
3d93e0ded1 Merge branch 'master' into fix-resume-skip-forward 2022-08-31 12:16:15 +09:00
9eb615f942 Fix remaining test failures by strengthening PlayerLoader tests
- Click using `TriggerClick` as notifications move around quite a bit.
- Ensure any notifications from a previous test method are cleaned up.
2022-08-31 01:40:30 +09:00
31a9980686 Update remaining test expectations with new behaviour 2022-08-31 00:57:30 +09:00
a62ba9e0d9 Remove notification blocking behaviour of first run setup 2022-08-31 00:57:18 +09:00
b8fda1a16f Apply NRT to notification classes
and tidy things up a bit.
2022-08-30 15:57:10 +09:00
8b3742188f Fix test by also clearing out maximum statistics 2022-08-30 15:42:36 +09:00
5202c15a0e Populate MaximumStatistics for test scores 2022-08-30 15:11:39 +09:00
062a6fcc18 Fix failing large offset test
If we are going to continue to let the underlying clock process frames,
there needs to be a bit of lenience to allow the backwards seek on
resume (to play back over the freq ramp period).

The test is meant to be ensuring we don't skip the full offset amount,
so div10 seems pretty safe.
2022-08-30 01:21:55 +09:00
0491addbbd Merge pull request #19974 from peppy/no-gameplay-clock-editor-offset
Fix editor not applying offsets
2022-08-29 21:10:29 +09:00
82b9e1f0eb Merge pull request #20011 from smoogipoo/scoring-refactor
Refactor scoring to remove async methods / simplify
2022-08-29 19:55:27 +09:00
ad5ef52922 Add test coverage of resuming after pause not skipping forward in time 2022-08-29 19:02:01 +09:00
e3e204001e Merge pull request #19907 from peppy/ruleset-api-versioning
Add ruleset API versioning
2022-08-29 18:50:01 +09:00
f2378d3fde Merge branch 'master' into carousel-maintain-selection-over-update 2022-08-29 11:23:22 +03:00
9b830d063f Merge pull request #20010 from smoogipoo/scoreprocessor-no-rewrite-statistics
Don't include misses in failed score statistics
2022-08-29 17:07:13 +09:00
2dafa041a7 Account for offset being applied to editor clock time in TestSceneEditorClock 2022-08-29 16:42:50 +09:00
d4a37725c4 Adjust test 2022-08-29 15:59:57 +09:00
a215d009fe Update Remove/RemoveRange/RemoveAll calls in line with framework changes 2022-08-29 15:57:40 +09:00
423f6f90f2 Remove async calls from ScoreManager 2022-08-29 15:34:08 +09:00
e8ae6840ea Add test coverage of selection being retained 2022-08-29 15:23:34 +09:00
892f43da43 Add test coverage of ruleset being marked unavailable if methods are throwing 2022-08-29 14:28:55 +09:00
5ff4e6a4fe Add test coverage for outdated ruleset 2022-08-29 14:26:12 +09:00
c0b13c7e1f Refactor ScoreProcessor ComputeScore() methods 2022-08-29 13:51:10 +09:00
289b6f1a58 Merge pull request #19924 from peppy/fix-playlist-overlay-test-failures
Fix intermittent test failures in `TestScenePlaylistOverlay`
2022-08-26 23:36:16 +09:00
1fd1672d89 Merge branch 'master' into mod-validation-tests 2022-08-26 15:00:07 +03:00
6dc859973b Merge branch 'master' into fix-playlist-overlay-test-failures 2022-08-26 20:25:53 +09:00
90ff0864c0 Merge branch 'master' into no-gameplay-clock-editor-offset 2022-08-26 20:25:21 +09:00
91e044542d Merge pull request #19828 from peppy/no-gameplay-clock-gameplay-offset
Introduce `FramedBeatmapClock` (and use in gameplay flow)
2022-08-26 20:21:34 +09:00
5ef8e26ebe Fix check not accounting for mods not existing in certain rulesets
Also check all instances, rather than first.
2022-08-26 19:59:26 +09:00
580754833f Merge branch 'master' into mod-validation-tests 2022-08-26 19:48:42 +09:00
9c9238d6e8 Fix TimelineTestScene's beatmap getting overwritten by EditorClockTestScene 2022-08-26 18:38:52 +09:00
4b72e55770 Fix various test scenes not adding EditorClock to the draw hierarchy 2022-08-26 18:08:43 +09:00
9050f54681 Split out test assertion methods to read better 2022-08-26 16:56:03 +09:00
a8c699610a Fix lead in tests not waiting for player to start running
The tests are only meant to ensure that gameplay eventually starts.

The case where failures can occur is where the master clock is behind
the player clock (due to being in lead-in time). Because the test is
running in real-time, it can take arbitrary amounts of time to catch up.

If it took too long, the test would fail.
2022-08-25 18:00:14 +09:00
ddb434f47a Rename asserts to method names to make it easier to track in logs 2022-08-25 17:30:13 +09:00
a5c61d9a52 Improve understandability of TestMostInSyncUserIsAudioSource 2022-08-25 16:47:33 +09:00
3a17c6df08 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-25 16:24:55 +09:00