35841fa4f7
Merge branch 'master' into fix-difficulty-bindable-bind-order
2021-07-13 13:42:53 +09:00
5cff379cd9
Merge pull request #13860 from smoogipoo/fix-bindable-ctor
...
Fix DifficultyBindable not binding correctly and not having default ctor
2021-07-13 13:42:44 +09:00
5af2190246
Merge branch 'master' into fix-bindable-ctor
2021-07-13 12:46:01 +09:00
ac15dae930
Update framework
2021-07-13 12:35:25 +09:00
351a46b379
Merge pull request #13823 from ekrctb/catch-editor-tests
...
Add some tests for catch editor blueprints
2021-07-13 08:27:41 +09:00
cce4a4dc31
Fix incorrect value copy order in BindTo()
2021-07-12 22:27:36 +02:00
821c1b5335
Update hue of green colour scheme
2021-07-12 19:11:40 +03:00
62a00a82de
Revert completely irrelevant changes
...
This reverts commit b2b966463a
2021-07-12 19:11:28 +03:00
b2b966463a
Update hue of green colour scheme
2021-07-12 19:05:36 +03:00
c96a76df67
Update specified link
2021-07-12 18:21:10 +03:00
1437772711
Update hue of orange colour scheme
2021-07-12 18:11:51 +03:00
9869986c59
Remove duplicated colour definitions
2021-07-12 17:55:29 +03:00
1deaefacb7
Add "basic" lime colour theme
2021-07-12 17:53:15 +03:00
c6bd58ea4b
Exit match sub screen when a room goes away
...
Closes #13847 .
I think we can probably get some test coverage of this if required, but
needs a bit of thought (basically an error needs to be thrown during the
multiplayer client portion of the join procedure, after `CurrentRoom` is
non-null but before the join completes).
Manual testing on password branch (#13861 ) is possible since it
currently errors due to missing method on the live/dev servers.
- Create game, which will fail with `MethodNotExists`.
- Note the fields on the settings screen are emptied.
- Fill fields again and press create game (crash).
2021-07-12 19:20:41 +09:00
4b393209ec
Implement UnbindFrom()
2021-07-12 17:33:29 +09:00
242982730f
Fix incorrect DifficultyBindable binding implementation
2021-07-12 17:09:09 +09:00
36dd2c36de
Merge pull request #13859 from peppy/update-realm-win-81-fix
...
Update realm libraries to fix windows 8.1 incompatibility
2021-07-12 16:40:35 +09:00
d5d7dd0e74
Merge pull request #13701 from frenzibyte/consume-bindable-current-factory
...
Fix `RestoreDefaultValueButton` not behaving correctly on number types
2021-07-12 14:49:00 +09:00
f548ba4f69
Update realm libraries to fix windows 8.1 incompatibility
2021-07-12 14:07:17 +09:00
0c52b26d23
Merge pull request #13824 from peppy/da-mod-refactor
...
Refactor `ModDifficultyAdjust` to more elegantly track user override status
2021-07-12 12:03:45 +09:00
a6258d705e
Make CurrentNumber internal
2021-07-12 11:26:30 +09:00
32b4f5fbd6
Do not store direct references to original bindable
...
`DifficultyAdjustSettingsControl` and its inner `SliderControl` were
holding different references to `DifficultyBindable`s from the
difficulty adjust mod, therefore leading to bindings being lost to the
framework-side automatic unbind logic if the mod was toggled off and
back on in rapid succession.
Resolve by adding a shadowed implementation of `GetBoundCopy()` and
using it to isolate the controls from the mod bindable.
2021-07-11 15:28:13 +02:00
f21ea3b790
Update player test scene Ruleset bindable from creation method
2021-07-11 03:46:19 +03:00
07ede7a147
Disallow custom rulesets from score submission
2021-07-11 03:34:57 +03:00
c44558e3c8
Add back LoadComplete override
2021-07-10 17:57:52 +03:00
1bd5b1a8b9
Merge branch 'master' into fix-access-denied-test-failures
2021-07-10 13:00:27 +02:00
e4f13e311e
override add auto link in text flow container
2021-07-10 17:58:00 +07:00
45ff28f83b
add autolink constructor
2021-07-10 17:57:33 +07:00
6f89f8e572
Merge branch 'master' into da-mod-refactor
2021-07-10 11:41:54 +02:00
6a5f0e8237
Move handling of replay seek operations out of progress bar
...
This is in order to avoid using the now obsoleted property
`SliderBar.AllowKeyboardInputWhenNotHovered`
(see https://github.com/ppy/osu-framework/pull/4579 ).
2021-07-09 14:28:59 +09:00
741062a6da
Simplify bindable update methods
2021-07-09 13:58:44 +09:00
e0277763d0
Refactor DifficultyAdjustSettingsControl to help with readability
2021-07-09 13:50:07 +09:00
f9cd7f10d8
Allow null values for ReadCurrentFromDifficulty
...
As long as this isn't a constructor parameter it feels best to
gracefully handle omission. Realistically having it in the ctor is the
best move, but it doesn't feel great in line with the other parameters
passed in via object initalisers.
2021-07-09 13:26:01 +09:00
90326f8864
Standardise variables
2021-07-09 13:24:26 +09:00
df4bd86cfc
Fix storage wrapping logic setting logger too early in startup sequence
2021-07-09 13:18:49 +09:00
f3b68a4fbf
Fix storage wrapping logic setting logger too early in startup sequence
2021-07-09 13:17:25 +09:00
9f7c6adb58
Fix test failures due to logger pollution
...
As seen at
https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050307 . I
can't confirm that this will fix the issue but it looks like the only
plausible reason. I have confirmed that the logging is not coming from
the local (first logging is guaranteed to be after `SetupForRun`).
2021-07-09 12:15:30 +09:00
dbfeea9880
Merge pull request #13831 from nekodex/add-dropdown-sound-to-profile
...
Change profile section expansion button to use dropdown sounds
2021-07-09 11:58:48 +09:00
2eb12a59b7
Rename function to be more accurate
2021-07-09 11:16:47 +09:00
0223c569df
Remove no longer necessary method definitions
2021-07-09 00:49:05 +03:00
a7be632770
Improve documentation
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-07-09 00:39:09 +03:00
3e21eeb7c2
Merge branch 'master' into fix-mod-select-cross-talk
2021-07-08 19:53:50 +02:00
f5166d8dd5
Merge branch 'master' into consume-bindable-current-factory
2021-07-08 18:13:48 +03:00
b7803b889e
Rename control class to be more descriptive
2021-07-08 20:37:38 +09:00
8746ef0ba9
Avoid double playback of sample
2021-07-08 20:36:25 +09:00
546f55d341
Change profile section expansion to use dropdown sounds
2021-07-08 20:23:11 +09:00
93eb385dd4
Add sound for switching between volume controls
2021-07-08 20:01:39 +09:00
af270cccc4
Fix cross talk between ModSelectOverlays
2021-07-08 17:59:04 +09:00
ba939c0b65
Simplify serialisation edge case by moving to Value override
2021-07-08 17:49:00 +09:00
52ea62e3b2
Add more comments and xmldoc
2021-07-08 17:49:00 +09:00
