Commit Graph

7823 Commits

Author SHA1 Message Date
852e4a9766 Add select/deselect all buttons to free mod select screen 2022-05-07 09:29:33 +02:00
0b95594f60 Add some more padding between footer and column scroll 2022-05-07 09:29:33 +02:00
0c6de331f3 Move footer button padding to a higher level 2022-05-07 09:29:32 +02:00
dd63657dfb Merge pull request #18065 from huoyaoyuan/code-style
Enforce code style analysis shipped with .NET SDK
2022-05-07 14:58:19 +09:00
6fc808be22 Code quality 2022-05-06 23:17:59 +01:00
9d62206176 Update new chat overlay day separator colours and spacing
Updates the `DaySeparator` component to have separately settable colours
for the text and the lines.

Updates existing overrides of the `DaySeparator` to use the new colour
setter.

Create new `ChatOverlayDrawableChannel` with adjusted spacing and new
`DaySeparator` colours.
2022-05-06 23:06:18 +01:00
8c73ed7207 Fix sequence equality check not using reference comparison 2022-05-06 21:47:04 +02:00
621f746789 Do not modify selected mods through panel state change during external update 2022-05-06 21:47:04 +02:00
c199b8fcb6 Simplify state management in ModColumn
Bad sign when you can't follow your own code.

All of the various state changing methods were flattened into one
because it was too hard to follow what was calling what and why.
2022-05-06 21:46:16 +02:00
1409f8ca96 Merge branch 'master' into fix-toolbox-expansion 2022-05-06 18:00:01 +03:00
c533c93ffd Remove leftover border thickness spec in mod settings area
Was never supposed to be there, it was a vestige of a previous design
iteration that went by unnoticed.
2022-05-06 15:34:49 +02:00
e527574ede Merge branch 'master' into fix-toolbox-expansion 2022-05-06 13:47:36 +02:00
98eab9668d Merge pull request #18119 from bdach/mod-overlay/broken-hover
Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select
2022-05-06 20:42:33 +09:00
e9d52aa954 Remove not-accessed field 2022-05-06 13:09:37 +02:00
a915b7333c Remove unused using directive 2022-05-06 13:08:54 +02:00
88c190f3e3 Change colour denoting expanded state to be gray rather than yellow
I always found the yellow colour very non-descript in this case. Gray
seems to work better?
2022-05-06 19:45:17 +09:00
b432885e5f Tidy up ordering of SettingsToolboxGroup 2022-05-06 19:39:09 +09:00
59add66632 Remove unnecessary autosize workaround (was fixed long ago) 2022-05-06 19:39:00 +09:00
949e30c4b4 Remove auto-expansion of individual toolbox groups when parent expanding container expands 2022-05-06 19:36:41 +09:00
08fd0ea086 Fix click-to-return container still handling hover when inactive 2022-05-06 12:28:53 +02:00
be960eb092 Move dangerous hold specification to base class 2022-05-06 14:34:31 +09:00
0d8e42b941 Merge branch 'master' into exit-multiplayer-is-dangerous 2022-05-06 14:25:18 +09:00
0974de8fb0 Use BindableFloat for chat height 2022-05-05 23:13:32 +01:00
16a6c11bc8 Clamp maximum and minimum height the chat overlay can be resized to 2022-05-05 21:40:37 +01:00
34cf4c6a38 Fix mod overlay not closing on toggle hotkey 2022-05-05 22:16:56 +02:00
a56eab2c47 Extract interface for overlay management 2022-05-05 22:16:55 +02:00
ac08498f35 Use plum colour scheme in multiplayer to match rest of multiplayer screens 2022-05-05 22:16:54 +02:00
79e1b93b30 Close customisation area on escape press before exiting 2022-05-05 19:17:36 +02:00
2cc56a4b19 Fix hidden issue with automatic customisation panel show logic
Doesn't cause tests to fail headless, but they do fail in the test
browser.
2022-05-05 19:17:36 +02:00
9d48bb41c9 Merge branch 'master' into new-chat-overlay 2022-05-05 23:12:31 +09:00
5ea6f62951 Ensure RelativePositionAxes is set in BDL for animations to work 2022-05-05 14:20:33 +01:00
e46f99bdba Merge branch 'master' into dialog-overlay-thread-woes 2022-05-05 20:57:51 +09:00
97221d2ef1 Tidy up initialisation 2022-05-05 19:24:18 +09:00
e54f5e2d92 Adjust value change variables to avoid e usage 2022-05-05 19:22:20 +09:00
74505ba166 Remove ! usage (also seems to fix height saving/loading) 2022-05-05 19:22:12 +09:00
25ea660b0b Replace HandlePositionalInput override with simple hover effect 2022-05-05 19:13:48 +09:00
4efaa41670 Merge branch 'master' into new-chat-overlay 2022-05-05 18:57:00 +09:00
f6a6a11391 Remove DialogOverlay local fades (is already managed by PopupDialogs themselves) 2022-05-05 15:02:23 +09:00
326ff3b6e9 Fix CurrentDialog being updated twice, unsafe variable access 2022-05-05 14:55:05 +09:00
a27fcda9f1 Fix failing tests due to CurrentDialog being unexpectedly not set after Push 2022-05-05 01:52:39 +09:00
e294069e2f Merge branch 'master' into beatmap-selection-keybinding 2022-05-04 16:48:49 +03:00
9416346c94 Globalise beatmap selection key bindings as "group" selection 2022-05-04 16:46:32 +03:00
1a85e1267b Ensure focus is directed to ChatTextBox from ChatOverlay and add tests 2022-05-04 14:43:40 +01:00
ddab3c6d80 Tidy up state variables 2022-05-04 21:00:11 +09:00
383245f43a Fix dialoged pushed to DialogOverlay too early potentially doing cross-thread transforms
As seen at https://github.com/ppy/osu/runs/6287700705?check_suite_focus=true.
2022-05-04 20:23:36 +09:00
3eead5a6a3 Rename FlushAnimation to FlushPendingSelections to better match purpose 2022-05-04 19:40:08 +09:00
60999e83e0 Ensure ChatTextBox takes/leaves focus on chat overlay pop in/out 2022-05-03 22:33:36 +01:00
c17edb2848 Add padding to text in ChatTextBar to separate it from the textbox 2022-05-03 22:32:51 +01:00
50aee8b665 Ensure ChannelListSelector text also turns white when selected 2022-05-03 22:32:01 +01:00
f5fa41356e Rewrite mod instance management again to pass tests 2022-05-03 22:31:34 +02:00