Commit Graph

638 Commits

Author SHA1 Message Date
60358c7203 Perform first inspector text update immediately
Provides better and more consistent initial state for the inspector.
2023-04-10 14:13:53 +02:00
641415ca32 Unify displayed duration format for single/multiple selection 2023-04-10 14:05:32 +02:00
ad717d2368 Fix scheduled calls piling up during transactions 2023-04-06 23:39:36 +09:00
9c8b25e034 Fix display not always updating when expected by updating on a schedule 2023-04-05 13:45:24 +09:00
f07d859532 Optimise how often we update the display 2023-04-04 19:31:33 +09:00
3209b09270 Move inspector into own file 2023-04-04 19:17:34 +09:00
4aed483005 Tidy up dependency resolution 2023-04-04 19:14:30 +09:00
195b5fc3f1 Add view for selections of size != 1 2023-04-04 19:11:48 +09:00
b0d5761667 Add object type 2023-04-04 19:05:50 +09:00
c356c163fa Add hit object inspector view 2023-04-04 19:03:45 +09:00
f9ebdadfe8 Move right-side editor toolbox to base HitObjectComposer
Move right-side editor toolbox to base `HitObjectComposer`
2023-04-04 19:00:56 +09:00
d9ca7102f0 Use more generic wording for future-proofing 2023-02-19 15:06:40 +01:00
aac32a2c9f Combine config and time checks into one
Functionally equivalent right now, but the combined variant is more
localised to what it actually needs to do, and less error-prone if
any new code gets appended to the method.
2023-02-19 13:14:51 +01:00
f3522c4162 change bindable seekToHitObject to private 2023-02-19 10:18:02 +01:00
ddd37bb319 Add setting to disable automatic seeking after object placement 2023-02-18 19:43:45 +01:00
191259c050 Use equals instead and update other usage 2023-02-04 19:58:48 -08:00
b792dc3af0 Merge pull request #22281 from cdwcgt/editor-check-previewtime
Add preview time setting check
2023-02-02 15:10:06 +09:00
5b3d7a8f26 Fix typo in missing-preview-point message 2023-02-02 14:34:59 +09:00
c2cde8361a Fix message not reading well 2023-02-02 14:33:41 +09:00
3a861fd943 Remove multiple cases of excess braces 2023-02-02 14:28:21 +09:00
76296eb35a Consistent with BeatmapsetVerifier 2023-02-01 11:52:14 +08:00
1f40b2daf6 Clean up xmldocs 2023-01-23 21:22:18 +01:00
5afb733fb2 change IssueTemplatePreviewTimeConflict's text 2023-01-23 15:26:28 +09:00
73f083a316 Refactor how additional points are provided to avoid confusion 2023-01-23 14:13:46 +09:00
f8d8a627b8 change property name 2023-01-18 22:00:39 +01:00
ab78dd0436 add collection of selection points. 2023-01-18 21:34:23 +01:00
e5eab72aeb add check for preview time setting 2023-01-19 01:08:37 +09:00
e5863fbaf1 add ScreenSpaceEndPoint field 2023-01-10 21:20:09 +01:00
ba99f1288c Update IBeatSnapProvider documentation to mention the pre-divided BeatSnap 2022-12-02 17:57:15 +09:00
6a61e70766 Expose Ruleset from HitObjectComposer instead 2022-11-30 12:17:58 +01:00
4215f4f5d7 Merge branch 'master' into Editor-DrawableRuleset-Dependencies 2022-11-30 17:42:46 +09:00
93ba84e5ff Fix code style 2022-11-27 21:48:44 +01:00
70c320b2e8 Provide ruleset dependencies only to Compose Placement Blueprints 2022-11-27 21:43:33 +01:00
894ef15e79 Merge branch 'master' into update-framework 2022-11-26 16:19:36 +01:00
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
76e9382e0b Fix triangles showing on ExpandableButtons when in contracted state 2022-11-25 20:18:35 +09:00
65e5c9a3ae Dispose DrawableRulesetDependencies in HitObjectComposer 2022-11-25 08:27:22 +01:00
7b620392fe Provide DrawableRulesetDependencies from HitObjectComposer 2022-11-24 13:13:45 +01:00
ada039151b Add the ability to toggle off hit marker displays in the editor 2022-11-08 18:07:06 +09:00
e02c477008 Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks
Remove nullable disable in the checks.
2022-11-06 18:39:03 +09:00
29bc653d24 Remove incorrect double multiplication and add missing test coverage 2022-11-01 17:17:54 +09:00
2a88409dfe Fix time snap of sliders not matching when SV is not 1.0x
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.

Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.

The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
a1a9238bd1 Use empty string instead of null because issue template not accept null. 2022-10-30 16:31:07 +08:00
505ec800da File name should be nullable. 2022-10-30 16:29:54 +08:00
db48a57fa7 Remove nullable disable annotation in some checks class. 2022-10-30 16:28:49 +08:00
24c27e62f6 Remove nullable disable annotation in the issue and issue template-related class. 2022-10-30 16:25:15 +08:00
6b53ea3400 Enable distance snapping when DS value is changed via user interaction 2022-10-26 13:37:01 +09:00
7d59bc6e2f Merge branch 'grid-momentary-shortcuts' into read-current-distance-snap 2022-10-26 13:28:04 +09:00
54ae16badc Move distance snap toggle button implementation to DistancedHitObjectComposer 2022-10-26 13:27:23 +09:00
8d9a85e9e5 Fix typos in xmldoc
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-10-26 13:14:12 +09:00