Commit Graph

1444 Commits

Author SHA1 Message Date
e9b8cbb516 Apply other styles. 2019-11-11 20:27:04 +08:00
ccc8aa6fa4 Apply brace style. 2019-11-11 20:13:13 +08:00
143f316cbe Merge branch 'master' into fix-network-stalls 2019-11-06 17:54:08 +09:00
b5a8bbaa60 Merge branch 'master' into editor-timing-screen 2019-11-06 12:02:00 +09:00
ddd58ea3da Use LongRunningLoad on network load components 2019-11-01 19:40:45 +09:00
0cd912fcd3 Cover all non-APIAccess APIRequest calls with exception handling 2019-10-31 15:04:13 +09:00
5899bbd8a6 Fix merge regressions 2019-10-30 18:45:50 +09:00
93076ad6a1 Merge branch 'master' into editor-timing-screen 2019-10-30 18:42:20 +09:00
cf2d885099 Fix control points being flushed too late 2019-10-30 18:02:18 +09:00
514c9f1eef Merge branch 'master' into bindable-control-points 2019-10-30 16:20:54 +09:00
ced6042b3e Use internal type name 2019-10-30 15:51:09 +09:00
1a4817879e Fix precision changes in legacy control point types 2019-10-28 19:10:39 +09:00
090881cf6f Add default bindable values 2019-10-28 16:23:43 +09:00
8f87957c70 Make all control point attributes bindable
Properties are left intact for compatibility reasons.
2019-10-28 16:23:43 +09:00
43ad4a3a3c Tidy up string output 2019-10-28 12:31:38 +09:00
8069674824 Merge remote-tracking branch 'upstream/master' into bindable-control-points 2019-10-28 11:52:04 +09:00
45da22afe9 Add xmldoc and combine GroupAt / CreateGroup 2019-10-28 11:40:33 +09:00
2a6b3fd67c Disallow inserting a group if one already exists with the current time value 2019-10-28 11:40:10 +09:00
59d983b66e Allow binding to ControlPointInfo's Groups 2019-10-28 11:39:53 +09:00
10033239c7 Allow binding to ControlPointGroup's ControlPoints 2019-10-28 11:39:17 +09:00
814b520e5e Avoid potential mis-cast in comparison 2019-10-27 11:35:45 +09:00
4290a71f44 Add special case for timing points
Timing points can't fallback to defaults and must be added at least once.
2019-10-26 11:38:05 +09:00
7502b64541 Merge branch 'control-point-grouping' into no-auto-gen 2019-10-26 10:35:34 +09:00
d6a49b9e93 Add back autogeneration rules
Will be removed in https://github.com/ppy/osu/pull/6604
2019-10-26 10:25:37 +09:00
7100319858 Fix incorrect control point retrieval in non-lookup cases 2019-10-26 08:31:41 +09:00
b52be3d639 Merge branch 'control-point-grouping' into no-auto-gen 2019-10-26 01:20:08 +09:00
d25f7f4c27 Correctly clear other lists 2019-10-26 01:19:23 +09:00
c031aeb14c Fix inspection 2019-10-26 00:06:05 +09:00
eefa411182 Merge branch 'control-point-grouping' into no-auto-gen 2019-10-25 23:15:25 +09:00
d4fed43be7 Merge branch 'equivalent-to' into control-point-grouping 2019-10-25 23:15:15 +09:00
e39016bf01 Fix known non-nulls 2019-10-25 20:04:27 +09:00
8baf569f59 Remove necessity of AutoGenerated flag 2019-10-25 19:58:42 +09:00
e987db37ec Add grouping of ControlPoints 2019-10-25 19:52:02 +09:00
e2f2638212 Replace local Equatable implementations with abstract EquivalentTo 2019-10-25 19:44:28 +09:00
405ab07800 Check equality by ID -> OnlineBeatmapSetID -> Hash -> ReferenceEquals 2019-10-17 01:18:29 +03:00
14c72f85fa Fix incorrect beatmap set info equality check on non-online set info 2019-10-15 23:40:48 +03:00
7c2c537bc9 Allow fallback decoder overwrite
To fix the runtime crashes in difficulty calculation components, remove
the check for pre-existing fallback registration along with
the exception. The xmldoc for the registration function has been
extended to make users aware of possible consequences of calling it.
2019-10-04 18:20:20 +02:00
ffde389641 Add difficulty calculator beatmap decoder fallback 2019-10-04 13:28:32 +09:00
6268bbcfc8 Merge branch 'master' into beatmap-parsing-fallback-v2 2019-10-03 15:12:21 +08:00
cc533e8fe4 Remove BindableBeatmap 2019-10-01 17:24:47 +09:00
04ac414249 Fix memory leaks due to audio track recycle order 2019-10-01 13:49:09 +09:00
45f2bcc440 Fix combo bindings not being bound to nested hitobjects 2019-09-26 17:39:19 +09:00
a06cb54732 Merge branch 'master' into beatmap-parsing-fallback-v2 2019-09-20 15:28:08 +09:00
cffee1fd5e Fix imported beatmap paths not correctly matching files 2019-09-19 20:02:45 +09:00
92556db9cd Add query-based filter modes to song select search field 2019-09-19 02:48:28 +09:00
dd9f620c23 Fix misleading xmldoc 2019-09-15 01:28:07 +02:00
86588778b1 Implement fallback decoder registration
After the preparatory introduction of LineBufferedReader, it is now
possible to introduce registration of fallback decoders that won't drop
input supplied in the first line of the file.

A fallback decoder is used when the magic in the first line of the file
does not match any of the other known decoders. In such a case,
the fallback decoder is constructed and provided a LineBufferedReader
instance. The process of matching magic only peeks the first non-empty
line, so it is available for re-reading in Decode() using ReadLine().

There can be only one fallback decoder per type; a second attempt of
registering a fallback will result in an exception to avoid bugs.

To address the issue of parsing failing on badly or non-headered files,
set the legacy decoders for Beatmaps and Storyboards as the fallbacks.

Due to non-trivial logic, several new, passing unit tests with possible
edge cases also included.
2019-09-15 01:28:07 +02:00
11eda44d34 Migrate decoding to line-buffered reader
Migrate all usages of StreamReader in the context of decoding beatmaps,
storyboards or skins to the new LineBufferedReader.
2019-09-15 01:28:07 +02:00
65aa7b2016 Recreate beatmap video on each consumption
Should not be shared over multiple usages
2019-09-14 00:07:06 +09:00
437e121056 Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-video 2019-09-13 13:39:58 +03:00