Commit Graph

4015 Commits

Author SHA1 Message Date
6c7475f085 Fix snapped distances potentially exceeding the source distance
This results in slider placement including "excess" length, where the
curve is not applied to the placed path. This is generally not what we
want.

I considered adding a bool parameter (or enum) to change the
floor/rounding mode, but on further examination I think this is what we
always expect from this function.
2020-08-25 18:58:01 +09:00
dbf90551d6 Add coverage for empty metrics case 2020-08-24 20:47:29 +02:00
50d5b020b7 Add failing test case 2020-08-24 20:40:45 +02:00
492be0e016 Fix formatting 2020-08-23 15:23:10 +02:00
e6646b9877 Resolve review comments 2020-08-23 15:08:02 +02:00
6e19521528 Merge branch 'master' into patch2 2020-08-22 18:53:40 +03:00
f9fe37a8a5 Added test for "hp" filter keyword 2020-08-22 01:54:01 +03:00
809a61afcb Adjust key binding panel tests to not rely on row indices 2020-08-21 23:37:54 +02:00
356c67f00d Remove outdated/wrong test 2020-08-22 00:55:03 +09:00
4239e9f684 Fix storyboard test not actually working due to incorrect track referencing 2020-08-21 18:44:14 +09:00
d5cbb589c2 Revert some test scene changes to use Beatmap.Track where relevant 2020-08-21 17:21:08 +09:00
70697cf1a0 Restore remaining editor components to use Beatmap.Track 2020-08-21 17:11:29 +09:00
0ae460fb8f Avoid beatmap load call in IntroScreen 2020-08-21 15:50:14 +09:00
d2c2e8bbe8 Revert some more usage of MusicController back to WorkingBeatmap 2020-08-21 15:17:21 +09:00
05b402132e Merge branch 'master' into beatmap-track-rework 2020-08-21 13:25:04 +09:00
357fb3a10e Merge branch 'master' into beatmap-track-rework 2020-08-21 12:53:09 +09:00
dcce7a2130 Cache local music controller to resolve failure 2020-08-20 21:03:27 +02:00
bd4acdce78 Add until step to ensure failure 2020-08-20 21:01:58 +02:00
5714c761eb Merge pull request #9768 from frenzibyte/allow-counter-customize-sprite-text
Allow providing custom sprite text for RollingCounter<T>
2020-08-20 00:14:48 +09:00
3e4eae7fe4 Remove unnecessary until step 2020-08-19 19:10:45 +09:00
06503597e0 Remove unnecessarily exposed visibility state 2020-08-19 19:09:35 +09:00
5737a52fd0 Merge branch 'master' into fix-toolbar-visibility 2020-08-19 19:08:41 +09:00
72f16eb186 Merge pull request #9905 from smoogipoo/fix-holdnote-tick-judgement 2020-08-19 19:07:38 +09:00
8f1a71c6b1 Remove counter sprite attributes for not being of any reasonable use 2020-08-19 07:44:45 +03:00
6aa31dffdb Fix toolbar not respecting current overlay activation mode. 2020-08-18 15:34:56 +02:00
a4ad0bd174 Ensure 0 score from miss judgements, add test 2020-08-18 19:51:26 +09:00
e4303d7943 Fix PlayerLoader test failures due to too many steps 2020-08-18 12:35:23 +09:00
93a8bc3d5a Remove local reset method in GameplayClockContainer 2020-08-17 22:36:09 +09:00
d9debef156 Add explicit LoadTrack method 2020-08-17 15:38:16 +09:00
589d4eeb52 Remove setting. 2020-08-16 17:18:40 +02:00
71f4e753f0 Merge branch 'master' into beatmap-track-rework 2020-08-16 22:35:32 +09:00
cfd82104db Minor changes and improvements 2020-08-16 01:00:28 +02:00
434354c44c Properly implement SkinConfiguration equality 2020-08-16 00:21:26 +02:00
3a6e378a08 Change skin testing 2020-08-15 23:41:53 +02:00
1448c9e381 Merge remote-tracking branch 'upstream/master' into combo-colors 2020-08-15 23:01:38 +02:00
0e8411f76c Rename fields and make readonly 2020-08-15 22:06:26 +02:00
c4a7fac760 Add required parameters and other various changes 2020-08-15 22:03:24 +02:00
c1a9bf507a Add failing test case 2020-08-15 13:06:53 +02:00
e465afa280 Merge branch 'master' into beatmap-track-rework 2020-08-14 20:02:43 +09:00
626cd4042f Merge branch 'master' into delay-beatmap-load 2020-08-14 15:09:30 +09:00
2c6afce524 Merge pull request #9843 from smoogipoo/fix-playlist-mods 2020-08-14 11:11:13 +09:00
74a8a4bca8 Make testing code clearer to understand. 2020-08-13 21:53:17 +02:00
0500d82b5b Fix playlist items sharing mod instances 2020-08-13 19:48:41 +09:00
3cb22fad82 Fix mods sharing bindable instances 2020-08-13 19:48:31 +09:00
9e7a28002d Merge branch 'master' into beatmap-track-rework 2020-08-13 17:56:50 +09:00
cf9bda6c19 Add coverage of early exit with null and non-null player 2020-08-13 13:05:13 +09:00
fd7bf70b7d Remove weird "after load" action
This was pretty pointless anyway and from its usages, doesn't look to
need to exist.
2020-08-13 13:03:18 +09:00
5b536aebe7 Add missing null checks and avoid cross-test pollution 2020-08-13 12:53:37 +09:00
91e28b849d Fix incorrect BeatmapManager construction 2020-08-13 00:29:23 +09:00
429ad783cf Merge branch 'update-framework' into beatmap-track-rework 2020-08-12 23:35:46 +09:00