Commit Graph

40594 Commits

Author SHA1 Message Date
181f1da3d3 Maintain catch hit explosion by lifetime entries
- Fix hit explosion not showing when a replay is rewound to a time after a hit object is caught
2021-06-04 19:46:50 +09:00
d7da66d876 Bring back scheduling of follow point update 2021-06-04 18:41:02 +09:00
0098ac2760 Remove one TODO
It can be removed because pooled drawables are always ready, and `FollowPointConnection` is also ready when applied.
2021-06-04 17:09:59 +09:00
bc892086fe Resolve nullable inspection, enable nullable for FollowPointLifetimeEntry 2021-06-04 17:09:59 +09:00
ae2165b3be Fix incorrect xmldoc 2021-06-04 16:44:04 +09:00
b373b120ff Use general lifetime container for follow point container 2021-06-04 16:31:50 +09:00
37c8c63fc5 Ensure all frames in an animation are retrieved from the same skin 2021-06-04 16:18:04 +09:00
2069a5bd28 Merge pull request #13313 from ekrctb/factor-out-hoc
Factor out entry management logic of `HitObjectContainer` to the new base class
2021-06-04 16:06:48 +09:00
06275a6a7d Merge branch 'master' into legacy-skin-default-fallback 2021-06-04 16:00:30 +09:00
35aeef6838 Merge pull request #13328 from peppy/increase-music-volume
Increase music volume back to 80% for the time being
2021-06-04 15:36:04 +09:00
b283c48abb Merge branch 'master' into factor-out-hoc 2021-06-04 15:31:35 +09:00
a02c39b066 Merge pull request #7316 from mcendu/kiai
Implement kiai flash of hit circles
2021-06-04 15:31:19 +09:00
19a44d65c5 Tidy up code 2021-06-04 15:18:16 +09:00
23096c58bb Merge branch 'master' into fix-spectator-frame-conversion 2021-06-04 15:06:15 +09:00
071c07586a Increase music volume back to 80% for the time being 2021-06-04 15:00:53 +09:00
996c156106 apply suggestions
- apply 0 alpha to beatmap background if storyboard replaces it
- use an AudioContainer to mute all samples coming from the storyboard
2021-06-04 13:56:10 +08:00
f62a2747f6 Add legacy implementation 2021-06-04 14:51:35 +09:00
52557da335 Add test coverage 2021-06-04 14:14:51 +09:00
5953674737 Tidy up constants 2021-06-04 14:14:51 +09:00
ff70f99da2 Merge branch 'master' into kiai 2021-06-04 13:50:12 +09:00
0ba493d598 Merge pull request #13318 from gagahpangeran/error-page-placeholder
Add error page placeholder for wiki overlay
2021-06-04 12:20:21 +09:00
eebd5745a8 Move full stop out of link and reword slightly 2021-06-04 11:44:43 +09:00
233551fc08 Merge pull request #13323 from gagahpangeran/extract-sidebar
Create abstract class `OverlaySidebar`
2021-06-04 11:38:36 +09:00
50c60c791f Merge pull request #13322 from Pasi4K5/seed-for-all-random-mods
Add seed option for all random mods
2021-06-04 11:26:13 +09:00
a648cdfd14 Merge pull request #13324 from peppy/fix-collection-enumeration-replay
Detach gameplay score from replay recorder before importing
2021-06-04 10:44:23 +09:00
905472a20b make NewsSidebar extends OverlaySidebar 2021-06-04 00:12:29 +07:00
076e498a63 create abstract class OverlaySidebar 2021-06-04 00:12:13 +07:00
d444fed46f Detach gameplay score from replay recorder before importing
Closes #13320.
2021-06-04 02:00:02 +09:00
7a4fc9ffc8 Move seed to base class 2021-06-03 18:16:11 +02:00
daff4a1a00 Merge pull request #11182 from angelaz1/keyboard_shortcuts
Add browser-like tab management hotkeys to chat overlay
2021-06-03 22:48:55 +09:00
c5fc155cc0 Change text wording
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-06-03 20:37:27 +07:00
b36c406a83 add test scene for error page 2021-06-03 19:48:04 +07:00
490ce0bbc5 load placeholder page when failed 2021-06-03 19:40:54 +07:00
e117f98bfa Rename test steps 2021-06-03 14:31:13 +02:00
5f5f3a8c5c General comment cleanups 2021-06-03 14:20:52 +02:00
b2cc2a51ec Rename method to be less misleading
Would rather avoid variations of Equals/Equal/IsEqual. There's not
really much equality involved as the types are different.
2021-06-03 14:13:01 +02:00
e8c2483f19 Use standard list instead of bindable list
No reason to use a bindable list there, as `CollectionChanged` was never
subscribed to.
2021-06-03 14:09:52 +02:00
8193691cbc Invert condition to reduce nesting 2021-06-03 14:09:52 +02:00
acb4873157 Merge branch 'master' into keyboard_shortcuts 2021-06-03 14:09:48 +02:00
d1110d00a0 Merge pull request #12204 from ilsubyeega/drawavatar-use-avatar-url
Use avatar_url from user first instead of a.ppy.sh in DrawableAvatar
2021-06-03 20:13:14 +09:00
33ab411e39 Merge branch 'master' into drawavatar-use-avatar-url 2021-06-03 19:36:32 +09:00
e887807ae7 Apply review fixes 2021-06-03 18:32:05 +09:00
be03a2d7d2 Fix multiple calls to seek method potentially not working 2021-06-03 17:47:22 +09:00
c3280083a2 Merge branch 'master' into fix-spectator-frame-conversion 2021-06-03 17:42:01 +09:00
662bbed5d1 Fix seeking to gameplay too soon 2021-06-03 17:38:51 +09:00
15b43beef1 Merge pull request #11857 from Syriiin/diffcalc/refactor/catch-clockrate-effects
Refactor catch Movement skill to not require explicit clockrate usage
2021-06-03 17:29:27 +09:00
d39eb7eac2 Merge pull request #12952 from peppy/autoplay-pause-support
Externalise autoplay generation from `Player` to allow use of replay playback functions
2021-06-03 17:29:17 +09:00
3bc81fbb06 Fix spectator tests 2021-06-03 17:27:24 +09:00
420df124b5 Add framestable-bypassing seek for spectator 2021-06-03 17:27:21 +09:00
8b43cfdd7d Merge pull request #12568 from Pasi4K5/mod-osu-random
Add mod "Random" for osu! ruleset
2021-06-03 17:14:27 +09:00