bd5037fcad
Fix new hitobject placements not taking on the existing sample settings
...
Similar to velocity / difficulty points, a user expectation is that
volume and sample settings will be transferred to newly placed objects
from the most recent one.
Closes https://github.com/ppy/osu/issues/18742 .
2022-06-18 13:49:59 +09:00
8a1d11fefb
Cancel previous metronome sound playback on pause
2022-06-18 04:07:21 +03:00
4bc26dbb48
Merge pull request #18743 from smoogipoo/nullable-by-default
...
Enable NRT by default
2022-06-17 23:18:35 +09:00
5d93db1522
Merge pull request #18726 from peppy/disclaimer-stop-handling-after-suspend
...
Fix `Disclaimer` screen handling user change events after initial display
2022-06-17 18:28:06 +09:00
1900480d51
Inline animation method
2022-06-17 17:06:06 +09:00
e51babdb96
Change heart animation flow to be more correct
2022-06-17 17:01:11 +09:00
fd9902e816
Manual #nullable processing
2022-06-17 16:38:35 +09:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
ea191da496
Merge pull request #18728 from peppy/fix-unsafe-sample-playback
...
Fix unsafe sample playback in `GameplaySampleTriggerSource`
2022-06-17 12:26:46 +09:00
6f2f4dda37
Merge branch 'master' into fix-up-down
2022-06-16 21:44:56 +02:00
e4ddf03ad6
Fix toolbar music button handling keys while not hovered
2022-06-16 20:22:57 +03:00
651862fee0
Merge branch 'master' into database-migration-reliability
2022-06-16 17:19:58 +02:00
bf6c6682bc
Move null to finally
2022-06-16 23:37:24 +09:00
7809566f16
Add explanatory comments
2022-06-16 23:31:49 +09:00
7b0fad6461
Null disposal token after use
2022-06-16 23:29:33 +09:00
9c4f6d2ce0
Merge branch 'master' into first-run-setup-notification-interruption
2022-06-16 15:14:40 +02:00
d48fbdb439
Merge branch 'bmm-cleanup' into bmm-cleanup-2
2022-06-16 19:48:54 +09:00
e66ccfd980
Add back missing notification flow
2022-06-16 19:48:18 +09:00
448eee051a
Update filename to match new class name
2022-06-16 19:41:14 +09:00
3860f0b3e5
Remove unused GetWorkingBetamap method
2022-06-16 19:08:59 +09:00
ce3d3a967c
Reimplement missing methods
2022-06-16 19:05:25 +09:00
a635664a86
Fix invalid method reference in comment
...
`BeatmapModelManager.Save()` was moved to `BeatmapManager`, not to
`BeatmapImporter`.
2022-06-16 12:01:53 +02:00
72c5b9009d
Remove local realm fields in manager classes
2022-06-16 18:56:53 +09:00
f3984d98e6
Remove RealmArchiveModelManager from hierarchy
2022-06-16 18:53:13 +09:00
8a5755ca52
Remove pointless override in test implementation
2022-06-16 18:27:16 +09:00
04e4c5ef88
Move and adjust implementation regions to restore sanity
2022-06-16 18:26:13 +09:00
4d9e3d1982
Rename Score/Skin ModelManager classes to Importer for now
2022-06-16 18:11:50 +09:00
1f3e1b2d97
Combine BeatmapManager and BeatmapModelManager into one class
2022-06-16 18:07:04 +09:00
8ea3042435
Move file extensions specification to common class
2022-06-16 18:00:27 +09:00
84dba36cf5
Update usages of BeatmapModelManager which only require importing to use BeatmapImporter
2022-06-16 17:59:24 +09:00
4c372539a1
Consolidate remaining methods in BeatmapModelManager
2022-06-16 17:59:24 +09:00
251923c106
Convert NotificationOverlay to NRT
2022-06-16 17:28:08 +09:00
6b30ee0950
Tidy up DI and binding logic
2022-06-16 17:26:43 +09:00
953ca8c2dd
Merge pull request #18715 from bdach/ruleset-mod-hardening
...
Add several protections when creating game-global available mods
2022-06-16 17:18:49 +09:00
4526f8c07d
Move database backup creation to async thread where possible
2022-06-16 17:01:17 +09:00
17dbb599d1
Don't backup collection database
...
This is no longer required due to recent changes which mean the
collection database will retain beatmap references even if they aren't
loaded locally (see https://github.com/ppy/osu/pull/18619 ).
2022-06-16 16:48:53 +09:00
739a696467
Ensure reading of existing databases when making backups doesn't create a file
2022-06-16 16:48:06 +09:00
ec53d87c30
Fix unsafe sample playback in GameplaySampleTriggerSource
...
Resolves https://github.com/ppy/osu/issues/18727 .
Added delay from `Schedule` should be minimal as it is always called
from the `Update` thread (input propagation) anyway.
2022-06-16 16:04:57 +09:00
89533fa33d
Fix Disclaimer screen handling user change events after initial display
...
Unnecessary overhead, but also should resolve a production hard crash.
2022-06-16 15:40:20 +09:00
ac554ca51f
Update resources
2022-06-16 15:06:34 +09:00
f88c568c8d
Update flag sizes after switch to twemoji assets
...
The old flags used a size of 150x100, while the new assets based on
twemoji use a size of 150x108. Update existing usages to match this new
aspect ratio better.
2022-06-15 21:45:47 +02:00
e7dcbddbeb
Fix potential null reference
2022-06-15 18:53:49 +03:00
1acbb87aa6
Ensure AvailableMods.Value is never null
2022-06-15 17:40:16 +02:00
30382b0445
Fill out GetModsFor() xmldoc and annotate items as non-null
2022-06-15 17:40:15 +02:00
e74b563b91
Add protection against arbitrary exceptions from GetModsFor()
2022-06-15 17:31:46 +02:00
6e5e506fb4
Add protection against rulesets returning null mods
2022-06-15 17:31:46 +02:00
026bad7fc4
Use notification processing mode logic instead
2022-06-15 18:13:24 +03:00
f23ddfe6cc
Move remaining realm classes out of Stores namespace
2022-06-15 21:56:00 +09:00
23d7667f39
Move BeatmapImporter to correct namespace
2022-06-15 21:47:52 +09:00
9edc4fc181
Remove unnecessary ShouldDeleteArchive override (already done in base implementation)
2022-06-15 21:47:52 +09:00
