Commit Graph

3345 Commits

Author SHA1 Message Date
25f36e87a6 Merge branch 'master' into overlay-scroll-container 2020-04-12 12:34:41 +09:00
41caa37856 Add tests 2020-04-10 13:29:49 +09:00
cc0bcea6e5 Merge pull request #8693 from smoogipoo/editorbeatmap-update-cleanup
Cleanup handling of hitobject updates
2020-04-09 21:32:58 +09:00
ecd7ce4b98 Fix test scene 2020-04-09 21:00:23 +09:00
ee6ea08cf8 Cleanup handling of hitobject updates 2020-04-09 20:16:44 +09:00
134feefa14 Remove bindable 2020-04-09 13:10:09 +03:00
2d3ea95469 Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-scroll-container 2020-04-09 13:06:22 +03:00
e10576325c Merge branch 'master' into update-overlay-headers 2020-04-09 16:29:34 +09:00
53b2f58eda Merge branch 'master' into overlay-scroll-container 2020-04-09 15:05:49 +09:00
2ddea018cf Fix hidden notes due to 0 minimum width 2020-04-08 17:15:59 +09:00
65db64e13e Add failing test cases 2020-04-07 22:41:20 +02:00
f0443bca3c Merge pull request #8643 from smoogipoo/fix-legacy-version
Make version-less skins fallback to version 1.0
2020-04-07 21:28:06 +09:00
5758a9fa4d Merge branch 'master' into fix-results-star-display-alignment 2020-04-07 12:28:33 +09:00
5dfa2a2bad Fix step namings 2020-04-07 11:50:40 +09:00
a4208f35c4 Make versionless skins fallback to version 1.0 2020-04-06 19:36:17 +09:00
8438ee7e07 Improve testing 2020-04-06 19:35:27 +09:00
0eaea8ef9d Create a constructor for break period
For simple construction of break periods (e.g. filling a method with an array of break periods inside a test case)
2020-04-05 21:29:03 +03:00
493b654011 Remove horizontal margin from mod display
Can skew center alignment on fill flow containers.

Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.
2020-04-03 11:30:02 -07:00
05e2ca0b68 Merge pull request #8590 from peppy/fix-intro-test-scene
Fix dynamic recompilation in intro test scenes
2020-04-03 19:40:46 +09:00
8cb0eb9b12 Fix dynamic recompilation in intro test scenes 2020-04-03 15:08:06 +09:00
877bd7837a Changed variable names 2020-04-02 22:02:57 -04:00
c042e709a5 Fix GetDecoder getting fallback decoder too often 2020-04-02 20:43:54 -04:00
a77933f5e0 Add support for parsing mania skin colours 2020-04-02 17:56:12 +09:00
e26fbd5ed8 Remove overcomplicated stuff 2020-03-31 13:45:59 +03:00
db59d0530e Remove test coverage of scale down 2020-03-31 14:15:25 +09:00
1fce7cce01 Remove ScaleDownToFit as it was not implemented without enough safety 2020-03-31 13:50:04 +09:00
2dc81bbcfa Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-scroll-container 2020-03-30 13:37:25 +03:00
35647d59a6 Add failing test 2020-03-30 19:09:05 +09:00
1ce4f7c854 Add tests 2020-03-30 17:37:08 +09:00
03cd9aa060 Merge branch 'master' into spun-out 2020-03-30 12:31:53 +09:00
113bbe8c4d Merge pull request #8488 from peppy/fix-autoplay-results-display
Fix auto mod results screen not displaying correctly
2020-03-30 11:01:16 +09:00
d99b445720 Move non-headless tests to correct namespace 2020-03-30 10:00:28 +09:00
98a700ef3a Attempt to fix tests by skipping one break at a time 2020-03-30 00:58:06 +09:00
f4c8b6d219 Fix copy paste oversight 2020-03-29 18:55:47 +03:00
a72f0f57f6 Refactor tests for readability 2020-03-30 00:05:07 +09:00
07c7233b3d Change int div comments 2020-03-29 23:46:28 +09:00
653480b2f8 Add regression test 2020-03-29 23:29:46 +09:00
b259708915 Merge branch 'master' into spun-out 2020-03-29 13:24:48 +09:00
8cab303611 Cover skipDifficulties = false in tests 2020-03-28 21:02:55 +02:00
63f6269eb0 Test both ways 2020-03-28 13:10:20 +02:00
659865b457 Use understandable set id 2020-03-28 13:08:06 +02:00
0a69647efe Merge remote-tracking branch 'origin/traversal-is-broken' into rewrite-select-next 2020-03-28 13:06:37 +02:00
3cc574e62d Merge branch 'master' into overlay-scroll-container 2020-03-28 16:46:01 +09:00
e9dc545429 Merge branch 'master' into fix-no-break-info 2020-03-28 12:39:37 +09:00
a317ef65b8 Remove default for argument 2020-03-28 12:18:28 +09:00
15fb1a099e Modify assert to avoid false failures
In headless tests it was possible for TestInstantLoad() to erroneously
fail. There were two scenarios in which LoadingSpinner could be null:

1. If the test runner was quick enough, the assert could end up running
   even before Loader.OnEntering() had even had a chance to, meaning
   that the spinner was never even actually assigned to or instantiated
   at that point in time.

2. Even if Loader.OnEntering() had managed to run, there was also
   a possibility that the spinner itself wasn't loaded at the point
   of checking the assertion. As the spinner is accessed through
   ChildrenOfType(), which only checks InternalChildren and ignores
   all currently-loading drawables, it would therefore return null.

As null != 0, both of these cases would actually fail the test (this is
best seen running headless, preferably with a [Repeat] attribute
attached).

To resolve, allow the spinner to be null at the point of asserting and
duplicate the assertion step at the end. This weakens the test, as case
(1) should probably be waited for and case (2) could be solved with
exposition as protected in the base, but when attempting to wait for
the loader itself to be loaded there were also cases where the
appropriate until step would take so much time that the spinner would
actually become visible in line with the delayed display logic, so this
is a best-effort attempt to address both points without radical
changes.
2020-03-28 00:43:57 +01:00
46af4bce32 Cover regression in autoplay test 2020-03-27 19:42:45 +01:00
7b24cc325f Implement OverlayScrollContainer component 2020-03-27 20:57:57 +03:00
6ecfeb8cc3 Merge pull request #8455 from Game4all/handle-novideo-beatmaps
Fix NullReferenceException when starting the no-video version of a beatmap with video
2020-03-27 21:12:40 +09:00
6788b7f9cd Add test for loading storyboards with missing video file. 2020-03-27 12:07:47 +01:00