Commit Graph

31172 Commits

Author SHA1 Message Date
8fc4d0c6f5 Add override edge rule to overflow above home indicator on iOS 2022-02-04 18:20:17 +09:00
d5269ba05b Merge branch 'fix-spectator-restart-crash' into spectator-state-rework 2022-02-04 17:59:18 +09:00
0473c6c52f Also handle null SelectedItem for safety 2022-02-04 17:53:51 +09:00
b41655d5b9 Fix crash when gameplay starts while in multi-spectator screen 2022-02-04 17:47:41 +09:00
30d2c7ba6a Add parenthesis to disambiguify conditionals 2022-02-04 17:07:23 +09:00
52fdf0349f Add safe area support via ScalingContainer 2022-02-04 16:37:05 +09:00
4728919bca Update framework 2022-02-04 15:45:27 +09:00
63064d682b Merge pull request #16743 from hlysine/extended-statistics-without-replay
Allow statistic items in results screen to display without needing to watch a replay
2022-02-04 15:07:52 +09:00
bbef12e72c Refactor ExpandingControlContainer to no longer rely on controls 2022-02-04 05:45:12 +03:00
ee1feae806 Remove unnecessary ruleset ordering
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-02-04 11:06:18 +09:00
6dc0f3fd96 Merge difficulty creation methods into one
One of them wasn't really doing much anymore and was more obfuscating
what was actually happening at this point.
2022-02-03 18:14:30 +01:00
b7d7e6612e Merge branch 'master' into new-difficulty-creation-v3 2022-02-03 16:36:18 +01:00
f285060148 Fix MultiSpectatorScreen not continuing to results 2022-02-03 21:50:19 +09:00
483977d5c8 Merge branch 'master' into spectator-state-rework 2022-02-03 19:59:07 +09:00
bef0a2da21 Remove return type from AddDifficultyToBeatmapSet
Also removes a pointless realm encapsulation.
2022-02-03 19:43:43 +09:00
ad47649d1c Make BeatmapModelManager.Save non-virtual 2022-02-03 19:38:53 +09:00
b2efce2656 Merge branch 'master' into expandable-controls 2022-02-03 19:23:34 +09:00
47d577ec9c Add back constructor for ruleset compatibility 2022-02-03 19:17:56 +09:00
6974c2d255 Remove weird panelIsComplete flag and replace LINQ with simple foreach 2022-02-03 19:00:03 +09:00
df9d99f5aa Merge branch 'master' into extended-statistics-without-replay 2022-02-03 18:59:48 +09:00
6d6327d3da Fix test beatmap loading potentially performing selection before carousel itself is loaded 2022-02-03 18:40:16 +09:00
e65996efc3 Rename variable to match purpose better 2022-02-03 17:14:38 +09:00
137a9a0305 Merge branch 'master' into songselect-random-sfx 2022-02-03 17:14:28 +09:00
c8ce00b26a Trigger a re-layout of HUD components when scoring mode is changed
This is a simple way of fixing the layout of scoring elements
overlapping due to different score display width requirements of
different scoring modes. It will only resolve the case where a user
hasn't customsied the layout of the default skins, but as this is a very
simple / low effort implementation for the most common scenario, I think
it makes sense.

Closes https://github.com/ppy/osu/issues/16067.
2022-02-03 14:50:41 +09:00
a69c7a9de6 Split exceptions back out to give better messaging 2022-02-03 14:09:27 +09:00
62fa915193 Standardise exception messages for local-user-logged-out flows 2022-02-03 13:58:55 +09:00
d9a43b4c4c Fix API requests not completing when offline 2022-02-03 13:16:54 +09:00
aff36d4e16 Refactor populateStatistics to avoid disposing 2022-02-03 11:52:37 +08:00
62537eb4aa Fix spectator not completing 2022-02-03 12:44:33 +09:00
b94fe84712 Merge branch 'master' into new-difficulty-creation-v3 2022-02-03 10:48:20 +09:00
2731d8e3c2 Merge pull request #16701 from LeNitrous/mod-alternate-osu
Add "Alternate" mod for osu! ruleset
2022-02-03 10:41:23 +09:00
a8ffc4fc2a Add editor override to respect IsolateSavingFromDatabase 2022-02-02 21:57:21 +01:00
47429fb0c6 Fix same-name safety firing wrongly 2022-02-02 21:57:21 +01:00
afc48d86df Add failing test coverage for save after safeties addition 2022-02-02 21:57:10 +01:00
4f1aac9345 Add safeties preventing creating multiple difficulties with same name 2022-02-02 21:57:09 +01:00
54bb6ad40c Fix working beatmaps not seeing new difficulties after add 2022-02-02 21:55:34 +01:00
0d51c015ad Add basic test coverage for new difficulty creation 2022-02-02 21:55:34 +01:00
dc96c4888b Add support for creating new blank difficulties 2022-02-02 21:55:33 +01:00
b613aedeb8 Fix menu item width changing when hovered 2022-02-02 21:23:35 +01:00
3386f038ba Add new difficulty creation menu 2022-02-02 21:23:35 +01:00
e2fcdc394b Extract method for difficulty switch menu creation 2022-02-02 21:23:35 +01:00
82f9ad63f5 Fix flashlight size multiplier printing with too many decimal digits 2022-02-02 20:41:25 +01:00
074a691635 Set keyboard step to 0.1 for difficulty adjust sliders 2022-02-02 17:43:08 +03:00
81a22dbd29 Add back playing users list 2022-02-02 23:19:43 +09:00
fcbba3d948 Rename PlayingUserStates -> WatchingUserStates 2022-02-02 23:11:29 +09:00
9d1d13c715 Fix up TestSpectatorClient implementation
Rather than using a list which is supposed to be updated "client"-side,
now uses the "server"-side list.
2022-02-02 23:05:09 +09:00
19eb9ad8a7 Reorder StatisticsItem constructor to make a touch more sense 2022-02-02 23:02:38 +09:00
3c2a6fe208 Don't prompt for a replay if no item requires hit events 2022-02-02 19:07:14 +08:00
1e19c7046a Use spacing instead of bottom margin 2022-02-02 19:02:29 +08:00
b0023b9809 Also dispose rows 2022-02-02 19:00:46 +08:00