392ff2ffea
Reword comment regarding hash transfer to make more sense
2023-01-25 14:11:02 +09:00
741ca96853
Make transferCollections
argument to private method explicitly required
2023-01-25 14:09:13 +09:00
739ec8d81d
Add argument hint for nondescript bool
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2023-01-25 14:04:30 +09:00
e6de167adb
Revert split and make collections boolean internal to BeatmapManager
2023-01-24 07:27:26 +09:00
1c1c9915bb
Split saving new and existing beatmaps into separate flows
2023-01-22 10:27:33 +09:00
a1b5c9d910
Don't transfer MD5 hashes in collections when copying beatmaps
...
Fixes #22306 .
Changes beatmap saving so that by default it does not transfer
the hashes in collections, and only transfers them when saving the same
difficulty in the editor.
Issue seems to have been introduced in https://github.com/ppy/osu/pull/20641 .
2023-01-22 01:14:18 +09:00
a9facc076f
Fix difficulty creation flow failing for some ruleset combinations
...
In current `master`, the difficulty creation flow would retrieve a
"reference beatmap" to copy metadata and timing points from using
`GetPlayableBeatmap()`. But, importantly, it was calling that method
using *the ruleset of the new difficulty* rather than the ruleset of the
existing one. This would make the difficulty creation flow fail if the
beatmap couldn't be converted between rulesets (like taiko to catch).
Fixing to use the reference beatmap's actual ruleset would be trivial,
but there's no real reason to do all of that work anyway when a
`WorkingBeatmap` is available. Because getting a playable beatmap is not
required to copy across metadata and timing points, remove the
`GetPlayableBeatmap()` step entirely to fix the bug.
Closes #22145 .
2023-01-14 19:46:55 +01:00
811a562608
Don't use bindables to avoid potential cross-usage contamination
2023-01-10 01:10:20 +09:00
62ffb4fe78
Pause imports during active gameplay
2023-01-09 18:54:11 +09:00
b8904fe747
Move ImportParameters
to better home
2022-12-13 21:41:26 +09:00
cb16d62700
Hook up ImportParameter
flow with IModelImporter
caller methods
2022-12-13 21:29:32 +09:00
cf2719d4c0
Convert batchImport
parameter to parameters class to allow further import configuration
2022-12-13 19:55:18 +09:00
66ed77ac91
Rename and add documentation to function
2022-10-28 18:04:28 +09:00
9bab02fab4
Remove unused using statement
2022-10-11 16:23:05 +09:00
eba3d37a11
Add xmldoc and simplify calling
2022-10-11 15:50:02 +09:00
e619c9c1e6
fix style
2022-10-10 21:48:41 -04:00
de8d485305
Move 'transferCollections' to a shared location
2022-10-10 21:45:33 -04:00
edec613724
Remove unnecessary '?'
2022-10-08 13:58:42 -04:00
ff14453c2b
Preserve collections when saving a beatmap
2022-10-08 12:42:29 -04:00
db15bd56e8
Invalidate working beatmap cache when calling DeleteDifficultyImmediately
rather than in editor code
2022-09-06 18:12:47 +09:00
579e7e1f17
Fix deleting a difficulty not updating the beatmap set hash
2022-09-06 18:12:47 +09:00
605108c938
Refactor/rename deletion method to read better
2022-09-02 16:59:01 +09:00
b388428e1c
Merge branch 'master' into feature/EditorDeleteDiff
2022-09-02 16:48:38 +09:00
11f38e539f
Rename property to LastLocalUpdate
2022-08-16 16:01:19 +09:00
c7db4a532c
Merge branch 'master' into store-modified-time
2022-08-16 15:53:51 +09:00
ac99c1ad69
Migrate the majority of existing file lookups to use new extension methods
2022-08-10 16:01:16 +09:00
8cb02f47eb
Mark BeatmapSet.Status
as modified when any beatmap is modified, rather than all
2022-08-02 16:08:58 +09:00
d7a06abcab
Add BeatmapInfo.LastUpdate
to track the time of local changes
2022-08-02 00:53:07 +09:00
013cf7a80a
Fix DateAdded
not being set to a sane value when creating a new beatmap in the editor
2022-08-02 00:53:07 +09:00
0fcae08d38
Show "locally modified" pill when local modifications have been made
2022-08-02 00:52:38 +09:00
cb52b696ed
Merge branch 'master' into bypass-local-metadata-cache
2022-07-29 16:05:54 +09:00
2ff6ff06d3
Use tuple to better explain new bool
parameter
2022-07-29 16:05:41 +09:00
c35da62224
Add flow for bypassing local cache lookups when refreshing beatmap metadata
2022-07-28 16:33:51 +09:00
2b9d46d803
Remove unused RulesetStore
from BeatmapManager
constructor
2022-07-28 16:19:05 +09:00
dd315ff97b
Adds hard-delete for a beatmap diff
2022-07-27 21:21:16 +10:00
8370ca9765
Add ImportAsUpdate
method to IModelImporter
to avoid otehr changes
2022-07-26 15:49:04 +09:00
2e14d8730c
Move implementation of updating a beatmap to BeatmapImporter
2022-07-25 19:51:19 +09:00
6a3e8e31de
Centralise calls to reset online info of a BeatmapInfo
2022-07-25 19:51:19 +09:00
2ec90e37bb
Fix calls to GetWorkingBeatmap
invalidating cache too often
...
With recent changes, the pathway between refetching (on request) and
refetching (on requirement due to unpopulated files) was combined.
Unfortunately this pathway also added a forced invalidation, which
should not have been applied to the second case.
Closes https://github.com/ppy/osu/issues/19365 .
2022-07-25 15:30:49 +09:00
c53dd4a703
Fix editor saving not updating BeatmapSetInfo
's hash
2022-07-08 02:33:14 +09:00
59d0bac728
Hook up update flow to metadata stream
2022-07-05 21:32:00 +09:00
0698471627
Move BeatmapOnlineLookupQueue
to inside BeatmapUpdater
2022-06-30 17:03:19 +09:00
82134ad1a6
Allow null
parameter to GetWorkingBeatmap
for now
2022-06-30 16:46:28 +09:00
7692bac35a
Simplify refetch (and ensure to invalidate after processing)
2022-06-24 21:02:38 +09:00
66a01d1ed2
Allow song select to refresh the global WorkingBeatmap
after an external update
2022-06-24 21:02:38 +09:00
6999933d33
Split updater process into realm transaction and non-transaction
2022-06-24 21:02:38 +09:00
fe570d8052
Queue beatmaps for update after editing
2022-06-24 21:02:38 +09:00
06d59b717c
Move beatmap processing tasks to new BeatmapUpdater
class
2022-06-24 21:02:37 +09:00
823b3c1c0f
Ensure WorkingBeatmap
is always using a detached instance
2022-06-24 19:07:54 +09:00
2ae48d5a87
Rename incorrect parameter name in BeatmapManager.GetWorkingBeatmap
2022-06-24 19:07:54 +09:00