Commit Graph

37709 Commits

Author SHA1 Message Date
ec15e2b9cc Merge branch 'master' into dont-filter-results-on-sort-mode 2023-03-06 17:57:47 +01:00
87d0bef313 Use nullable comparison helper method instead of manual implementation 2023-03-06 15:16:32 +09:00
60cdd3c070 Clear components sidebar unconditionally on every target change
Fixes the working layer dropdown lingering after exiting from a
skinnable screen to a non-skinnable one.
2023-03-04 14:10:05 +01:00
d233f3a3ab Show non-skinnable screen placeholder at higher level 2023-03-04 13:49:10 +01:00
49e298e304 Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer
An end result of #22674 is that `SkinBlueprintContainer`s are only ever
created by supplying a `SkinComponentsContainer` to them. However,
`SkinBlueprintContainer` still contained remnants of code that suggested
it was designed to handle cases where more than the drawable supplied to
it contained more than one `ISerialisableDrawableContainer`, or even
zero.

The zero path is totally dead right now (because every
`SkinComponentsContainer` is *by necessity* an
`ISerialisableDrawableContainer`), and the more-than-one path is dead
*for now* (and potentially forever?). Therefore, just hard-couple
`SkinBlueprintContainer` to receive a single target container.
2023-03-04 13:33:21 +01:00
2f25fb4083 Move NonSkinnableScreenPlaceholder to outer scope 2023-03-04 13:22:43 +01:00
15409b9c15 Fix skin selection not clearing on exit to non-skinnable screen 2023-03-04 13:18:34 +01:00
82293c0c86 Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.

In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
af540de69b Fix "talking with" text overflowing when usernames are too long 2023-03-01 22:10:15 -08:00
bd11d5d29a Merge pull request #22743 from Joehuu/scroll-back-to-previous
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
31f58a33ac Use ColourInfo.Interpolate where possible 2023-02-28 18:47:27 +03:00
89e20a7962 Update resources 2023-02-28 14:47:51 +09:00
bd1460a8d5 Update framework 2023-02-28 14:32:58 +09:00
92edb0f868 Merge branch 'master' into skin-editor-depth-changing 2023-02-27 19:24:53 +01:00
fa710ae1b0 Rename ScrollToTopButton to ScrollBackButton 2023-02-26 14:39:34 -08:00
dc00905f8d Add ability to scroll back to previous position after scrolling to top via button on overlays 2023-02-26 14:38:51 -08:00
dc3c1150b8 Set better defaults for SkinBlueprint transforms 2023-02-23 21:10:15 +09:00
c48aceb055 Fix undo history not being batched correctly for depth change operations 2023-02-23 20:03:36 +09:00
d679703fa2 Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
a8c692a215 Merge pull request #22635 from peppy/use-overlays-container-more
Use `Overlays` container rather than `KeyBindingInputManager` for flashlight
2023-02-22 18:30:21 +09:00
16c8a392a1 Add ability to send selected skin components to front or back 2023-02-22 18:17:20 +09:00
051eb18b33 Merge branch 'master' into skin-editor-layer-select 2023-02-21 21:38:51 +01:00
ab97b02235 Remove contradictory remark from xmldoc 2023-02-21 21:05:46 +01:00
3d2fcb0cca Merge branch 'master' into fix-taiko-drum-nested-sample-detection 2023-02-21 20:53:06 +01:00
ec1bf7b0b2 Merge branch 'master' into skin-editor-clipboard 2023-02-21 19:35:58 +01:00
9384687d6d Switch ModMuted to add its metronome to components rather than overlays 2023-02-21 19:04:06 +09:00
1acc536248 Move DrawableRuleset.Audio to a less generic level 2023-02-21 19:03:52 +09:00
af062e7a68 Change placeComponent to only add to selection, not clear an existing selection 2023-02-21 14:11:18 +09:00
5ba6059911 Merge branch 'master' into fix-taiko-drum-nested-sample-detection 2023-02-21 13:58:15 +09:00
0d229d959b Remove unnecessary TriggerChange call 2023-02-21 13:50:19 +09:00
6799492596 Merge branch 'master' into skin-editor-layer-select 2023-02-20 21:33:48 +01:00
86a7f4dfd0 Do not serialise SkinLayoutInfo.AllDrawables
- It is entirely derived from `SkinLayoutInfo.DrawableInfo`, which is
  the actual primary thing we want to serialise.
- It will never get read out from any serialised files anyway (corollary
  of the previous point - it is a get-only property derived from another).
- It is only used in tests.

All of the three reasons above make serialising the property out to skin
files nothing more than a waste of space.
2023-02-20 20:37:48 +01:00
c9999bdeb1 Merge branch 'master' into skin-per-ruleset-layouts 2023-02-20 20:14:38 +01:00
43724472c4 Clarify comment to avoid playing pronoun game 2023-02-20 20:09:24 +01:00
6382314af1 Merge pull request #22697 from ggliv/tablet-area-drag
Allow tablet area to be dragged
2023-02-20 23:37:25 +09:00
43d33d45ca Only add valid placed components to selected collection on paste 2023-02-20 20:02:43 +09:00
b68562b033 Make placeComponent resilient to missing dependencies 2023-02-20 20:00:12 +09:00
a9c7edd087 Remove copy pasted comment 2023-02-20 19:57:16 +09:00
7a585e1fa1 Merge pull request #22669 from EVAST9919/mod-overlay-triangles
Add triangles animation to mod select overlay headers
2023-02-20 19:54:21 +09:00
ec12186d63 Remove unnecesasry null check on content 2023-02-20 19:53:04 +09:00
18700b4daa Add note about skin migrations being on read and remove an older deprecation notice 2023-02-20 19:51:54 +09:00
1629c86b5d Mark constant identifier as non-localisable
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-20 19:48:39 +09:00
0ddda018fd Add xmldoc for SkinComponentsContainerLookup.Ruleset
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-20 19:48:18 +09:00
5f7a6d13c3 Remove unused GetSerialisableIdentifier for now 2023-02-20 19:47:17 +09:00
c86c1a9029 allow tablet area to be dragged 2023-02-20 00:06:20 -05:00
3183f5cee2 Merge branch 'master' into revert-result-in-playfield 2023-02-19 16:33:10 +01:00
1ba1298850 Merge branch 'master' into blueprint-improve-visuals 2023-02-19 15:55:30 +01:00
d7381b762c Also tween origin position 2023-02-19 23:52:21 +09:00
d9ca7102f0 Use more generic wording for future-proofing 2023-02-19 15:06:40 +01:00
aac32a2c9f Combine config and time checks into one
Functionally equivalent right now, but the combined variant is more
localised to what it actually needs to do, and less error-prone if
any new code gets appended to the method.
2023-02-19 13:14:51 +01:00