Commit Graph

32803 Commits

Author SHA1 Message Date
1677f1d696 Merge branch 'master' into results-screen-scaling 2022-05-09 11:11:55 +03:00
2f3ac61b47 Revert "Replace vertical scrolling in results screen with size-preserving container"
This reverts commit 298c2a1828.
2022-05-09 10:35:14 +03:00
422531d8ec Revert "Remove no longer required constant"
This reverts commit 6f4cdccf6c.
2022-05-09 10:35:13 +03:00
3407a299ef Revert "Revert scale locking changes for now"
This reverts commit e4521b1fff.
2022-05-09 10:35:12 +03:00
e4521b1fff Revert scale locking changes for now 2022-05-09 10:16:57 +03:00
bf9384b7fe Merge pull request #18124 from ThePooN/sentry-new-dsn
🔧 Update Sentry DSN
2022-05-09 15:40:35 +09:00
6aff531014 Merge pull request #18157 from bdach/mod-overlay/empty-columns
Hide empty columns on new mod select design
2022-05-09 14:59:18 +09:00
3b4fdf20f9 Prevent throwing exceptions on first run without internet 2022-05-09 12:15:54 +09:00
0d0d999199 Merge pull request #18147 from ekrctb/fix-catch-per-hit-object-slider-velocity
Fix per-hit object slider velocity ignored in osu!catch
2022-05-09 11:17:25 +09:00
d964b4f23c Fix uneven spacing when some mod columns are hidden 2022-05-08 15:40:21 +02:00
6bdcf893b7 Move alpha management closer to screen level
Felt bad messing with alpha at the column level.
2022-05-08 15:40:10 +02:00
6f4cdccf6c Remove no longer required constant 2022-05-08 16:20:26 +03:00
7f1ad149d5 Remove no longer necessary horizontal scroll blocker 2022-05-08 16:04:24 +03:00
298c2a1828 Replace vertical scrolling in results screen with size-preserving container 2022-05-08 16:03:57 +03:00
92ccec20d7 Hide mod columns if all mods within are filtered out 2022-05-08 14:53:59 +02:00
dcf0d5a9d5 Fix slider velocity wrongly decoded as scrolling speed in osu!catch 2022-05-08 21:49:42 +09:00
b8cb2c1b82 Increase scroll amount slightly 2022-05-08 19:57:03 +09:00
778497b9e2 Scroll mod select slightly into view on first display 2022-05-08 18:58:54 +09:00
b92d95a17a Fix mod panels playing samples when hidden at a higher level 2022-05-08 10:39:49 +02:00
81ca534f87 Implement ISamplePlaybackDisabler in mod select 2022-05-08 10:39:49 +02:00
cbd1169495 Move cache declarations of ISamplePlaybackDisabler to interface 2022-05-08 10:38:58 +02:00
9ae019eb39 Move ISamplePlaybackDisabler to more general namespace 2022-05-08 10:38:58 +02:00
3eeedd8024 Fix per-hit object slider velocity ignored in osu!catch 2022-05-08 13:45:21 +09:00
230c4e27b8 Simplify and centralise hiding logic for mod overlay
Behaviourally, this also always toggles via button triggering to add the
button flash animation.
2022-05-08 13:03:28 +09:00
dabe295196 Merge pull request #18141 from bdach/mod-overlay/multiple-instance-loop
Fix toggling mods after exiting first run setup overlay at UI scale step causing stack overflow
2022-05-08 12:36:06 +09:00
a45ca2ad10 Fix focused overlays not registering as such
Also fixes bug wherein opening skin editor at song select with mod
select open would show mod select on top of the skin editor.
2022-05-07 22:50:14 +02:00
46d3220c07 Isolate sample screens from global mods bindable
Fixes scenario wherein entering the first run setup overlay, exiting at
the "UI scale" step (which shows a song select), then moving to actua
song select and trying to select a mod would lead to a crash.

The crash was caused by two active mod screen instances attempting to
swap the global mod bindable's mod instances for ones they owned. This
logic - while generally problematic and hard to maintain - was fixing
several issues with mod reference management and setting copying, so I'm
letting it live another day.

This change will mean that the song select preview on the "UI scale"
step will not receive the same mods that the actual game has enabled.
That said, it already doesn't use the same beatmap or ruleset, so this
looks fine to break.
2022-05-07 21:44:58 +02:00
2278da563e Add various xmldoc for nested classes 2022-05-08 02:03:28 +09:00
03c80d9197 Reorder methods / properties in ModSelectScreen for legibility 2022-05-08 01:58:37 +09:00
1d27ef18dc Add xmldoc for IsValidMod 2022-05-08 01:49:29 +09:00
0d32bf91eb Hardcode hide key handling in ModSelectScreen 2022-05-08 01:35:11 +09:00
0c2b4a6c0b Fix invalid IsLoaded check
Would fail when `availableMods` would be changed from a different thread
while the columns aren't loaded.
2022-05-07 15:44:22 +02:00
528342411e Merge branch 'master' into mod-overlay/integration 2022-05-07 13:52:19 +02:00
fe69bd7ed9 Merge branch 'master' into change-mod-scroll-behaviour 2022-05-07 13:29:02 +02:00
9a56f6db44 Merge branch 'mod-overlay/back-button' into mod-overlay/integration 2022-05-07 13:15:13 +02:00
a716f62a6a Flash back button when keyboard back binding is pressed 2022-05-07 13:01:36 +02:00
d4c9de8596 Move button width in mod select to constant 2022-05-07 13:23:48 +03:00
9a7aeec098 Merge branch 'master' into mod-overlay/back-button 2022-05-07 13:05:25 +03:00
8ee3fdd0aa Change mod scrolling behaviour to not scroll horizontally on columns/settings 2022-05-07 12:15:11 +03:00
a44e21d1b2 Merge branch 'master' into mod-overlay/localisation-strings 2022-05-07 12:13:28 +03:00
fd75963ca2 Dismiss mod select if select binding is pressed 2022-05-07 11:01:05 +02:00
e7e7486a8e Merge branch 'mod-overlay/back-button' into mod-overlay/integration 2022-05-07 10:59:30 +02:00
b72cf4cd5d Merge branch 'mod-overlay/localisation-strings' into mod-overlay/back-button 2022-05-07 10:58:09 +02:00
f761d4d4d4 Reuse "select/deselect all" localisable string on column toggle 2022-05-07 10:56:03 +02:00
fa0a256f48 Add localisable string for difficulty multiplier display 2022-05-07 10:48:15 +02:00
db04bcf1ce Merge branch 'master' into distance-snap-grid-current-tiume 2022-05-07 11:47:38 +03:00
271d64fd54 Add back button to mod select overlays 2022-05-07 10:17:32 +02:00
6ad990dfc3 Add basic localisation strings for new mod select 2022-05-07 10:17:24 +02:00
4ff96f82be Dim other buttons if customisation panel is open 2022-05-07 09:50:09 +02:00
18e4c3ed0f Update mod columns even if they're not present/offscreen
Important to make "select/deselect all" operations work on all columns
simultaneously, even if they're offscreen. Unfortunately by the nature
of how the existing selection animation works, it is hard-tied to the
update loop, so we need to compensate.
2022-05-07 09:50:09 +02:00