26d88aa326
Fix intermittent MusicController tests
2022-07-08 14:29:15 +09:00
0bc332e90b
Merge pull request #19029 from peppy/fix-skin-import-duplicate
...
Fix skins potentially being duplicated on batch import
2022-07-08 14:18:14 +09:00
84dcd042f4
Protect duration calculations against unstable fps
2022-07-07 20:30:31 -07:00
89f1c75f7a
Update mod icon colors
2022-07-07 21:57:18 -05:00
1e159eb328
Add back fade to black duration
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com >
2022-07-08 10:43:50 +09:00
63a06afab2
Add missing license header
2022-07-08 01:59:27 +03:00
67fa15f231
Remove no longer required context menu container in ParticipantsList
2022-07-08 01:42:55 +03:00
7b08501eaf
Cover online-play room screens with context menu containers
2022-07-08 01:42:11 +03:00
1d0f2e359a
Add collection context menu to room playlist items
2022-07-08 01:40:53 +03:00
a94fb62be3
Split collection toggle menu item to own class
2022-07-08 01:39:45 +03:00
e12d3c1858
Merge pull request #19034 from peppy/fix-editor-hash-writing
...
Fix editor saving not updating `BeatmapSetInfo`'s hash
2022-07-08 00:13:29 +03:00
07a08d28c6
Rename parameter and default to 0
2022-07-07 23:31:06 +03:00
c53dd4a703
Fix editor saving not updating BeatmapSetInfo's hash
2022-07-08 02:33:14 +09:00
15d070668d
Move intro screen background to base implementation and use colour fading
2022-07-08 02:12:01 +09:00
216150b52d
Avoid always loading new background at MainMenu
...
This was meant to be an optimisation to allow the background to load
while the intro is playing, but as the current default intro loads a
background itself, this was rarely the case and also counter-productive
as it would bypass the equality check and start a second load sequence.
2022-07-08 02:12:01 +09:00
789904ccd1
Avoid reloading background unnecessariyl when not yet loaded
2022-07-08 02:12:01 +09:00
b83073c2e9
Fix SeasonalBackgroundLoader triggering a background reload when not providing backgrounds
2022-07-08 02:12:01 +09:00
0d25b63769
Merge pull request #19030 from peppy/simplify-connection-error-message
...
Simplify error output when hub cannot connect
2022-07-07 19:37:46 +03:00
f500d5ade6
Simplify error output when hub cannot connect
...
Full call stack is useless in these cases.
Before:
```csharp
[network] 2022-07-07 16:05:31 [verbose]: OnlineMetadataClient connection error: System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (Forbidden).
[network] 2022-07-07 16:05:31 [verbose]: at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
[network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.NegotiateAsync(Uri url, HttpClient httpClient, ILogger logger, CancellationToken cancellationToken)
[network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.GetNegotiationResponseAsync(Uri uri, CancellationToken cancellationToken)
[network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.SelectAndStartTransport(TransferFormat transferFormat, CancellationToken cancellationToken)
[network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.StartAsyncCore(TransferFormat transferFormat, CancellationToken cancellationToken)
[network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.StartAsync(TransferFormat transferFormat, CancellationToken cancellationToken)
[network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionFactory.ConnectAsync(EndPoint endPoint, CancellationToken cancellationToken)
[network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionFactory.ConnectAsync(EndPoint endPoint, CancellationToken cancellationToken)
[network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.SignalR.Client.HubConnection.StartAsyncCore(CancellationToken cancellationToken)
[network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.SignalR.Client.HubConnection.StartAsyncInner(CancellationToken cancellationToken)
[network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.SignalR.Client.HubConnection.StartAsync(CancellationToken cancellationToken)
[network] 2022-07-07 16:05:31 [verbose]: at osu.Game.Online.HubClientConnector.connect() in /Users/dean/Projects/osu/osu.Game/Online/HubClientConnector.cs:line 119
```
After:
```csharp
[network] 2022-07-07 16:06:59 [verbose]: OnlineMetadataClient connecting...
[network] 2022-07-07 16:06:59 [verbose]: OnlineMetadataClient connect attempt failed: Response status code does not indicate success: 403 (Forbidden).
```
2022-07-08 01:06:40 +09:00
cd4755fbd9
Add test coverage for batch-import path
2022-07-07 18:06:35 +03:00
b661ad26ef
Merge pull request #19009 from peppy/metadata-client
...
Add `MetadataClient` to handle online metadata changes
2022-07-07 23:33:30 +09:00
cf1da1dd18
Fix skins potentially being duplicated on batch import
...
Resolves https://github.com/ppy/osu/discussions/19024#discussioncomment-3099200
2022-07-07 22:39:07 +09:00
f109e510ce
Merge branch 'master' into metadata-client
2022-07-07 19:45:52 +09:00
7086779cf4
Merge pull request #19026 from peppy/async-track-operations
...
Use fire-and-forget async operations on global track
2022-07-07 19:45:03 +09:00
5e3c6d6e56
Merge pull request #19028 from peppy/add-skin-keyword
...
Allow searching for "skins" to find current skin setting
2022-07-07 19:40:23 +09:00
c8b05a5ef2
Merge pull request #19027 from peppy/realm-nested-writes
...
Add nested transaction handling to realm helper methods
2022-07-07 19:40:08 +09:00
d88fd8a5b0
Allow searching for "skins" to find current skin setting
2022-07-07 18:26:04 +09:00
bf10f2db2e
Add test coverage of nested rollback for good measure
2022-07-07 18:19:01 +09:00
ac216d94a8
Fix transaction not being disposed
2022-07-07 18:15:38 +09:00
b5c703b62c
Remove unused using statement
2022-07-07 17:59:55 +09:00
dd5b127fb5
Update various tests to enable NRT to avoid new inspection failures
2022-07-07 17:51:49 +09:00
57b2f8189c
Add back test workaround for TestScenePlayerScoreSubmission with updated explanation
...
This reverts commit f88e2aa025
2022-07-07 17:42:03 +09:00
e2c4c94993
Simplify BeatmapUpdater transaction handling using nested transaction support
2022-07-07 17:37:46 +09:00
79bed0abdf
Merge branch 'realm-nested-writes' into metadata-client
2022-07-07 17:37:06 +09:00
5197d0fa9e
Add automatic transaction handling to realm helper methods
2022-07-07 17:36:25 +09:00
d4c539687e
Merge pull request #19022 from peppy/better-file-loading-exceptions
...
Add local handling of cases where a beatmap's file cannot be found on disk
2022-07-07 17:21:19 +09:00
7ef03dd2cb
Use fire-and-forget async operations on global track
...
This avoids any blocking overhead caused by a backlogged audio thread.
Test seem to pass so might be okay?
Note that order is still guaranteed due to the `ensureUpdateThread`
queueing system framework-side.
2022-07-07 17:15:45 +09:00
45c5b7e7dd
Update framework
2022-07-07 17:13:16 +09:00
2eba38ca88
Merge pull request #19007 from goodtrailer/fix-rewind-spinner-accent
...
Fix default spinner's accent on rewind in user replays
2022-07-07 17:13:08 +09:00
6660379a0e
TAIKO-6 Tweak encoding and parameters, reduce rhythm weight
2022-07-07 16:04:46 +08:00
b663986b9f
Add test coverage of locally available without replay button handling
2022-07-07 17:04:04 +09:00
461d133c1f
Add test coverage of score importing
2022-07-07 16:43:31 +09:00
1a41d3ef20
Allow PlayerTestScene to import the beatmap it's using
2022-07-07 16:42:36 +09:00
65829d8feb
Merge pull request #19023 from peppy/fix-convert-custom-rulesets
...
Fix song select placeholder not showing convert hint for custom rulesets
2022-07-07 16:19:20 +09:00
f88e2aa025
Remove EF test workaround
2022-07-07 15:02:03 +09:00
9d730f8440
Fix custom rulesets not importing scores at all
...
Replaces the error with the ability to import, minus replays.
Closes https://github.com/ppy/osu/issues/17350 (arguably, but let's go with it for now).
2022-07-07 14:49:23 +09:00
e1b434b5dc
Fix song select placeholder not showing convert hint for custom rulesets
2022-07-07 14:46:51 +09:00
e81cebf27d
Change storyboard parsing logic to not completely fail if only .osb read fails
...
Changes to allow the storyboard to exist if only the `.osu` is
available. Reads better IMO.
2022-07-07 14:33:20 +09:00
c4b6893709
Add local handling of cases where a beatmap's file cannot be found on disk
2022-07-07 14:29:19 +09:00
e5dd7b1654
Merge pull request #19021 from frenzibyte/fix-flaky-tests-envvar
...
Fix flaky tests not running at all with environment variable set
2022-07-07 10:56:38 +09:00
