Commit Graph

5314 Commits

Author SHA1 Message Date
3600b0daf0 Merge branch 'master' into fix-mod-select-overflowing 2020-02-04 11:57:54 +09:00
22e3150f68 Fix comment and remove magic numbers 2020-02-03 17:21:06 -08:00
c6e7603e5e Merge branch 'master' into safe-screen-lease 2020-02-03 18:18:13 +09:00
93952d438f Merge pull request #7677 from peppy/decouple-mod-select-bindable
Decouple ModSelectOverlay from global SelectedMods
2020-02-03 16:27:47 +09:00
591c7b6250 Merge pull request #7682 from peppy/fix-timeline-tick-overrun
Fix too many ticks being displayed on beatmaps with multiple timing sections
2020-02-03 16:16:23 +09:00
9183c78319 Fix crash on exiting song select with ctrl-enter autoplay 2020-02-03 16:04:32 +09:00
aa1daa0ad5 Merge pull request #7703 from bdach/beatmap-stats-precision
Apply precision when determining bar colour in difficulty statistics
2020-02-02 22:31:52 +09:00
434c0d92e4 Use Bindable{Float,Double}s everywhere
To avoid further floating-point comparison bugs, remove all usages of
Bindable<{float,double}>, replacing them with their
Bindable<Float,Double> counterparts.
2020-02-01 22:50:29 +01:00
e894acf53c Make star filter range bindables BindableDoubles
Due to using Bindable<double>s previously, song select's filter control
would not apply tolerance when checking IsDefault, therefore wrongly
hiding maps with star ratings above 10.1.
2020-02-01 22:48:46 +01:00
609ee26030 Fix mod select overlay not showing up in test 2020-02-01 11:41:41 -08:00
2d42a83bb9 Fix mod select overlay overflowing toolbar at max ui scale 2020-02-01 11:24:29 -08:00
0bfadfbbf1 Apply precision when comparing adjusted values
In some cases, applying the Difficulty Adjust mod without actually
changing any of the settings previously caused the bar in song select
beatmap details to appear red/blue instead of staying white.

This was caused by not accounting for floating-point imprecisions when
determining bar colour in AdvancedStats. To resolve, first check
equality with tolerance, and only then apply blue/red colours if that
equality check does not hold.
2020-02-01 16:16:15 +01:00
a74d22d9e5 Extract beatmap stats test to separate scene 2020-02-01 15:50:33 +01:00
ed368e44ea Merge branch 'master' into safe-screen-lease 2020-02-01 02:11:18 +09:00
c5422743e2 Merge branch 'master' into decouple-mod-select-bindable 2020-02-01 02:06:23 +09:00
90caa61245 Reverse comparison for readability
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-02-01 02:05:26 +09:00
a66cdee5e9 Fix missed issues 2020-01-31 21:36:19 +09:00
19f516e710 Ensure OsuScreen level leases are taken out synchronously 2020-01-31 19:10:44 +09:00
a547d2ed5c Don't least at Player just yet 2020-01-31 18:37:16 +09:00
2f61d3f5ad Fix song select remaining issue locally 2020-01-31 17:35:53 +09:00
5f48affcba Centralise screen exit logic to ScreenTestScene 2020-01-31 14:19:29 +09:00
f51cfa2220 Fix too many ticks being displayed on beatmaps with multiple timing sections
Closes https://github.com/ppy/osu/issues/7681.
2020-01-31 00:24:00 +09:00
7bf2e9b369 Decouple ModSelectOverlay from global SelectedMods 2020-01-30 17:38:15 +09:00
09f6c57b0f Merge branch 'master' into fix-import-different-ruleset 2020-01-30 15:08:25 +09:00
c18b1b302c Merge branch 'master' into editor-match-accessibility 2020-01-30 13:49:56 +09:00
c158570249 Fix typo in comment
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-01-30 11:31:34 +09:00
f72de235cc Remove unnecessary length specifications 2020-01-30 11:00:14 +09:00
37ecf8a060 Remove commented line 2020-01-30 10:50:48 +09:00
bea20efb64 Merge branch 'master' into mod_content_centering 2020-01-30 10:34:46 +09:00
f130e48c9e Remove leftover negative margin 2020-01-29 19:17:07 +01:00
c9dda78ded Refactor drawable hierarchy to center properly
* Use FillFlowContainer.Spacing instead of manually applying margins.
* Use Update() for calculating button padding to preserve it after
  mod button expansion and adjust FooterButtonRandom to use this method
  while avoiding flickering.
* Expose mod display margin to clear it in the footer button.
2020-01-29 18:59:51 +01:00
da6952407e Allow null DI 2020-01-29 23:01:57 +09:00
13eb32fea2 Fix editor being accessible for multiplayer song select 2020-01-29 22:20:34 +09:00
76af8bea5d Fix percentage-formatted displays containing a space 2020-01-29 19:51:24 +09:00
7588c574a2 Fix presenting a beatmap from a different ruleset not working 2020-01-29 19:37:54 +09:00
db3e360229 Merge branch 'master' into fix-carousel-missing-import 2020-01-29 18:06:27 +09:00
77c06b1c6e Fix beatmap carousel potentially missing beatmap imports 2020-01-29 17:09:12 +09:00
66b8d38d42 Merge branch 'master' into selection-composition-conformity 2020-01-29 16:52:45 +09:00
e553a9b9e0 Merge branch 'master' into distance-snap-grid-correct-colouring 2020-01-29 16:09:35 +09:00
63501c188a Merge pull request #7644 from peppy/standardise-zoom-levels
Standardise editor timeline zoom across maps of all lengths
2020-01-29 16:04:25 +09:00
018c005c71 Merge branch 'master' into distance-snap-grid-correct-colouring 2020-01-29 15:33:07 +09:00
0d6fd0a54a Merge branch 'master' into standardise-zoom-levels 2020-01-29 15:32:57 +09:00
65ac412ff8 Merge branch 'master' into fix-beat-snap 2020-01-29 15:32:27 +09:00
391681b7af Separate calculation to follow other examples 2020-01-29 15:16:48 +09:00
7d05840ee0 Merge branch 'master' into select-tool 2020-01-29 15:04:22 +09:00
ea2ee53ee3 Merge branch 'master' into timline-beat-lines 2020-01-29 14:44:07 +09:00
9a47428bfd Remove out of date comment 2020-01-29 14:40:42 +09:00
abe0041b65 Merge branch 'master' into select-tool 2020-01-29 14:29:12 +09:00
4d43833db4 Merge branch 'master' into timline-beat-lines 2020-01-29 14:12:00 +09:00
b10143fdf2 Merge branch 'master' into fix-key-count-mod-affect 2020-01-29 14:11:59 +09:00