Commit Graph

51 Commits

Author SHA1 Message Date
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
b978010b48 Remove unused allowMissing parameter in audio file check test
No longer used since 7f95400f46.
2022-02-01 21:53:21 +01:00
4f66e8f881 Fix issues with editor check tests 2022-01-12 16:39:36 +09:00
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
c7bc03e6f7 Add helper method for editor check tests 2021-11-24 14:22:41 +09:00
c2f8d9f677 Update tests which set Files lists directly 2021-11-24 14:00:14 +09:00
72ee2b1556 Refactor to avoid duplicate code 2021-11-10 06:18:40 +01:00
5dc6a9ed21 Add background stream closed test 2021-11-10 05:04:30 +01:00
d1e6d1cb98 Update some other missed incorrect null/empty usages 2021-11-04 14:50:43 +09:00
67d9590a79 Fix new inspections 2021-11-04 14:02:09 +09:00
c7db286b94 Merge branch 'master' into file-sanity-checks 2021-10-14 00:17:29 +02:00
7f95400f46 Add proper stream disposal to tests 2021-10-12 11:04:41 +09:00
bb9cbd3e66 Undo disposal of Stream for use in mocking
Because the Stream object is accessed when the mocked object calls `GetStream`, we cannot close it here.

The resource should be released upon teardown anyway.
2021-10-12 00:35:58 +02:00
47b4d03145 Dispose of Streams when used 2021-10-12 00:13:38 +02:00
01d77fb741 Remove redundant Bass.Init call in test setup 2021-10-11 23:58:06 +02:00
9fae2c350d Fix test regressions 2021-08-30 17:25:36 +09:00
6da2a3d51f Add zero-length objects check and tests 2021-07-13 10:50:11 +02:00
c8f58cbf6c Add audio in video check and tests 2021-07-13 04:17:41 +02:00
a4a1919842 Add too short audio files check and tests 2021-07-13 03:46:45 +02:00
0a8fd01b99 Add zero byte check and tests 2021-07-13 03:45:21 +02:00
b58644106c Add nested hitobject tests for few hitsounds check 2021-06-27 15:58:00 +02:00
1dbac76da5 Use local variables for common sample lists 2021-06-27 15:57:41 +02:00
1d5bff1660 Add concurrent hitobjects test for few hitsounds check
See https://github.com/ppy/osu/pull/13669#discussion_r659314980
2021-06-27 15:26:52 +02:00
c2ceb83bbb Move MockNestedHitObject to own class 2021-06-27 15:16:40 +02:00
5642d321b7 Fix comments in few hitsounds check tests 2021-06-26 23:43:08 +02:00
82b64f5589 Add hitsounded with break test 2021-06-26 19:57:12 +02:00
a5abc664f3 Add few hitsounds check tests 2021-06-26 19:21:15 +02:00
7b9569a117 Add muted object check tests 2021-06-26 19:21:01 +02:00
9069db0743 Fix case of hitObjects variables 2021-05-14 16:22:19 +09:00
9860e482af Use TestWorkingBeatmap instead of null in tests
Fixes the warning that #12801 will give.
2021-05-14 05:32:52 +02:00
94538b3842 Remove accidental whitespace 2021-05-13 12:56:36 +02:00
19800f5f7f Move IBeatmap arg into context 2021-05-13 11:24:22 +02:00
c13b93e6f1 Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.

See next commit for example.
2021-05-12 02:29:18 +02:00
200352b750 Rename unsnap check templates 2021-04-27 13:56:05 +02:00
0f0870c8b8 Sort objects by time in concurrent check test 2021-04-27 00:36:26 +02:00
ce258febf6 Rename CheckUnsnaps -> CheckUnsnappedObjects
Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.

Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.
2021-04-26 20:32:44 +02:00
b8cdcf56c0 Add concurrent object check tests 2021-04-26 20:22:24 +02:00
71f880aa94 Fix duplicate code in unsnap test 2021-04-26 17:44:46 +02:00
9178aa1d7d Add unsnap check tests 2021-04-26 04:48:56 +02:00
c0318a4d3e Fix usage of _ in Moq lambdas 2021-04-20 13:29:14 +02:00
6a1e4ff99f Add file hash to file presence test
Necessary because we now find the storage path of the file rather than just the file itself.
2021-04-20 13:28:32 +02:00
2bb079ea14 Add audio quality check tests 2021-04-20 01:36:15 +02:00
be6a02a17e Simplify background quality test names 2021-04-20 01:32:22 +02:00
8656176ab8 Add the playable beatmap as check argument
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.

So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.

This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
010720de74 Factor out general file presence checking
This allows us to use the same method of checking for other files that should exist, for example the audio file.

By using the same method, they all share test cases too.
2021-04-18 02:07:33 +02:00
0502fbb429 Add background quality check tests 2021-04-18 01:21:51 +02:00
448574e7e6 Use WorkingBeatmap instead of IBeatmap
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.

Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
b45d7de4ec Update asserts to use better nunit specifications 2021-04-13 15:04:01 +09:00
6d3f9fa9ce Use is class instead of Equals with template index
Ensures ordering of `PossibleTemplates` does not affect tests.
2021-04-13 02:29:25 +02:00
0bcc39bd36 Remove redundant space 2021-04-13 02:17:35 +02:00