Commit Graph

30233 Commits

Author SHA1 Message Date
2bf6b55b19 Fix failing test due to changed reset page logic 2022-01-05 14:53:32 +09:00
5ed69338a6 Add omission of pages when there are too many 2022-01-04 19:05:14 +09:00
86f72b71b1 Prepare tests and general structure to support omission of pages 2022-01-04 18:46:44 +09:00
e75c9519f3 Adjust font weighting on selection 2022-01-04 18:19:23 +09:00
5a11ee7810 Use OverlayColourProvider and fix font weight 2022-01-04 18:14:42 +09:00
ee4f5c0e79 Rename button classes to make more sense 2022-01-04 17:52:40 +09:00
db58f5de8e Clean up unnecessary complexity 2022-01-04 17:51:37 +09:00
1c899e4402 Fix post-merge issues 2022-01-04 16:46:42 +09:00
69e7ee0f48 Merge branch 'master' into page-selector 2022-01-04 16:44:22 +09:00
39650ce7e9 Merge pull request #16307 from peppy/beatmap-listing-bottom-padding
Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds
2022-01-04 14:14:42 +09:00
374dac57f2 Change expanded card content height to 200 2022-01-04 13:22:00 +09:00
f6b1405fa0 Merge branch 'master' into fix-listing-terminal-breakage 2022-01-04 11:49:02 +09:00
87fbac15fd Merge branch 'master' into fix-skin-editor-overlay-show-thread-safetyu 2022-01-03 20:12:18 +01:00
de33b420ab Add safety against performing operation on non-alive foundContent 2022-01-03 20:02:46 +01:00
586f158920 Remove initial foundContent value
It always is replaced on the first search anyway, and just remains
forever in the overlay otherwise.
2022-01-03 19:52:42 +01:00
6650a468e0 Fix and simplify very broken beatmap listing content swap-out logic
The beatmap listing content swap-out logic was already a source of
several problems, and several attempts of fixing it were made. But as it
turns out it was terminally broken in several aspects.

* The `BypassAutoSizeAxes` juggling was finicky and ugly, and didn't
  really look much different than an instant fade. Therefore, all fade
  durations and manipulations of `BypassAutoSizeAxes` are removed.

* The transform sequence juggling the `BypassAutoSizeAxes` manipulations
  was enqueued on the content which is being in the process of fading
  out. That was partially fixed in 25e38560, but as it turns out, that
  only works if `lastContent` is one of the two placeholder drawables
  (results not found / supporter required to use filter).

  It would not work if `lastContent` is a
  `ReverseChildIDFillFlowContainer` with cards from a previous search in
  it.
2022-01-03 19:51:46 +01:00
ef9f56e585 Fix bad check if content is placeholder
The `lastContent == foundContent` check, last touched in a49a4329, is
terminally broken, as it would always be false. `foundContent` is
mutated when a new card load task is started in `onSearchFinished()`,
which is *before* the aforementioned check.

The code prior to a49a4329 was checking against the two static reused
placeholder drawables which was the correct check to apply, and this
commit reverts to using a variant of that check.
2022-01-03 19:51:20 +01:00
97439c3df1 Rename method to reflect what it actually does 2022-01-03 19:30:17 +01:00
7c246670b4 Add padding to bottom of spotlights ranking view to avoid hovered panels exceeding visible bounds 2022-01-03 18:43:20 +01:00
0ad555e9f7 Remove surplus blank line 2022-01-03 18:33:32 +01:00
b9851b278d Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds
Closes https://github.com/ppy/osu/issues/16120.
2022-01-03 13:18:28 +09:00
6356180b6a Remove unnecessary code and fix double nesting causing filtering to not work 2022-01-03 12:53:58 +09:00
623d6d6d2d Add migration of positional hitsounds setting to new level based setting 2022-01-03 12:46:20 +09:00
5dd024aab7 Remove outdated settings migration 2022-01-03 12:46:02 +09:00
bb54f438aa Merge branch 'master' into positional-sounds-strength-adjustment 2022-01-03 12:40:56 +09:00
e7d7587ea5 Merge branch 'master' into reduce-chat-overhead 2022-01-01 15:02:55 +01:00
1262e76a58 Fix test failure due to missing DI cached IdleTracker 2021-12-31 23:18:03 +09:00
670a30b64b Remove usage of .Result in ArchiveReader 2021-12-31 01:52:01 +09:00
089b756f93 Invert logic to make reading easier 2021-12-30 16:03:16 +09:00
ef49f2ed0e Add extra extra safety against attempting to load a previously expired editor 2021-12-30 16:02:31 +09:00
b1a444180f Fix Show then Reset potentially resulting in incorrect load target 2021-12-29 21:46:34 +09:00
471eea750a Fix calling SkinEditorOverlay.Show before the overlay is loaded causing an exception
As seen at https://github.com/ppy/osu/runs/4652969942?check_suite_focus=true.
2021-12-29 21:18:17 +09:00
63e0492725 Mark ShouldSerialize() methods as implicitly used 2021-12-28 09:02:03 +01:00
bc39c2a877 Revert incorrect property rename 2021-12-28 08:31:27 +01:00
73dca0c7e3 Merge pull request #16266 from Joehuu/fix-identifier-typos
Fix and normalise most identifier names in code
2021-12-28 15:21:42 +09:00
0bd928b5cd Fix incorrect naming / apply review 2021-12-27 21:44:19 -08:00
5082b0e63f Fix some identifiers using shortened naming 2021-12-27 20:26:28 -08:00
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
98524d60a4 Fix clear identifier typos 2021-12-27 20:26:28 -08:00
eb04cc9213 Update framework 2021-12-27 23:04:10 +09:00
8d927920cb Add comment explainng why to block idle updates when host is not active 2021-12-27 13:31:07 +09:00
5a591713ae Fix legacy combo counter not fully hiding for rulesets that implement their own 2021-12-26 16:49:20 +01:00
724b601d2a Rename AllowSampleLookup argument to something saner 2021-12-26 14:29:07 +01:00
dc21c8901e Always allow looking up storyboard samples from beatmap skin 2021-12-26 14:25:28 +01:00
7c25ce81e1 Further reduce chat poll rate when idle or not visible 2021-12-26 16:26:47 +09:00
e448c28cad Change IdleHandler to not consider mouse movement as active unless focused 2021-12-26 16:26:33 +09:00
8ad53138a6 Merge pull request #16234 from smoogipoo/fix-initial-button-colour
Fix OsuAnimatedButton animating when initially disabled
2021-12-25 15:34:40 +09:00
957a1648c7 Merge pull request #16237 from smoogipoo/fix-finished-play-exception-2
Improve reliability of exiting gameplay in multiplayer
2021-12-25 15:32:14 +09:00
ac1a452e20 Merge pull request #16239 from peppy/sanitise-test-directory-usage
Fix some more test directory usage weirdness
2021-12-25 12:09:18 +09:00
7088471cad Protect against test failures due to logger being set too early (and beginning logging) 2021-12-25 02:21:49 +09:00