Commit Graph

108 Commits

Author SHA1 Message Date
42eafe318c Remove various simple obsoletions 2022-10-28 13:20:58 +09:00
4f298db066 fix(osu.Game): reset Y axis of the bars in hit distribution graph at the first drawing 2022-09-12 16:25:29 +09:00
0d0e2e7bcc fix(osu.Game): bars in hit distribution graph stretching in the opposite direction when DrawHeight is less than DrawWidth 2022-09-12 16:20:33 +09:00
96951057df Avoid using bindables 2022-09-12 15:56:06 +09:00
bcd2445d9b Move helper functions down in file 2022-09-12 15:50:10 +09:00
0755289ec3 Apply NRT to HitEventTimingDistributionGraph 2022-09-12 15:48:50 +09:00
ac324c63e2 fix(osu.Game): handle size changes in timing distribution graph 2022-09-12 04:46:32 +09:00
c6521e4c72 Rename ordering helper method 2022-09-08 17:50:27 +09:00
267465df18 chore(osu.Game): combine Osu.Colour.{Draw,Text}ForHitResult into OsuColour.ForHitResult 2022-09-07 23:34:46 +09:00
b560b6f745 refactor(osu.Game): arrange the code for the timing distribution graph 2022-09-07 23:29:10 +09:00
99ef0c95fe Simplify children assignment 2022-09-07 16:51:51 +09:00
3003fc1061 refactor(osu.Game): improve code quality 2022-09-07 02:29:15 +09:00
b109e5de6c chore(osu.Game): align height of bars on timing distribution graph to basalHeight first and combine their transitions into each one 2022-09-06 00:04:10 +09:00
7e77c9e8b4 chore(osu.Game): only the first result should be white at zero position on HitEventTimingDistributionGraph 2022-09-05 04:44:27 +09:00
b67fd3d880 chore(osu.Game): split transform duration of bars on HitTimingDistributionGraph 2022-09-05 03:45:51 +09:00
0af6b3dc0f chore(osu.Game): colorize bars by OD on HitEventTimingDistributionGraph 2022-09-05 02:02:38 +09:00
29ef1c8db8 Check if StatisticItem.Name is null or empty 2022-08-20 21:48:53 -04:00
9386d352b8 Make StatisticItem.Name not nullable 2022-08-20 21:48:35 -04:00
d06959e1dd Update incorrect xmldoc 2022-08-17 22:03:35 +02:00
18ce784ae0 Allow StatisticItem's name param to be nullable 2022-08-14 14:51:35 -04:00
6e13cf82e8 Don't render statistic header if display string is null 2022-08-10 16:05:34 -04:00
8cb2e11766 Change most ruleset-accessible string types to Localisable strings 2022-08-10 15:51:11 -04:00
99bdf41717 Avoid potential realm fetch after disposal in StatisticsPanel
As seen at https://github.com/ppy/osu/runs/7513799859?check_suite_focus=true.
2022-07-26 15:12:23 +09:00
6ce8e74e6b Add panel appearance sounds 2022-07-22 21:03:46 +09:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
06512e8bd9 Use const for minimum height specification in final usage location
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-06 01:01:22 +09:00
f8ef352306 Don't consider judgements beneath the minimum height as being applicable
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-06 01:00:47 +09:00
5a164e4520 Hide adjustment when no adjustment is applied 2022-03-04 15:19:55 +09:00
8c7b1e0aa8 Only construct the adjustment portion of bars when required 2022-03-04 15:01:54 +09:00
2785218b79 Only apply animation if the bar is going to be larger than the minimum height 2022-03-04 14:59:53 +09:00
540d7d0e2c Add the ability to set and show an offset value on timing distribution graph 2022-03-04 14:36:15 +09:00
d3e04fe594 Colour centre bin in distribution graph differently 2022-03-04 14:09:27 +09:00
c063a73742 Fix autosize weirdness by specifying a constant size for the x axis 2022-03-04 14:05:42 +09:00
010fa7ed01 Allow an offset to be shown on the timing distribution graph 2022-03-04 14:05:42 +09:00
835cb09537 Merge branch 'master' into fix-hit-distribution-rounding 2022-03-04 12:43:57 +09:00
8b504bb5ac Ensure rounding is still applied in non-midpoint cases 2022-03-04 12:42:07 +09:00
a06d806fb9 Fix hit distribution graph midpoint rounding not looking great around zero
Not sure this will be accepted and it's likely only ever going to show
in tests, but seems to be a better approach to midpoint rounding for
this case?
2022-03-03 15:43:02 +09:00
ab0ee26540 Remove padding from distribution graph bars to fix some bars becoming invisible at low sizes 2022-03-03 15:13:42 +09:00
a41e1c80f1 Show hit error on results screen
Leading up to implementation of "local offset", this feels like a good
thing to have visible first and foremost.
2022-02-28 19:11:06 +09:00
10bdb7240f Pre-check for divisor zero and add explanation 2022-02-08 14:36:29 +08:00
0b1fef38af Use the playable beatmap provided in CreateStatisticsForScore 2022-02-05 21:36:34 +08:00
2e1a9f1379 Add performance breakdown as statistic item in extended statistics panel 2022-02-05 21:13:16 +08:00
47d577ec9c Add back constructor for ruleset compatibility 2022-02-03 19:17:56 +09:00
6974c2d255 Remove weird panelIsComplete flag and replace LINQ with simple foreach 2022-02-03 19:00:03 +09:00
aff36d4e16 Refactor populateStatistics to avoid disposing 2022-02-03 11:52:37 +08:00
19eb9ad8a7 Reorder StatisticsItem constructor to make a touch more sense 2022-02-02 23:02:38 +09:00
3c2a6fe208 Don't prompt for a replay if no item requires hit events 2022-02-02 19:07:14 +08:00
1e19c7046a Use spacing instead of bottom margin 2022-02-02 19:02:29 +08:00
b0023b9809 Also dispose rows 2022-02-02 19:00:46 +08:00