7f3c8ad744
Merge pull request #10872 from smoogipoo/fix-missing-triangles
2020-11-19 14:11:08 +09:00
5156de3a10
Merge branch 'master' into fix-judgement-transform-logic
2020-11-18 19:20:11 +01:00
ecd6d09600
Merge pull request #10891 from smoogipoo/remove-obsoletes
...
Remove obsolete method
2020-11-18 23:07:31 +09:00
9f6ca06039
Merge pull request #10889 from peppy/return-null-if-skinnable-sprite-no-exist
...
Fix SkinnableSprite initialising a drawable even when the texture is not available
2020-11-18 21:35:13 +09:00
cb5d1d0d77
Remove obsolete method
2020-11-18 21:26:35 +09:00
8ccb399eff
Merge pull request #10883 from smoogipoo/defined-blueprint-order
2020-11-18 18:46:37 +09:00
bb1aacb360
Fix SkinnableSprite initialising a drawable even when the texture is not available
2020-11-18 18:07:00 +09:00
efc18887c8
Update framework
2020-11-18 18:01:55 +09:00
f00c23b4a0
Add comment + xmldoc
2020-11-18 13:37:15 +09:00
783c172b5d
Make sealed and cleanup comparator
2020-11-18 13:33:22 +09:00
57eaee27ae
Rename param to match type better
2020-11-17 20:12:04 +01:00
875d7dec79
Remove redundant this. qualifier
2020-11-17 20:11:13 +01:00
58c8184ad7
Define blueprint order similarly to hitobjects
2020-11-17 22:56:31 +09:00
dd4b69feab
Add legacy judgement implementation which doesn't transform on animations
2020-11-17 15:46:57 +09:00
8247e6ce91
Move result type to ctor
2020-11-17 15:43:54 +09:00
e4f1e52422
Add xmldoc coverage of Apply()
2020-11-17 15:03:26 +09:00
f465dd5a5e
Move all extended animation logic out of DrawableJudgement
2020-11-17 14:59:34 +09:00
d7b6e4a32d
Merge pull request #10867 from smoogipoo/refactor-user-request
...
Refactor user caching to improve readability and fix threadsafety issues
2020-11-17 14:20:45 +09:00
9dfa4249e0
Make Apply non-virtual
2020-11-17 14:05:13 +09:00
3bcf9c255a
Add Triangles.Reset()
2020-11-17 13:06:30 +09:00
33c643e369
Add obsoletion for unused property
2020-11-17 12:23:34 +09:00
009d666241
Use dictionary to avoid linq overhead
2020-11-17 10:57:11 +09:00
72a8734f93
Merge branch 'master' into add-back-initiallifetimeoffset
2020-11-16 18:54:37 +01:00
e8dbc190f1
Remove ability to pool DHOs in parent playfields
2020-11-16 23:30:24 +09:00
cead67d512
Add back removed InitialLifetimeOffset removal
2020-11-16 21:49:29 +09:00
85b0f71467
Handle duplicate user IDs within the same batch
2020-11-16 21:17:43 +09:00
87bf168718
Use queue instead of list
2020-11-16 20:52:51 +09:00
1b1f4c9c09
Refactor user request to fix threadsafety issues
2020-11-16 20:35:22 +09:00
a98327f0c5
Merge branch 'master' into fix-currentskininfo-thread-safety
2020-11-16 17:55:22 +09:00
09298139e1
Merge pull request #10844 from bdach/spinner-rotation-tracker-state
...
Fix rotation tracker state not being reset on drawable spinner re-use
2020-11-16 17:10:40 +09:00
709370c69b
Move schedule call outwards
2020-11-16 16:49:31 +09:00
9a7fdb2b7e
Move skin deletion logic to OsuGameBase to promote thread safety
...
`CurrentSkinInfo` is used in multiple places expecting thread safety,
while ItemRemoved events are explicitly mentioning they are not thread
safe. As SkinManager itself doesn't have the ability to schedule to the
update thread, I've just moved the logic to `OsuGameBase`. We may want
to move the current skin bindable out of the manager class in the
future to match things like `BeatmapManager`.
Closes https://github.com/ppy/osu/issues/10837 .
2020-11-16 16:43:19 +09:00
6706840b54
Merge pull request #10853 from bdach/add-to-legacy-conversion-tests
2020-11-16 15:22:04 +09:00
baed1573dc
Merge pull request #10838 from nbvdkamp/fix-quick-delete-crash
2020-11-16 14:42:52 +09:00
3dbd7d5654
Merge pull request #10856 from bdach/reset-transforms-on-return-to-pool
...
Clear DrawableHitObject transforms on return to pool
2020-11-16 14:40:38 +09:00
7b79b9b9c1
Merge branch 'master' into fix-quick-delete-crash
2020-11-16 13:54:54 +09:00
399a1a16a0
Refactor beginClickSelection in a slightly different way
2020-11-15 21:06:47 +01:00
9c0a0031d6
Clear existing transforms on DHO return to pool
2020-11-15 19:50:22 +01:00
1db303b159
Revert beginClickSelection logic
2020-11-15 16:54:48 +01:00
5d44286d38
Add missing generic mappings to legacy mods
2020-11-15 15:35:06 +01:00
5ace7abaa8
Add abstract non-generic ModNightcore to pattern-match over
2020-11-15 15:32:02 +01:00
8b74298567
Add base method for testing conversion in other direction
2020-11-15 14:48:23 +01:00
9899687bfe
Rename existing method to allow for new one
2020-11-15 14:17:41 +01:00
199043f677
Allow preview tracks to exist without an owner (without hard crashing)
2020-11-15 13:21:09 +09:00
34f09e2e20
Merge branch 'master' into fix-spectator-preview-crash
2020-11-15 13:16:10 +09:00
f8cabbdd21
Clear result when freeing pooled hitobject
2020-11-14 21:09:22 +01:00
b344a13734
Add support for previewing tracks on spectator screen
2020-11-14 17:08:27 +01:00
8a78d408db
Add more missed null checks
2020-11-14 15:52:12 +01:00
610ed99ae3
Add null checks to unguarded resolved-as-null fields
2020-11-14 14:52:58 +01:00
4d2bc790fd
Fix crash on shift+right-click deleting objects
2020-11-14 13:20:16 +01:00
