Commit Graph

270 Commits

Author SHA1 Message Date
5bab53b04c Centralise trail visibility state management 2020-05-10 17:05:30 +02:00
b44a70ef9a Let the catcher be responsible for stopping the trails 2020-05-07 01:46:37 +03:00
25f73c0b9f Add [NotNull] annotation 2020-05-06 23:40:36 +02:00
52d1e2b5f8 Improve xmldoc 2020-05-06 23:28:54 +02:00
ed83ac188e Remove special case for moving catcher sprite 2020-05-06 23:25:25 +02:00
278c3795e4 Merge remote-tracking branch 'upstream/master' into catch-hyperdash-catcher-colouring 2020-04-23 05:21:56 +03:00
883788dd5a Privatize externally-unused methods 2020-04-22 07:37:49 +03:00
fccb30e031 Adjust documents
*whoops*
2020-04-22 07:36:59 +03:00
f841eb7e06 Replace constructing a whole Catcher with static calculation methods 2020-04-22 07:27:15 +03:00
2d4077e713 Reword special default hyper-dash colour constant a bit 2020-04-22 05:25:40 +03:00
9ab0f6d8bc Separate trail-related logic to its own container 2020-04-22 05:12:29 +03:00
95de2c6f7f Mark Catcher.additiveTarget to never be null
And provide empty containers instead.
2020-04-22 05:04:07 +03:00
c8c2b51108 Remove redundant property set
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2020-04-21 11:44:39 +03:00
ee62739b08 Simplify process of adding catcher trails 2020-04-21 11:44:39 +03:00
a82efa626e Add XMLDoc for default hyper-dash colour constant 2020-04-21 11:44:39 +03:00
282d100109 Fix XMLDoc references 2020-04-21 06:09:57 +03:00
9373520bca Add constant for special colour of catcher on default skin 2020-04-21 05:59:37 +03:00
e17a44c99b Merge branch 'master' of github.com:ppy/osu into catch-hyperdash-catcher-colouring 2020-04-21 05:58:56 +03:00
d27d8671ab Convert all static getter-only properties to static readonly fields 2020-04-08 14:23:29 +03:00
42ccee5e6c Fix CI issue 2020-04-05 00:15:42 +03:00
0014a8404e GetHyperDashEndGlowColour() -> GetHyperDashCatcherAfterImageColour() 2020-04-04 23:12:42 +03:00
19f39fe632 Change AdditiveTarget into a set method 2020-04-04 19:33:52 +03:00
fbe95a52e3 Remove unnecessary restating comment 2020-04-04 19:29:41 +03:00
50604dc7b2 Update catcher hyper-dashing colours on changing hyper-dash state only 2020-04-04 19:29:06 +03:00
f3bcb0628c Add helper methods for retrieving other skin hyper-dash colours 2020-04-04 19:09:52 +03:00
ee247e58c8 Merge branch 'catch-hyperdash-fruit-colouring' into catch-hyperdash-catcher-colouring 2020-04-04 18:07:29 +03:00
f67a62699b Merge remote-tracking branch 'upstream/master' into catch-hyperdash-fruit-colouring 2020-04-03 19:57:52 +03:00
51db361c32 Update usages of Animation and Video in line with framework changes 2020-04-03 16:00:06 +09:00
f653d37058 Merge pull request #8521 from peppy/remove-scale-down-to-fit
Remove ScaleDownToFit as it was implemented without enough safety
2020-03-31 23:22:04 +09:00
b7d73f96ea Fix osu!catch catcher hit area being too large 2020-03-31 18:33:09 +09:00
1fce7cce01 Remove ScaleDownToFit as it was not implemented without enough safety 2020-03-31 13:50:04 +09:00
c2e31f53f1 Merge remote-tracking branch 'upstream/master' into catch-hyperdash-fruit-colouring 2020-03-28 07:44:11 +03:00
2949e8dc27 Reduce spread of stacked fruit 2020-03-26 16:58:23 +09:00
fecafc2e48 Fix additive target accidentally clears all of the added containers
It sets the AdditiveTarget on the object initializer but then the catcher is set to Child which wipes up all of the existing children (containers added by Catcher through AdditiveTarget setter)
2020-03-26 09:14:44 +03:00
302fdd834a Add support for custom hyper-dash catcher colouring 2020-03-26 09:11:59 +03:00
e3a7c8a124 Make catcher trails colouring per container 2020-03-26 09:11:31 +03:00
0a368f13d9 Add default hyper-dash colour constant on Catcher 2020-03-26 05:42:11 +03:00
388cf5c83a Fix catch positional data being incorrectly recorded 2020-03-24 15:38:54 +09:00
96a849f897 Add remaining replay recorders 2020-03-24 14:55:49 +09:00
f904859943 Remove leftover unused private methods 2020-03-15 15:45:13 +01:00
d3f23b766e Move across to new file in line with master 2020-03-14 17:06:23 +09:00
9ea0e83f3d Merge branch 'master' into correct-trail-animation-frame 2020-03-14 16:57:35 +09:00
45dfb22bd5 Centralise additive texture creation 2020-03-14 16:39:44 +09:00
202c8cdad8 Add braces to satisfy codefactor 2020-03-14 15:35:59 +09:00
1733519c3a Split out CatcherArea nested classes and reorder methods 2020-03-13 12:59:30 +09:00
c30bfa79e7 Merge branch 'master' into correct-trail-animation-frame 2020-03-13 09:55:41 +09:00
bc2a1cdb62 Apply suggestions 2020-03-12 12:04:36 +03:00
e46c070d95 Add test scene 2020-03-11 23:09:29 +03:00
09b9983286 Fix CatcherAnimationState is Fail if missing banana shower 2020-03-11 21:14:07 +03:00
03c8140d3c Merge branch 'master' into add-catcher-animation-states 2020-03-11 14:53:14 +09:00