Commit Graph

414 Commits

Author SHA1 Message Date
df3e2cc640 Fix potential crash due to cross-thread TrackVirtualManual.Stop 2020-07-28 12:08:15 +09:00
9f7750e615 Add texture wrapping support to skins 2020-07-17 16:54:30 +09:00
43624381bf Change multiplayer tests to have null room by default 2020-07-09 18:55:53 +09:00
eb64c4752c Merge remote-tracking branch 'upstream/master' into cache-ruleset-dependencies-for-tests 2020-06-15 11:31:12 +03:00
60381d5817 Remove IRulesetTestScene and use OsuTestScene.CreateRuleset() instead 2020-06-15 11:30:48 +03:00
4fb71eeb20 Move setting up the ruleset bindable to top-base test scene 2020-06-10 18:23:31 +03:00
efd5e14410 Clarify why ruleset bindable must be set at the BDL of any base test scene 2020-06-06 19:20:06 +03:00
0f78af7252 Remove unnecessary disabled check
I have a bad memory here, til.
2020-06-06 19:19:30 +03:00
741fa20149 Use CreateRuleset() for editor test scenes as well 2020-06-04 00:47:10 +03:00
c72592c52c Remove bindable-disabling logic and don't tie immediately to CreateRuleset() 2020-06-04 00:44:28 +03:00
bbad70c3f0 Fix mod perfect test scenes failing due to null ruleset provided
Just a workaround for now, a better fix may be to put the test data creation in an action that is guaranteed to be invoked after the test scene has fully loaded (all dependencies would've been resolved by then).
2020-06-04 00:43:11 +03:00
136e10086a Set the ruleset bindable value at the BDL for its subclasses usages
There are test scenes using current value of ruleset bindable on their BDL (example in TestSceneSliderSnaking's BDL)
2020-06-04 00:37:06 +03:00
11da045d8c Reorder declaration position of ruleset-creation methods
Should be recognized as a normal protected method in its declaring class.
2020-06-03 23:43:18 +03:00
84b40ea2c6 Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
# Conflicts:
#	osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
#	osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
#	osu.Game/Tests/Visual/ModTestScene.cs
#	osu.Game/Tests/Visual/OsuTestScene.cs
2020-06-03 22:00:02 +03:00
2c6887e610 Remove unnecessary use of and remove StartupStorage 2020-05-31 19:49:03 +03:00
82fe99cf4a Replace any potential usage of Environment.CurrentDirectory with a new RuntimeInfo.StartupDirectory
Using `Environment.CurrentDirectory` for storing / reading files is dangerous as the current directory is mutable and can be changed when performing a certain operation (like opening solutions in roslyn type reference builder for example).
2020-05-31 02:24:49 +03:00
866db629d6 Fix remaining test failures 2020-05-22 18:23:24 +09:00
dd09d7830d Cache and resolve editor clock as EditorClock in all cases 2020-05-22 16:44:06 +09:00
bac78707de Move more logic to column to both clean things up and fix tests 2020-05-21 14:25:37 +09:00
82d6549161 Pass down snap result and remove local TimeAt usage 2020-05-20 21:01:29 +09:00
be3a0a3c1d Merge branch 'master' into remove-requiredtypes 2020-05-16 18:28:14 +09:00
648999a2de Remove all RequiredTypes usages 2020-05-16 18:17:12 +09:00
44319c1b71 Commit missed change 2020-05-12 20:26:34 +09:00
de50b725d5 Fix mod failure checks executing actual game logic 2020-05-12 20:08:35 +09:00
7d54d4b800 Improve test scene 2020-04-28 18:36:10 +09:00
fe0038ed14 Merge branch 'master' into fix-mania-placement 2020-04-24 17:00:12 +09:00
227503c0af Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset 2020-04-23 16:25:33 +03:00
2fa47992dc Seal the ruleset creation methods and let abstract method take their place
Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers
2020-04-23 13:27:12 +03:00
0a0ea39431 Mark the top ruleset creation method as can-be-null 2020-04-23 13:24:30 +03:00
6df45164fa Expose direction from scrolling test container 2020-04-23 11:17:16 +09:00
40f11ed15c Resolve broken test scene 2020-04-23 10:37:05 +09:00
08982e0e00 Ensure editor tests wait for load to complete 2020-04-22 19:49:21 +09:00
af32f51116 Merge pull request #8800 from iiSaLMaN/allow-cancelling-completion
Fix results screen pushed after rewinding in-between push delay
2020-04-21 12:49:49 +09:00
fc6c245de5 Replace all judged event logic with HasCompleted bindable 2020-04-19 05:36:04 +03:00
d4788e39bb Merge branch 'master' into taiko-drumroll-skinning 2020-04-17 19:30:18 +09:00
7f791dcdf0 Re-enable ruleset bindable before setting defined ruleset in case it's disabled
Happens on cases like restarting the test scene by clicking directly on it on the browser (*where it for some reason reloads the entire test scene*)
2020-04-17 11:18:05 +03:00
155bc8b49a Remove ModTestScene ruleset parameter on constructor and use CreateRuleset instead 2020-04-17 11:17:59 +03:00
92df4e3a9e Remove PlayerTestScene constructor and use CreateRuleset method instead 2020-04-17 11:17:51 +03:00
5fa6bcb5a3 Move SkinnableTestScene into using the global CreateRuleset method 2020-04-17 11:17:44 +03:00
67bd7bfa39 Add CreateRuleset in OsuTestScene for scenes that depend on it 2020-04-17 11:12:25 +03:00
4eefe47ce3 Merge branch 'master' into fix-0-customsampleset 2020-04-16 11:20:31 +09:00
18c28390ef Setup drumroll testing 2020-04-15 16:29:39 +09:00
b29957798f Fix no audiomanager in test scene working beatmap 2020-04-14 21:05:42 +09:00
bde0b259c1 Improve slider placement test scene 2020-04-13 15:31:54 +09:00
2b4208bebf Cache ruleset dependencies if the scene tests ruleset-specific components 2020-04-11 04:23:31 +03:00
7951a52a15 Merge branch 'master' into per-ruleset-skinnable-tests 2020-04-07 22:59:42 +09:00
c9872f1d93 Retrieve dll resources using a more reliable method 2020-04-07 18:55:03 +09:00
0a340bac5a Ensure the correct (up-to-date) ruleset is retrieved 2020-04-07 16:20:13 +09:00
8506029237 Fix SkinnableTestScene losing test resources on dynamic recompilation 2020-04-07 13:46:37 +09:00
1f797207f7 Rework lookups to not require total playfield columns 2020-04-03 12:31:05 +09:00