Commit Graph

52753 Commits

Author SHA1 Message Date
7809566f16 Add explanatory comments 2022-06-16 23:31:49 +09:00
7b0fad6461 Null disposal token after use 2022-06-16 23:29:33 +09:00
c7287556e5 Merge pull request #18695 from frenzibyte/first-run-setup-notification-interruption
Silence important notifications during first-run setup
2022-06-16 23:01:43 +09:00
9c4f6d2ce0 Merge branch 'master' into first-run-setup-notification-interruption 2022-06-16 15:14:40 +02:00
d8657ee9e1 Merge pull request #18734 from peppy/bmm-cleanup-2
Remove `RealmArchiveModelManager` from hierarchy
2022-06-16 15:14:06 +02:00
c90edf49a7 Merge branch 'master' into bmm-cleanup-2 2022-06-16 13:33:20 +02:00
6df4b16a89 Merge pull request #18733 from peppy/bmm-cleanup
More model importer clean-ups (delete `BeatmapModelManager`)
2022-06-16 13:32:55 +02:00
d48fbdb439 Merge branch 'bmm-cleanup' into bmm-cleanup-2 2022-06-16 19:48:54 +09:00
e66ccfd980 Add back missing notification flow 2022-06-16 19:48:18 +09:00
448eee051a Update filename to match new class name 2022-06-16 19:41:14 +09:00
3860f0b3e5 Remove unused GetWorkingBetamap method 2022-06-16 19:08:59 +09:00
ce3d3a967c Reimplement missing methods 2022-06-16 19:05:25 +09:00
a635664a86 Fix invalid method reference in comment
`BeatmapModelManager.Save()` was moved to `BeatmapManager`, not to
`BeatmapImporter`.
2022-06-16 12:01:53 +02:00
72c5b9009d Remove local realm fields in manager classes 2022-06-16 18:56:53 +09:00
f3984d98e6 Remove RealmArchiveModelManager from hierarchy 2022-06-16 18:53:13 +09:00
8a5755ca52 Remove pointless override in test implementation 2022-06-16 18:27:16 +09:00
04e4c5ef88 Move and adjust implementation regions to restore sanity 2022-06-16 18:26:13 +09:00
4d9e3d1982 Rename Score/Skin ModelManager classes to Importer for now 2022-06-16 18:11:50 +09:00
1f3e1b2d97 Combine BeatmapManager and BeatmapModelManager into one class 2022-06-16 18:07:04 +09:00
8ea3042435 Move file extensions specification to common class 2022-06-16 18:00:27 +09:00
84dba36cf5 Update usages of BeatmapModelManager which only require importing to use BeatmapImporter 2022-06-16 17:59:24 +09:00
4c372539a1 Consolidate remaining methods in BeatmapModelManager 2022-06-16 17:59:24 +09:00
251923c106 Convert NotificationOverlay to NRT 2022-06-16 17:28:08 +09:00
6b30ee0950 Tidy up DI and binding logic 2022-06-16 17:26:43 +09:00
953ca8c2dd Merge pull request #18715 from bdach/ruleset-mod-hardening
Add several protections when creating game-global available mods
2022-06-16 17:18:49 +09:00
4526f8c07d Move database backup creation to async thread where possible 2022-06-16 17:01:17 +09:00
17dbb599d1 Don't backup collection database
This is no longer required due to recent changes which mean the
collection database will retain beatmap references even if they aren't
loaded locally (see https://github.com/ppy/osu/pull/18619).
2022-06-16 16:48:53 +09:00
739a696467 Ensure reading of existing databases when making backups doesn't create a file 2022-06-16 16:48:06 +09:00
ec53d87c30 Fix unsafe sample playback in GameplaySampleTriggerSource
Resolves https://github.com/ppy/osu/issues/18727.

Added delay from `Schedule` should be minimal as it is always called
from the `Update` thread (input propagation) anyway.
2022-06-16 16:04:57 +09:00
1c3cc985bc Merge pull request #18720 from bdach/twemoji-flags
Update flag sizes after switch to twemoji assets
2022-06-16 15:55:05 +09:00
89533fa33d Fix Disclaimer screen handling user change events after initial display
Unnecessary overhead, but also should resolve a production hard crash.
2022-06-16 15:40:20 +09:00
0c9f4fc8eb Merge branch 'master' into twemoji-flags 2022-06-16 15:06:49 +09:00
ac554ca51f Update resources 2022-06-16 15:06:34 +09:00
e778c90930 Merge pull request #18723 from smoogipoo/ci-template-tests
Run template tests on CI
2022-06-16 15:04:54 +09:00
88376da2cf Run template tests on CI 2022-06-16 13:47:30 +09:00
f88c568c8d Update flag sizes after switch to twemoji assets
The old flags used a size of 150x100, while the new assets based on
twemoji use a size of 150x108. Update existing usages to match this new
aspect ratio better.
2022-06-15 21:45:47 +02:00
2c35b1404b Use FileInfo as current bindable type 2022-06-15 19:29:09 +03:00
5d74d92fcf Revert virtual current bindable 2022-06-15 19:28:43 +03:00
e7dcbddbeb Fix potential null reference 2022-06-15 18:53:49 +03:00
1acbb87aa6 Ensure AvailableMods.Value is never null 2022-06-15 17:40:16 +02:00
6ee1c35c8f Fix template projects returning null mods from GetModsFor() 2022-06-15 17:40:16 +02:00
30382b0445 Fill out GetModsFor() xmldoc and annotate items as non-null 2022-06-15 17:40:15 +02:00
e74b563b91 Add protection against arbitrary exceptions from GetModsFor() 2022-06-15 17:31:46 +02:00
665ef5fdcc Add test coverage for API-incompatible rulesets wrt mods 2022-06-15 17:31:46 +02:00
6e5e506fb4 Add protection against rulesets returning null mods 2022-06-15 17:31:46 +02:00
0418d70056 Add test coverage for ignoring null mods returned by rulesets 2022-06-15 17:31:46 +02:00
387c54c252 Ensure notification is displayed after first-run setup is hidden 2022-06-15 18:13:24 +03:00
026bad7fc4 Use notification processing mode logic instead 2022-06-15 18:13:24 +03:00
1ff070f5ff Decouple LabelledFileChooser from LabelledTextBoxWithPopover 2022-06-15 17:45:31 +03:00
c9cb4250bb Merge pull request #18712 from peppy/importer-clean-up-part-2
More clean-up work on realm/beatmap import flow
2022-06-15 16:14:41 +02:00