Commit Graph

357 Commits

Author SHA1 Message Date
179ba3c9a8 Merge branch 'master' into catcher-area-catcher
# Conflicts:
#	osu.Game.Rulesets.Catch.Tests/TestSceneCatcher.cs
2021-07-21 16:45:28 +09:00
94678064ff Rename CatcherArea.MovableCatcher to Catcher 2021-07-21 16:28:31 +09:00
da3499f10e Simplify the way of getting catcher 2021-07-21 16:27:44 +09:00
6cc81c24b4 Merge pull request #13785 from ekrctb/dependency-providing-container
Add a convenient way to provide ad-hoc dependency to children in visual test
2021-07-20 14:18:17 +09:00
b88ee3c1a1 Pass DroppedObjectContainer via constructor instead of DI
It is now just one level deep, so it is not beneficial to use DI here.
This effectively reverts ae09c23e.
2021-07-19 20:11:49 +09:00
50f9e5f362 Replace usage of CatcherArea.MovableCatcher with Catcher 2021-07-19 19:52:40 +09:00
97059a9f50 Create Catcher in CatchPlayfield 2021-07-19 19:44:40 +09:00
87c39909c6 Simplify DependencyProvidingContainer
Using an array of tuple for dependencies instead of using children.
2021-07-19 14:37:19 +09:00
fffe0d2e57 Add tests of JuiceStreamPath.
"Property testing" is heavily used, tests that generates random cases and asserting properties.
That gives high confidence of round-trip correctness of `SliderPath` conversion, for example.
2021-07-19 13:59:10 +09:00
25b94061fd Fix assert step not waiting for transformation 2021-07-08 16:40:18 +09:00
8ac3015f14 Add tests of banana shower placement blueprint 2021-07-08 16:36:44 +09:00
68116aa042 Fix placement blueprint animation is not running in test scene 2021-07-08 16:17:09 +09:00
ae67409f41 Add a test of fruit placement blueprint 2021-07-08 16:12:08 +09:00
8da1335e5f Add catch placement blueprint visual test scenes (without tests) 2021-07-08 15:51:46 +09:00
bd4b3f5268 Add catch selection blueprint visual test scene (without tests) 2021-07-08 15:42:29 +09:00
e1c646b9b2 Remove redundant arguments 2021-07-05 23:52:39 +08:00
01961fe4f9 Merge pull request #13747 from ekrctb/catcher-flip
Don't flip catcher plate contents when catcher changes direction
2021-07-06 00:02:23 +09:00
5a0a223b1b Use DependencyProvidingContainer in TestSceneCatcher 2021-07-05 19:07:48 +09:00
623ba15919 Relax caught object stacking test
The stacking code currently uses an unseeded RNG and there is a non-zero chance the stack will be very flat (small Y position difference).
Technically, `RNG.NextSingle(0, 5)` can return `0`, but extremely unlikely that the all RNG calls return 0.
2021-07-04 10:23:49 +09:00
333caca386 Add test for catcher plate flipping configuration 2021-07-02 23:23:23 +09:00
170513568b Move caught object stack vertical offset logic 2021-07-02 20:43:47 +09:00
0d3de488de Bump NUnit3TestAdapter from 3.17.0 to 4.0.0
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.17.0 to 4.0.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.17...V4.0.0)

---
updated-dependencies:
- dependency-name: NUnit3TestAdapter
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-01 17:02:17 +00:00
ae09c23e4e Resolve DroppedObjectContainer via DI 2021-06-24 16:09:13 +09:00
16d5893535 Add DroppedObjectContainer class 2021-06-24 15:51:54 +09:00
fbe44dac34 Add empty catch hit object composer 2021-06-22 17:20:13 +09:00
67d8e0059f Use singular IApplicableToDrawableHitObject for consumers 2021-06-16 18:47:04 +09:00
33aec57238 Replace 1.0 version in old skin test assets with none 2021-06-11 15:45:34 +09:00
8d0840020b Specify legacy skin version of old-skin testing skin
Old-style catcher sprite is not supported for all versions
2021-06-11 15:33:13 +09:00
e388a896e8 Don't apply visibility increase to first object in osu!catch
The goal of the visibility increase is to help in cases where timing is
an issue (by showing the approach circle etc.). This doesn't need to
apply to catch.

@smoogipoo interested as to whether you agree with this one. Visually it
looks better to me but it does change the behaviour for only osu!catch,
so I'm not 100% confident on it.

Closes #13367.
2021-06-08 16:02:26 +09:00
181f1da3d3 Maintain catch hit explosion by lifetime entries
- Fix hit explosion not showing when a replay is rewound to a time after a hit object is caught
2021-06-04 19:46:50 +09:00
5366e7f61e Merge branch 'master' into remove-hud-component-lookup 2021-06-02 16:10:06 +09:00
f8ae70e562 Update existing function type rather than adding an override 2021-06-02 16:04:53 +09:00
967a7c3db5 Bump Microsoft.NET.Test.Sdk from 16.9.4 to 16.10.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.9.4 to 16.10.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.9.4...v16.10.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:27 +00:00
f60e9cb085 Remove weird override logic in TestCase methods 2021-05-31 20:00:47 +09:00
e78391db7a Fix usage of DI before it's ready in combo colour tests 2021-05-31 19:58:19 +09:00
e20c25b0d9 Fix miswritten test assertion 2021-05-19 23:32:16 +03:00
a730349629 Remove the ignore attribute once again 2021-05-19 23:18:54 +03:00
076fcec3df Revert "Remove ignore attribute from now fixed test scene"
This reverts commit 4e12a2734c.
2021-05-18 17:45:15 +03:00
4e12a2734c Remove ignore attribute from now fixed test scene 2021-05-18 09:51:58 +03:00
ff419af512 Hide the combo counter content rather than full death 2021-05-18 09:10:15 +03:00
f00799cc64 Remove unused using directive
...damn it
2021-05-15 18:36:47 +03:00
243c8aa585 Add test coverage 2021-05-15 18:02:38 +03:00
1b3b07d6a9 Bump NUnit from 3.13.1 to 3.13.2
Bumps [NUnit](https://github.com/nunit/nunit) from 3.13.1 to 3.13.2.
- [Release notes](https://github.com/nunit/nunit/releases)
- [Changelog](https://github.com/nunit/nunit/blob/v3.13.2/CHANGES.md)
- [Commits](https://github.com/nunit/nunit/compare/v3.13.1...v3.13.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-29 03:51:12 +00:00
bdf07ad59a Limit catching towards the centre of the plate (to emulate actual gameplay) 2021-04-22 17:47:03 +09:00
2203552e9e Add stacking test logic to TestSceneCatcherArea for skinned testing 2021-04-22 17:34:53 +09:00
84a7138223 Update tests to better support stack regeneration cases 2021-04-22 17:13:19 +09:00
b10ee7482d Add a failing test to check catch replay accuracy 2021-04-09 15:58:23 +09:00
345779b19a Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay 2021-04-02 20:58:29 +09:00
6a286c5e21 Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.9.1 to 16.9.4.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.9.1...v16.9.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-04-01 17:16:02 +00:00
8438fce764 Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay 2021-03-26 11:47:38 +09:00