Commit Graph

31335 Commits

Author SHA1 Message Date
3630ab2db2 Remove unnecessary nullability of storyboard mods list 2022-03-03 00:09:12 +03:00
cbb8dc2891 Fix storyboard samples rate not adjusted from actual gameplay mods 2022-03-02 20:56:18 +03:00
e14a35b469 Add failing test case 2022-03-02 20:32:41 +03:00
09a74cdfc6 Merge pull request #17023 from peppy/realm-async-write
Add `RealmAccess.WriteAsync` method and more statistics of realm reads/writes
2022-03-02 12:31:16 +09:00
97c54de3bf Fix performance statistic not handling rulesets with unimplemented calculator 2022-03-01 20:43:20 +03:00
9a117467b5 Add RealmAccess.WriteAsync method 2022-03-01 18:44:05 +09:00
7fa5842783 Add global statistics output for all realm reads/writes 2022-03-01 18:31:18 +09:00
159db38f8a Add missing xmldoc 2022-02-28 19:14:43 +09:00
a41e1c80f1 Show hit error on results screen
Leading up to implementation of "local offset", this feels like a good
thing to have visible first and foremost.
2022-02-28 19:11:06 +09:00
2be40f36f7 Reword popup text to read better (or more vaguely)
Removed some words but also don't mention "smaller" because it's...
musically incorrect and also functionally incorrect – entering 1/[8]
will result in 1/16 also being populated for instance.
2022-02-28 15:26:50 +09:00
368eadd8d1 Remove unused using statement 2022-02-28 15:24:02 +09:00
3634e12e66 Automatically focus divisor textbox and hide popover after successful change 2022-02-28 15:23:01 +09:00
7de5dad4f0 Add test coverage for divisor behaviour 2022-02-27 19:23:02 +01:00
423838a649 Add flow for specifying entirely custom snaps 2022-02-27 17:55:20 +01:00
d0c01afc2e Add flow for changing set of valid divisors between presets 2022-02-27 15:37:51 +01:00
36137e0619 Add simple carousel divisor type selector 2022-02-27 15:37:51 +01:00
67082b8c5d Remove verbose logging from SpectatorClient for now 2022-02-25 22:25:36 +09:00
e947c97e10 Merge branch 'master' into spectator-reliability 2022-02-25 20:20:30 +09:00
926abf7a0c Merge pull request #16985 from smoogipoo/multi-spectator-chat
Add chat display to multiplayer spectator
2022-02-25 20:19:07 +09:00
8eef1774d5 Use Logger.Log instead of console 2022-02-25 20:18:22 +09:00
a86bc344da Merge pull request #16977 from peppy/pause-at-results
Allow pausing audio via hotkey at multiplayer lobby and results screen
2022-02-25 19:13:06 +09:00
3a03833912 Merge pull request #16890 from peppy/beatmap-decoder-ruleset-store
Fix `LegacyBeatmapDecoder` not populating correct rulesets
2022-02-25 19:03:43 +09:00
387ae59bc4 Fix nullref in tests 2022-02-25 16:12:25 +09:00
48ed9c6144 Enable high chat polling rate 2022-02-25 16:03:56 +09:00
f9d9ad388b Add chat display to multiplayer spectator screen 2022-02-25 16:03:28 +09:00
a9e7e8fb18 Merge pull request #16924 from Susko3/android-allow-exiting
Allow exiting/minimizing the game on Android when on the initial screen
2022-02-25 11:01:35 +09:00
33a87976a8 Rewrite to read better
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-02-24 21:11:49 +01:00
769dc9b00b Merge branch 'master' into mod-overlay/panel 2022-02-24 21:02:28 +01:00
c189cc5d00 Remove unused using directive 2022-02-24 21:01:37 +01:00
80fc13fc1f Merge pull request #16976 from peppy/dont-expose-mark-as-read-errors-to-user
Don't expose "mark as read" errors to the user via notifications
2022-02-24 23:20:34 +09:00
16a3bbbcb4 Merge pull request #16944 from peppy/rooms-request-faster
Update playlists/multiplayer to use new compact response
2022-02-24 23:20:07 +09:00
35302aa297 Merge pull request #16980 from smoogipoo/fix-union-workaround-resolver
Fix SignalR union workaround resolver failing on multiple union'd types
2022-02-24 22:24:48 +09:00
c5b1e5cbf8 Fix union resolver failing on multiple derived types 2022-02-24 20:27:22 +09:00
d69446ff6e Merge pull request #16979 from smoogipoo/fix-playlists-partial-mod
Fix playlists not allowing entry with partial mods
2022-02-24 19:37:10 +09:00
6f29cbccd1 Remove unused using 2022-02-24 10:36:10 +01:00
255b3b067b Remove track fade 2022-02-24 10:13:27 +01:00
7193bc8554 Fix playlists comparing mod equality via APIMod 2022-02-24 17:04:16 +09:00
2acaffd5e7 Fix APIMod storing bindables instead of value 2022-02-24 17:01:12 +09:00
bb1aa032bd Combine SelectedItem and CurrentPlaylistItem into same storage 2022-02-24 16:21:20 +09:00
c6d78b9325 Fix several oversights in data linking causing drawable rooms not updating as expected 2022-02-24 16:12:15 +09:00
b4a54b38e7 Remove redundant parameter specification 2022-02-24 16:02:16 +09:00
401cf2a955 Allow pausing game-wide audio via hotkey as long as LocalUserPlaying is not set
`Player` seems to handle this correctly locally already, which is to say
if the user attempts to toggle the pause state incorrectly, it will
still recover.

The logic stoppic this operation was only in the key binding handler,
which meant it was already possible from the now playing overlay this
whole time, so I *think* this should be quite safe.
2022-02-24 16:00:14 +09:00
3f6bdc5585 Don't expose "mark as read" errors to the user via notifications
This can happen if the user leaves the channel before the request is
fired. You can't mark a channel as read when you're not in the channel.

Addresses https://github.com/ppy/osu/discussions/16973.
2022-02-24 15:40:07 +09:00
435bdd0b4a Combine and simplify state management logic
This makes a few changes to bring things into a better shape during
mouse interactions with the mod panels:

- Dragging away from the panel now works in line with other buttons (ie.
  `OsuButton`)
- Hovering now uses a lightened version of the current state, rather
  than always using the active colour. I think this feels better.
- Mouse down now uses a transform point of 0.5. This is to give the
  button a feeling of one of those latching light switches which resists
until reaching a point of overcoming the spring and switching state. I
think 0.4 (non-active) and 0.6 (from active) may work better, but left
at 0.5 for simplicity of implementation and I think it's good enough?
- Border always uses the gradiented version. I did this for simplicity
  of implementation, but also think it looks better.
- Adjusted transform durations to feel better to me.
2022-02-24 15:25:30 +09:00
6e8daa06fa Merge branch 'master' into mod-overlay/panel 2022-02-24 14:34:59 +09:00
2a2b8912c1 Merge branch 'master' into android-allow-exiting 2022-02-24 13:22:52 +09:00
8f951f8e8a Merge pull request #16969 from peppy/update-framework
Update framework
2022-02-24 11:32:34 +09:00
713f89a59c Implement incompatibility-displaying variant of mod panel 2022-02-23 23:19:06 +01:00
bbe2dfa458 Move out incompatibility displaying tooltip to own class 2022-02-23 23:18:15 +01:00
8a0aba6c59 Implement mod panel for new mod select screen 2022-02-23 23:18:14 +01:00