Commit Graph

290 Commits

Author SHA1 Message Date
f0fe3bc804 Pass bindable to BeatmapMetadataDisplay
It was reported that mods selected in song select would show up during
loading of replays which were recorded under a different set of mods.
This was caused by BeatmapMetadataDisplay accepting a plain read-only
value of the Mods bindable in PlayerLoader.load(), therefore making the
mod value assignment in ReplayPlayerLoader.OnEntering() have no effect
on that component.

To resolve this issue, make BeatmapMetadataDisplay accept the
higher-level bindable, bind to it locally and pass it down the hierarchy
to ModDisplay.
2020-01-08 20:10:43 +01:00
a3f7d3c445 Add failing test
Add test case demonstrating the lack of update of the metadata display's
mods upon setting the Mods property in PlayerLoader.
2020-01-08 19:55:35 +01:00
d828b31ae4 Schedule child mutation in test setup 2019-12-27 17:16:43 +01:00
e2a55b79ca Refactor scrolling hit object scene
To better demonstrate the desired effect of the fix introduced in
193e41f, refactor TestSceneScrollingHitObjects to contain two tests,
one of which contains the pre-existing controls to test scroll
algorithms, and the other aims to showcase the fix by setting scroll
parameters appropriately.
2019-12-27 16:52:07 +01:00
005ec4b373 Demonstrate bug in scrolling container scene
Modify TestSceneScrollingHitObjects to showcase the effect of origin
choice on object lifetime for all four scrolling directions.
2019-12-26 20:37:06 +01:00
00a36c388c Fix tests 2019-12-26 19:18:39 +09:00
7414a6aadd Merge remote-tracking branch 'huoyaoyuan/master' into health-processor
# Conflicts:
#	osu.Game.Rulesets.Catch/CatchRuleset.cs
#	osu.Game.Rulesets.Mania/ManiaRuleset.cs
#	osu.Game.Rulesets.Taiko/TaikoRuleset.cs
2019-12-26 14:56:54 +09:00
9702cc9809 Merge branch 'master' into remove-legacy-id 2019-12-25 21:01:12 +09:00
0677f746aa Provide the ruleset to converter classes 2019-12-24 16:02:16 +09:00
6e7426a098 Simplify/improve beatmap conversion precheck 2019-12-23 17:44:18 +09:00
5af1260094 Improve testing 2019-12-21 14:30:49 +03:00
76f2fb378f Separate score and health parts of ScoreProcessor 2019-12-19 20:03:14 +09:00
51a01c7006 Merge pull request #7256 from peppy/remove-ruleset-ctor-param
Remove RulesetInfo parameter from Ruleset constructor
2019-12-18 18:42:42 +09:00
2a128340d0 Merge remote-tracking branch 'refs/remotes/origin/master' into nightcore-beats 2019-12-18 17:58:37 +09:00
6e0802e50c Remove RulesetInfo parameter from Ruleset constructor 2019-12-18 14:49:09 +09:00
ecfc6dfa3d CA1825: use Array.Empty. 2019-12-17 12:59:48 +08:00
7d979e1264 Add finalised test scene 2019-12-16 19:41:04 +09:00
6cf318c34b Merge remote-tracking branch 'refs/remotes/origin/master' into improve-hud-hiding 2019-12-16 18:41:21 +09:00
bc31146560 Mods -> SelectedMods 2019-12-13 21:45:38 +09:00
1807fc9b61 Fix testcase not converting beatmap 2019-12-12 16:48:33 +09:00
3ccfee64f6 Add HUDOverlay tests 2019-12-12 16:09:42 +09:00
5861eca80d Make DrawableRuleset take a converted beatmap 2019-12-12 15:58:11 +09:00
274958669c Add early assert as sanity check 2019-12-11 15:47:41 +09:00
6c8f325063 Add failing test 2019-12-11 15:46:07 +09:00
bd6a08a21b Merge branch 'master' into apply-to-track 2019-12-10 16:15:24 +09:00
eb074b7058 Allow mods to apply to track, not clock 2019-12-09 17:44:45 +09:00
53f7c753fb General cleanups 2019-12-09 16:44:19 +09:00
c18f2e6436 Merge remote-tracking branch 'refs/remotes/origin/master' into segmented-slider-paths-3 2019-12-09 15:34:49 +09:00
2654710d91 Add tests and fix negative expected distances 2019-12-06 15:37:06 +09:00
12f1c9e088 Fix test failure 2019-12-06 15:29:02 +09:00
de23364608 Add failing test 2019-12-06 13:47:34 +09:00
2702edfa55 Rename new path, replace existing one 2019-12-05 17:49:32 +09:00
5e9b739b67 Re-implement slider paths to support multiple segments 2019-12-05 16:45:02 +09:00
5b8ca8f84a Remove test ignore rules 2019-12-05 01:17:11 +09:00
9ac0ac0944 Merge branch 'master' into fix-pause-testcase 2019-12-05 01:00:27 +09:00
f0d49d0cdf Decouple APILegacyScoreInfo from ScoreInfo 2019-12-03 15:31:11 +09:00
e7ef919b0b Ignore another failing test 2019-11-29 01:47:52 +09:00
1c4063677d Ignore test temporarily 2019-11-29 00:45:35 +09:00
f504370867 Make player block exit if pausable 2019-11-28 15:58:26 +09:00
c6a85a11bd Merge branch 'master' into sharpen 2019-11-27 17:09:11 +09:00
c0fe91a84c Merge branch 'master' into sharpen 2019-11-26 18:21:50 +08:00
77ce9642ba Add test coverage and simplify break time updating 2019-11-26 15:32:48 +09:00
45514ff660 Apply fixes 2019-11-25 11:30:55 +09:00
5d2a608be0 Merge branch 'master' into lead-in-fixes 2019-11-22 13:48:55 +09:00
71a64da566 Fix test regressions 2019-11-21 22:07:37 +09:00
bd6831624a Decouple skip button animations from gameplay clock 2019-11-21 19:51:22 +09:00
46a94821d4 Add support for consecutive skips 2019-11-21 18:59:55 +09:00
8d1b11d4bd Add storyboard lead-in tests 2019-11-21 18:50:54 +09:00
4e53bca8dd Simplify tests 2019-11-21 18:50:38 +09:00
29d2374928 Add back skip button actuation count tests 2019-11-21 17:23:52 +09:00