Commit Graph

4710 Commits

Author SHA1 Message Date
3670bd40c2 Add test coverage of user scroll overriding 2021-02-02 15:44:11 +09:00
398ab9c2c2 Use UserTrackingScrollContainer instead 2021-02-02 15:29:38 +09:00
dcb1626e4d Remove no longer necessary field 2021-02-01 22:38:42 +03:00
39d46d21e6 Add failing test case 2021-01-31 23:44:51 +03:00
fedcbf79fa Merge pull request #11572 from EVAST9919/comment-pill
Make VotePill background transparent for own comments
2021-01-26 18:57:00 +09:00
468dfbecbe Merge branch 'master' into fix-beatmap-listing-2 2021-01-26 17:56:37 +09:00
c317d60169 Add offline test scene for beatmap listing overlay 2021-01-26 00:03:20 +03:00
9312de7c23 Move online beatmap listing overlay to separate test scene 2021-01-26 00:03:20 +03:00
439f03e3b3 Fix failing test due to missing dependency 2021-01-25 19:25:38 +09:00
366f074f86 Better describe test steps to discern on failures 2021-01-25 16:53:39 +09:00
adcef19ab2 Add coverage for operation tracker with failing tests 2021-01-23 15:59:14 +01:00
e9d10bb6e7 Revert "Minor refactoring"
This reverts commit 3d42cc1f91.
2021-01-22 22:49:49 +03:00
3d42cc1f91 Minor refactoring 2021-01-22 22:27:26 +03:00
360f26c13d Merge branch 'master' into scroll-to-20 2021-01-22 19:58:36 +01:00
20161aea6a Show LoginOverlay if not logged-in when clicking on a pill 2021-01-22 21:47:53 +03:00
6379381f95 Make VotePill background transparent for own comments 2021-01-22 20:46:20 +03:00
a6516e3be5 Merge branch 'master' into scroll-to-20 2021-01-21 14:28:17 +09:00
54dbb43f79 Fix more potential failures 2021-01-21 14:03:35 +09:00
7c4a072568 Merge branch 'master' into scroll-to-20 2021-01-21 13:48:26 +09:00
163a937e41 Fix mod test failing intermittently 2021-01-21 13:30:53 +09:00
c3675293fa Merge branch 'master' into beatmapset-refactor 2021-01-21 12:38:34 +09:00
7abe33ad0e Add failing test case 2021-01-21 00:04:15 +01:00
bba182a02d Fix test failure 2021-01-20 21:27:16 +09:00
2ca3ccad06 Move all the content to BeatmapSetHeaderContent drawable 2021-01-20 04:56:46 +03:00
f0add0a7cf Make BeatmapSetOverlay use OverlayHeader 2021-01-19 01:34:37 +03:00
fda271d9d9 Merge pull request #11520 from frenzibyte/fix-item-download-button
Fix playlist item download button never shown back after hiding
2021-01-18 23:37:33 +09:00
ced7a36788 Update namespaces 2021-01-18 21:24:10 +09:00
2b23c8eabd Use alpha directly for checking visibility in test
`IsPresent` is no longer synonymous with being visible, after applying
the fix to the issue in question.
2021-01-17 18:08:58 +01:00
585aa87c53 Fix playlist item download button never shown back after hiding 2021-01-17 19:17:14 +03:00
5fd644fc57 Unify variable names 2021-01-17 22:42:48 +09:00
addd463d26 Merge branch 'master' into explicit-search-control 2021-01-17 21:44:25 +09:00
edb6d3907b Merge pull request #11472 from frenzibyte/explicit-beatmap-markers
Add explicit content markers to beatmap panels and overlay
2021-01-17 21:44:10 +09:00
b8c85ef017 Revert polling changes to fix participant list display
It turns out this polling was necessary to get extra data that isn't
included in the main listing request. It was removed deemed useless, and
in order to fix the order of rooms changing when selecting a room.
Weirdly, I can't reproduce this happening any more, and on close
inspection of the code can't see how it could happen in the first place.

For now, let's revert this change and iterate from there, if/when the
same issue arises again.

I've discussed avoiding this second poll by potentially including more
data (just `user_id`s?) in the main listing request, but not 100% sure
on this - even if the returned data is minimal it's an extra join
server-side, which could cause performance issues for large numbers of
rooms.
2021-01-15 15:19:12 +09:00
d023ad8ad1 Remove assert messages 2021-01-15 15:18:29 +09:00
51255033e2 Update some missed usages of KeyBindingContainer in tests 2021-01-15 14:57:01 +09:00
0ea4e221b2 Merge branch 'master' into net5.0 2021-01-14 14:02:51 +03:00
268f9d661f Dispose of local config on disposal 2021-01-13 13:00:14 +03:00
a5f99ed8e6 Merge branch 'explicit-beatmap-markers' into explicit-search-control 2021-01-13 12:53:57 +03:00
7fd55efc43 Add test cases for displaying explicit beatmaps 2021-01-13 12:27:15 +03:00
80fa2cf693 Add test coverage 2021-01-12 11:14:05 +03:00
d110ed9e95 Merge branch 'master' into fix-mod-buttons-not-copying-settings 2021-01-10 15:42:33 +01:00
95ad324a39 Merge branch 'master' into fix-mod-buttons-not-copying-settings 2021-01-10 23:01:54 +09:00
8c3955d341 Improve safety of ongoing operation tracker
Finishing an operation started via
`OngoingOperationTracker.BeginOperation()` was risky in cases where the
operation ended at a callback on another thread (which, in the case of
multiplayer, is *most* cases). In particular, if any consumer registered
a callback that mutates transforms when the operation ends, it would
result in crashes after the framework-side safety checks.

Rework `OngoingOperationTracker` into an always-present component
residing in the drawable hierarchy, and ensure that the
`operationInProgress` bindable is always updated on the update thread.
This way consumers don't have to add local schedules in multiple places.
2021-01-09 22:45:24 +01:00
b69fe8a274 Merge branch 'master' into disable-repeat-multi-actions 2021-01-09 10:15:20 +09:00
ff60d652ed Move out test ongoing operation tracker to higher level 2021-01-08 22:28:21 +01:00
375ecf92ed Merge remote-tracking branch 'upstream/master' into fix-mod-buttons-not-copying-settings 2021-01-09 00:26:18 +03:00
05ba5d4c31 Merge pull request #11438 from bdach/difficulty-adjust-defaults
Fix difficulty adjust mod treating default values as user overrides
2021-01-09 01:18:34 +09:00
924f91ed9b Fix song select test doing the completely wrong thing 2021-01-08 15:56:35 +01:00
2cfd1e8b47 Merge branch 'master' into fix-control-point-pollution 2021-01-08 00:02:45 +09:00
25b4628672 Merge branch 'master' into fix-transform-mutation-from-background 2021-01-06 11:04:51 +01:00