Commit Graph

95 Commits

Author SHA1 Message Date
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
f6d93fcd5a Fix editor hard crash when beatmap file specified out-of-range timeline zoom value 2022-11-07 12:54:02 +09:00
a753369d3e Reuse function TimeAtPosition() and PositionAtTime(). 2022-10-30 17:21:50 +08:00
0ffde02f79 Use hit object time for timeline selection 2022-10-05 21:51:01 +09:00
9d94343317 Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-09-17 19:51:44 +02:00
c8768eb399 Changed == to <= on TimelineZoom check 2022-09-17 19:00:50 +02:00
3c7ea5c8fa Update 2022-09-17 18:57:09 +02:00
cd90536e4b Remove Track access in Timeline 2022-08-26 18:25:48 +09:00
07c6b44864 Fix Timeline attempting to setup zoom with unloaded track 2022-07-25 12:07:50 +03:00
6eb42d08ce Fix timeline zoom receiving feedback from bindable changes
This causes the focal point zooming to not work (as the focal point is
lost). There's no need to handle ongoing changes to
`BeatmapInfo.TimelineZoom` because it is not a property which is changed
at runtime.
2022-07-22 15:25:57 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
9cc5df9b13 Fix context menu no longer open on hitobjects in timeline 2022-05-29 15:23:32 +03:00
1137545d4a Fix Timeline potentially not updating visuals to correct state on first display 2022-05-24 18:11:05 +09:00
c0abce918f Add enum to snap method as alternative to mutliple nested invocations 2022-05-12 16:19:07 +09:00
0b597e712e Fix timeline not handling mouse down events 2022-05-11 09:39:27 +03:00
e83604a1fc Merge branch 'master' into cache-at-interface 2022-05-05 18:54:24 +09:00
1c6a233cc0 Move snap provider caching to interfaces 2022-05-05 16:44:37 +09:00
f6fc926f1a Add xmldoc and rename methods in IPositionSnapProvider for legibility 2022-05-05 15:58:21 +09:00
59cf3ff50f Move distancing methods from IPositionSnapProvider to IDistanceSnapProvider 2022-04-28 05:48:45 +03:00
0992bec2c8 Change "distance spacing" multipler type to double
Avoids losing precision on initial load, causing an unnecessary
hash change in `EditorChangeHandler`.

Resolves test failures in `TestSceneEditorChangeStates`
(https://github.com/ppy/osu/runs/5192493482?check_suite_focus=true).
2022-02-16 03:28:12 +03:00
528dc03b8c Expose distance spacing in IPositionSnapProvider for updating distance grid
Alternate method is to expose a `SnapDistancesChanged` event in
`IPositionSnapProvider` instead, but I chose this way as an analogue to
`IBeatSnapProvider.BeatDivisor`, which might even make sense to be
exposed as `BindableBeatDivisor` instead of caching that separately.
2022-02-15 02:21:53 +03:00
4169e5592e Reword event handler name and update xmldoc 2022-01-25 19:36:19 +03:00
d1cbdf63f0 Add support for reading/saving timeline zoom in editor 2022-01-25 18:57:39 +03:00
5a9524a74e Decrease default timeline zoom to "6 seconds visible" range 2022-01-25 10:43:51 +03:00
1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
9d17f84681 Adjust timeline height to account for less global control points 2021-09-14 18:51:11 +09:00
d4e5a612ea Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time
This allows fetching the correct `DifficultyControlPoint` from the
hitobject. Nothing more.
2021-09-03 17:11:12 +09:00
c2340f1fe8 Move zoom settings back to run in a non-loaded state 2021-04-16 01:01:03 +09:00
15d48a924b Set the timeline's height to a sane non-zero default
This isn't required but makes the initial appearance animation nicer.
2021-04-16 00:58:32 +09:00
d1c68cb92b Simplify content creation of Timeline / TimelineArea 2021-04-14 21:03:52 +09:00
99f05253fd Adjust timeline sizing to closer match designs (but not 1:1 yet) 2021-04-14 20:54:35 +09:00
1209c9fa32 Allow timeline to expand in height when control points are to be displayed 2021-04-14 20:10:50 +09:00
a314f90d37 Allow timeline to govern the size of the rest of the editor content 2021-04-14 18:17:27 +09:00
b7d2821b55 Display the centre marker above the waveform
Gives it a bit more visibility. This is where it was meant to sit, but
didn't consider using a proxy drawable to make it work previously.
2021-04-14 14:52:48 +09:00
8ff13845d1 Add marker showing where 00:00:000 is 2021-04-06 14:24:22 +09:00
a691291ae8 Merge branch 'master' into editor-song-end 2021-03-17 18:18:19 +01:00
04095cd5b9 Merge branch 'master' into fix-editor-scroll-interruption 2021-01-21 17:46:18 +09:00
9eb74e86ed Apply comment suggestion
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-01-21 17:40:15 +09:00
831c06a3c7 Expose and consume boolean covering whether an ongoing smooth seek is running 2021-01-15 16:14:38 +09:00
ed78be825f Fix editor timeline not snapping on non-precise wheel scroll
For wheel input with precision, we still prefer exact tracking for now.
May change this in the future based on feedback from mappers, but it
makes little sense to do non-snapped scrolling when input is coming from
a non-precise source.
2021-01-15 15:47:42 +09:00
c9a41f9dae Make all objects in selection candidates for spatial snapping
Closes #10898.
2020-11-24 17:35:54 +09:00
0219aff7bc Add timeline visible range adjustment 2020-11-13 17:10:29 +09:00
42c543f5b9 Merge branch 'master' into fix-editor-play-after-drag 2020-11-04 14:45:20 +09:00
0dcb4ea441 Add handling of opacity to timeline waveform display 2020-11-03 16:07:01 +09:00
34aa59f237 Fix editor clock not always remaining stopped when dragging timeline
Closes https://github.com/ppy/osu/issues/10461.
2020-11-03 15:00:01 +09:00
79a17b2371 Reapply waveform colour fix 2020-10-19 16:57:08 +09:00
6bc0afdafb Fix remaining conflicts 2020-10-05 20:09:18 +09:00
ba55256fb4 Merge branch 'master' into control-point-timeline-representation 2020-10-05 19:24:28 +09:00
5ad2944e26 Fix ticks displaying higher than control point info 2020-10-01 19:31:41 +09:00
70931abcb0 Separate out timeline control point display from summary timeline display 2020-10-01 18:55:34 +09:00