a317ef65b8
Remove default for argument
2020-03-28 12:18:28 +09:00
15fb1a099e
Modify assert to avoid false failures
...
In headless tests it was possible for TestInstantLoad() to erroneously
fail. There were two scenarios in which LoadingSpinner could be null:
1. If the test runner was quick enough, the assert could end up running
even before Loader.OnEntering() had even had a chance to, meaning
that the spinner was never even actually assigned to or instantiated
at that point in time.
2. Even if Loader.OnEntering() had managed to run, there was also
a possibility that the spinner itself wasn't loaded at the point
of checking the assertion. As the spinner is accessed through
ChildrenOfType(), which only checks InternalChildren and ignores
all currently-loading drawables, it would therefore return null.
As null != 0, both of these cases would actually fail the test (this is
best seen running headless, preferably with a [Repeat] attribute
attached).
To resolve, allow the spinner to be null at the point of asserting and
duplicate the assertion step at the end. This weakens the test, as case
(1) should probably be waited for and case (2) could be solved with
exposition as protected in the base, but when attempting to wait for
the loader itself to be loaded there were also cases where the
appropriate until step would take so much time that the spinner would
actually become visible in line with the delayed display logic, so this
is a best-effort attempt to address both points without radical
changes.
2020-03-28 00:43:57 +01:00
46af4bce32
Cover regression in autoplay test
2020-03-27 19:42:45 +01:00
7b24cc325f
Implement OverlayScrollContainer component
2020-03-27 20:57:57 +03:00
6ecfeb8cc3
Merge pull request #8455 from Game4all/handle-novideo-beatmaps
...
Fix NullReferenceException when starting the no-video version of a beatmap with video
2020-03-27 21:12:40 +09:00
6788b7f9cd
Add test for loading storyboards with missing video file.
2020-03-27 12:07:47 +01:00
e707adb773
Increase amount of test sets
2020-03-26 21:16:10 +02:00
902734b75e
Add failing test
2020-03-26 20:32:43 +02:00
9a30ff5a00
Fix code quality issues
2020-03-26 16:11:58 +01:00
00c1ff993a
Fix merge conflicts.
2020-03-26 15:48:18 +01:00
c1ac57e70f
Add back visual tests and add easing to alpha fade.
2020-03-26 12:14:44 +01:00
07462120e4
Split break tracking into its own component
2020-03-26 15:30:23 +09:00
1e025b7c31
Add tests to cover the issue
2020-03-25 20:58:51 +03:00
800e395bc8
Merge branch 'master' into replay-recording
2020-03-25 20:20:59 +09:00
880d138a47
Fix intro tests not asserting pass or working at all
2020-03-25 15:12:19 +09:00
6d81da5419
Merge branch 'master' into video-offset
2020-03-25 11:28:59 +09:00
368bf58521
Rename and make fields readonly
2020-03-25 11:08:08 +09:00
a5781d7fc5
Replace ScreenTitle with OverlayTitle and update titles to match new design
2020-03-24 22:08:20 +01:00
4070b2b75f
Merge branch 'basic-replay-recorder' into replay-recording
2020-03-24 16:31:14 +09:00
417ff837ac
Add basic tests
2020-03-24 16:22:54 +09:00
8484d201d1
Nest and rename test classes
2020-03-24 15:54:04 +09:00
2735a2250c
Move replay recorder to final location
2020-03-24 15:49:52 +09:00
388cf5c83a
Fix catch positional data being incorrectly recorded
2020-03-24 15:38:54 +09:00
68ebe98fde
Remove unused GetUnderlyingStream method
2020-03-24 14:08:25 +09:00
14a85a84bf
Add proper screen space - gamefield mapping
2020-03-23 20:06:18 +09:00
6d48068061
Move replay recorder to final location
2020-03-23 20:04:15 +09:00
9ea0137b01
Merge branch 'master' into spun-out
2020-03-23 18:13:53 +08:00
d5bc4915e6
Add "important" frames and record rate options
2020-03-23 19:02:45 +09:00
467066112f
Initial record/playback implementation
2020-03-23 18:50:16 +09:00
232c255986
Basic test scene setup
2020-03-23 17:33:02 +09:00
98e6896e93
Rename test class
2020-03-23 15:37:34 +09:00
680d058f3f
Merge branch 'master' into friends-layout-split
2020-03-23 15:36:04 +09:00
d0c7b49376
Merge branch 'master' into fix-carousel-root-selects-from-nothing
2020-03-23 11:34:04 +09:00
448e5c0deb
Merge branch 'master' into fix-carousel-root-selects-from-nothing
2020-03-23 11:15:22 +09:00
bf70276496
Fix test re-using the same beatmap sets
2020-03-23 11:12:36 +09:00
fb21c7d82d
Merge branch 'master' into fix-carousel-restore-previous-selection
2020-03-23 11:01:18 +09:00
bfd643dd16
Rename classes
2020-03-23 10:47:27 +09:00
0b728f483f
Rename base test class to help avoid incorrect reference
2020-03-23 10:01:33 +09:00
2b0c267cb9
Expose Fetch method
2020-03-21 20:37:21 +03:00
f8169e9712
Merge remote-tracking branch 'refs/remotes/ppy/master' into friends-layout-split
2020-03-21 20:31:38 +03:00
febf9adabd
Merge pull request #8329 from Fuewburvpoa/MyBranch
...
Fix beat divisor control selecting invalid divisors on drag end
2020-03-22 02:21:13 +09:00
729e006c3a
Merge branch 'master' into video-offset
2020-03-21 20:03:46 +09:00
8136ea561e
Fix a couple of broken tests
2020-03-20 15:02:13 +09:00
9b60b535e5
Fix selection not occurring when switching from empty ruleset on first load
2020-03-20 15:01:26 +09:00
3a50c4bb51
Update tests
2020-03-19 18:58:22 +09:00
c50784da93
Show 'D' rank badge on accuracy circle
2020-03-19 11:58:52 +09:00
23338a6c82
Adjust test implementation
...
* Use slider bar and slider marker coordinates in manual tests instead
of hard-coded offsets.
* Reword test steps slightly for greater clarity.
2020-03-18 22:23:06 +01:00
1d3cac4cdc
Eliminate osuTK.Input namespace qualifications
2020-03-18 21:55:35 +01:00
4bda520695
Use [SetUp] instead of reset method
2020-03-18 21:54:17 +01:00
648e9fa21f
Merge branch 'master' into MyBranch
2020-03-18 21:18:17 +02:00
