81aaef719f
Add xmldoc to CalculateTimed()
2021-11-02 17:55:00 +09:00
168a7a588b
Add xmldoc to ctor also
2021-11-02 17:19:14 +09:00
efba7a9c4d
Missed hyphen
2021-11-02 17:18:02 +09:00
0cdd2898fe
Expose non-adjusted time from CalculateTimed()
2021-11-02 17:17:14 +09:00
135df0e190
Avoid adding null users to RecentParticipants
2021-11-02 17:13:37 +09:00
1bfa1365a0
Rename "null user" tests to better explain purpose
2021-11-02 17:13:37 +09:00
b0bd39fc49
Fix multiplayer room participants display not updating as new users join/leave
...
Can add tests on request, but not sure the code around this area is here
to stay permanently. Should be pretty low risk.
- Closes https://github.com/ppy/osu/issues/14788 .
2021-11-02 17:13:37 +09:00
e472656b37
Add test coverage of room participants updating on room join
2021-11-02 17:13:37 +09:00
eaeee80a26
Fix PP counter showing incorrect values with rate adjustment mods
2021-11-02 16:55:20 +09:00
6f941a8916
Merge pull request #15405 from peppy/legacy-decoder-default-section
...
Default legacy decoder to `General` section, rather than none
2021-11-02 15:42:25 +09:00
1e9211c00b
Use explicit type
2021-11-02 15:41:25 +09:00
a2f6b816ff
Merge pull request #15406 from peppy/fix-skin-hashing-circular-reference
...
Avoid any potential infinite loops when re-writing `skin.ini` files
2021-11-02 15:39:33 +09:00
e56811783b
Merge pull request #15407 from peppy/remove-trailing-exclamations-from-autoplay
...
Remove trailing exclamation marks from autoplay character names
2021-11-02 15:21:46 +09:00
9b705460db
Remove trailing exclamation marks from autoplay character names
...
As mentioned in
https://github.com/ppy/osu/discussions/15401#discussioncomment-1573839 .
2021-11-02 14:53:58 +09:00
3f31cb39c0
Merge pull request #15279 from Flux3on/spinner-judgement-fix
...
Fix spinner judgements on old beatmaps get incorrectly stacked
2021-11-02 14:46:15 +09:00
5d784b2ef8
Perform a consistency check by decoding the newly written skin.ini during ComputeHash
...
As this has regressed twice now, let's play it safe and bail rather than
stack overflowing. Note that as all the underlying issues that could
trigger this have been fixed, no additional tests have been added. To
test, comment out `SkinManager.cs` line 228-229 to cause a failure. The
new logic will kick in and show a log output message, but all tests will
still (correctly) pass.
2021-11-02 14:11:25 +09:00
2e66ab453d
Always write automated changes to skin metadata at the end of the file
...
Apart from being cleaner (and allowing removal at the point of export,
if that is ever requires), this also gives us a better guarantee that
the metadata is going to take effect.
By writing the `[General]` section ourselves, we avoid any issues that
may be present from a user constructing the file (incorrectly)
themselves, such as multiple `Title:` entries or a malformed `[General]`
marker.
The main goal is to ensure that the name is updated to what we expect it
to be.
2021-11-02 14:11:25 +09:00
d4be6fc797
Add test coverage of skin with missing section header
2021-11-02 14:05:14 +09:00
15c770e155
Remove no longer used Section.None
2021-11-02 14:01:41 +09:00
ab28948744
Default legacy decoder to General section, rather than none
...
This is mainly to reach parity with how stable handles such cases for
skins specifically. It was brought to our attention after finding a skin
with a malformed `\[General]` tag which did not break further parsing of
the file on stable, but did on lazer.
Note that stable defaults to an "unknown" section for beatmaps, but
functionally I can't think of a regression case from changing this to a
"general" default.
2021-11-02 13:59:13 +09:00
ee6af1245c
Merge pull request #15403 from frenzibyte/android-replay-intent
...
Add android intent filter for osu! replays
2021-11-02 12:52:13 +09:00
badbbace10
Add android intent filter for osu! replays
2021-11-02 04:58:53 +03:00
399aea6740
Merge pull request #15399 from bdach/update-dependencies
...
Update dependencies
2021-11-02 10:24:11 +09:00
12c2f03949
Merge branch 'dependabot/nuget/Microsoft.CodeAnalysis.BannedApiAnalyzers-3.3.3' into update-dependencies
2021-11-01 20:53:48 +01:00
90fb536a25
Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.11' into update-dependencies
2021-11-01 20:53:43 +01:00
d05d0f2b88
Merge branch 'dependabot/nuget/Sentry-3.10.0' into update-dependencies
2021-11-01 20:53:19 +01:00
bfcd7948fe
Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.11' into update-dependencies
2021-11-01 20:52:56 +01:00
e4672981d8
Merge branch 'dependabot/nuget/SharpCompress-0.30.0' into update-dependencies
2021-11-01 20:52:44 +01:00
717403c78f
Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.11' into update-dependencies
2021-11-01 20:52:43 +01:00
7dc5c5cdcd
Merge branch 'dependabot/nuget/Microsoft.NET.Test.Sdk-17.0.0' into update-dependencies
2021-11-01 20:52:38 +01:00
f671ee28c5
Use buffered container to eliminate gaps near foreground border
2021-11-01 20:17:27 +01:00
a59f2d7b83
Implement basic hover card state
2021-11-01 19:41:11 +01:00
5962f16b1c
Implement basic card appearance
2021-11-01 19:41:11 +01:00
d82564aab6
Add test scene for beatmap cards
2021-11-01 19:41:10 +01:00
6e17f92f55
Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.2 to 3.3.3
...
Bumps [Microsoft.CodeAnalysis.BannedApiAnalyzers](https://github.com/dotnet/roslyn-analyzers ) from 3.3.2 to 3.3.3.
- [Release notes](https://github.com/dotnet/roslyn-analyzers/releases )
- [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/main/PostReleaseActivities.md )
- [Commits](https://github.com/dotnet/roslyn-analyzers/commits )
---
updated-dependencies:
- dependency-name: Microsoft.CodeAnalysis.BannedApiAnalyzers
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-11-01 17:02:23 +00:00
3b7379b777
Bump Microsoft.AspNetCore.SignalR.Client from 5.0.10 to 5.0.11
...
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore ) from 5.0.10 to 5.0.11.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Client
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-11-01 17:02:20 +00:00
e0a940be1d
Bump Sentry from 3.9.4 to 3.10.0
...
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet ) from 3.9.4 to 3.10.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases )
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.9.4...3.10.0 )
---
updated-dependencies:
- dependency-name: Sentry
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-11-01 17:02:14 +00:00
f215439b4f
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore ) from 5.0.10 to 5.0.11.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-11-01 17:02:10 +00:00
f8f4b9d3d3
Bump SharpCompress from 0.29.0 to 0.30.0
...
Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress ) from 0.29.0 to 0.30.0.
- [Release notes](https://github.com/adamhathcock/sharpcompress/releases )
- [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.29...0.30 )
---
updated-dependencies:
- dependency-name: SharpCompress
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-11-01 17:02:04 +00:00
f893556b80
Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore ) from 5.0.10 to 5.0.11.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-11-01 17:02:00 +00:00
7747fd5810
Bump Microsoft.NET.Test.Sdk from 16.11.0 to 17.0.0
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.11.0 to 17.0.0.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.11.0...v17.0.0 )
---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2021-11-01 17:01:54 +00:00
a4e65de2d4
Merge pull request #15356 from peppy/score-refactor/less-create-score-info
...
Change `DrawableProfileScore` to use `APIScoreInfo`
2021-11-01 16:00:32 +01:00
3a5aed1182
Ensure APIScoreInfo.Mods is non-null
2021-11-01 22:59:12 +09:00
caa9d8997b
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 22:59:11 +09:00
a19f1e3d6d
Merge pull request #15364 from peppy/beatmap-refactor/beatmap-overlays
...
Update all beatmap overlay views to use `APIBeatmap`/`APIBeatmapSet`
2021-11-01 20:41:51 +09:00
0d65493b56
Mark test usages of Ruleset.CreateInstance() as returning non-null
2021-11-01 12:12:21 +01:00
793c384ecd
Remove unnecessary null-conditional access
2021-11-01 12:02:37 +01:00
5dcff7d8b7
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 11:41:20 +01:00
95b1f5830d
Merge branch 'master' into beatmap-refactor/beatmap-overlays
2021-11-01 19:32:07 +09:00
8c38698506
Merge pull request #15363 from peppy/beatmap-refactor/get-and-present
...
Update `GetScoreRequest` and `PresentBeatmap` to accept interface types
2021-11-01 19:28:28 +09:00
