Commit Graph

2193 Commits

Author SHA1 Message Date
25b4628672 Merge branch 'master' into fix-transform-mutation-from-background 2021-01-06 11:04:51 +01:00
2b253f6d01 Remove now-unused fields & locals 2021-01-05 22:56:53 +01:00
54982dcdd7 Refactor LoadingLayer to avoid applying effects to external drawables
In theory this seemed like a good idea (and an optimisation in some
cases, due to lower fill rate), but in practice this leads to weird edge
cases.

This aims to do away with the operations on external drawables by
applying a dim to the area behind the `LoadingLayer` when required.
I went over each usage and ensured they look as good or better than
previously.

The specific bad usage here was the restoration of the colour on dispose
(if the `LoadingLayer` was disposed in a still-visible state).

I'm aware that the `BeatmapListingOverlay` will now dim completely during
load. I think this is fine for the time being.
2021-01-05 17:31:45 +09:00
b3f08b29ca Ensure that all changes to screen backgrounds are on the correct thread 2021-01-05 15:22:50 +09:00
20d04d6933 Fix Storyboard's FirstEventTime not finding the true earliest event 2021-01-04 15:16:01 +09:00
17abe90c27 move SkinnableHealthDisplay
Similar components are in osu.Game.Screens.Play.HUD while this is not
2020-12-31 20:23:13 +08:00
e3a41f6118 Rename variable to make more sense
It needs to be explicitly stated that the users in this list are related
to the *joined* room. Especially since it's sharing its variable name
with `SpectatorStreamingClient` where it has the opposite meaning (is a
list of *globally* playing players).
2020-12-29 14:27:35 +09:00
a9822800fc Add more null hinting in GameplayLeaderboard 2020-12-28 13:00:05 +01:00
447a55ce11 Fix incorrect null handling in GameplayLeaderboard 2020-12-28 20:16:53 +09:00
2ff49f4758 Merge branch 'master' into fix-quit-user-showing-in-leaderboard 2020-12-27 13:02:40 +01:00
f75dccc9e4 Explicitly use discard in value changed callback 2020-12-27 13:00:27 +01:00
6b6b1514e2 Rename method to be less misleading
As it doesn't only change colour, but also width.
2020-12-27 12:58:37 +01:00
1b34f2115f Remove dignostics using 2020-12-27 16:57:23 +09:00
d14a8d24b5 Remove assert for now 2020-12-27 16:42:20 +09:00
fa0576f47f Move quit colour change implementation to updateColour for better coverage 2020-12-27 13:40:02 +09:00
15948de2f0 Fix gameplay leaderboard avatars being clickable 2020-12-26 14:35:14 +01:00
71dcbeaf7c Mark user as quit visually on the leaderboard 2020-12-26 12:11:09 +09:00
116acc2b5e Add flow for marking user as quit for further handling 2020-12-26 11:35:51 +09:00
ff57562956 Fix multiplayer leaderboard not unsubscribing from quit users 2020-12-26 11:35:31 +09:00
83fb7c7a1a Re-namespace all files in OnlinePlay directory 2020-12-25 16:50:09 +01:00
f991448a3e Re-sort the leaderboard order a maximum of once a second 2020-12-24 21:49:38 +09:00
d5fc517fab Merge branch 'master' into disallow-skipping 2020-12-24 12:35:22 +01:00
ee5a6ff9fa Merge branch 'master' into improved-loading-experience 2020-12-24 11:59:46 +01:00
4fb2610c82 Merge branch 'master' into frame-bundle-accuracy 2020-12-24 11:20:06 +01:00
6bd6888a93 Disallow skipping in multiplayer for now 2020-12-24 16:29:51 +09:00
e86e9bfae6 Don't begin gameplay until all users are in a completely prepared state 2020-12-24 15:32:55 +09:00
d66e218318 Source display accuracy from header and remove from ScoreProcessor function 2020-12-24 14:57:23 +09:00
76935b93b6 Merge branch 'master' into disallow-multiplayer-restart-retry 2020-12-24 13:31:54 +09:00
980e85ce25 Refactor player exit logic to convey intention better 2020-12-23 16:16:24 +01:00
c839892a4c Merge branch 'master' into fix-multiplayer-server-disconnection-flow 2020-12-23 11:57:43 +01:00
f9fd909187 Fix missed inspections 2020-12-23 18:07:38 +09:00
3c8f871b28 Move player constructor configuration to dedicated class; add AllowRestart parameter 2020-12-23 17:47:46 +09:00
f5d27b40a8 Standardise flow for aborting realtime player exit to avoid double-exit call 2020-12-23 16:35:39 +09:00
6517acc510 Add leaderboard display to realtime player 2020-12-22 19:10:08 +09:00
8ac76bd524 Merge pull request #11199 from smoogipoo/refactor-player-score-creation
Asyncify player score creation and submission
2020-12-20 17:30:11 +09:00
4e5064c4f6 Start accuracy at 1 2020-12-19 21:31:17 +01:00
c738a57b39 Fix username overflow in new leaderboard design 2020-12-19 18:48:17 +01:00
b3bff281ce Merge branch 'master' into spectator-driven-leaderboard 2020-12-20 01:13:59 +09:00
06a17a9d8c Rename other constant to be distinguishable 2020-12-19 15:18:05 +01:00
315a957a0c Extract constant for text transition duration 2020-12-19 15:17:31 +01:00
e2cc401c12 Move BDL above LoadComplete() 2020-12-19 15:05:59 +01:00
d392e0f27e Extract shared rank-formatting helper 2020-12-19 15:04:22 +01:00
22a2c3efdf Add back xmldoc of AddPlayer 2020-12-19 15:04:18 +01:00
28ca21b432 Seal banned method & throw better exception 2020-12-19 14:50:09 +01:00
beaced3211 Remove unnecessary async state machine 2020-12-19 13:58:56 +09:00
772dd0287e Split submission and import into two methods 2020-12-19 03:32:05 +09:00
030dce5559 Increase leaderboard score width a bit 2020-12-18 13:09:50 +03:00
c9e75e7908 Add user avatar to leaderboard scores 2020-12-18 13:09:05 +03:00
eccfc8ccd2 Fix potential cross-reference access 2020-12-18 18:31:49 +09:00
8826d01559 Create completion progress delegate immediately 2020-12-18 18:20:36 +09:00