1f8b7b8f03
Remove #nullable disable from CaughtObject
2023-01-15 23:21:38 +09:00
d664a66a37
Remove redundant canBeNull: true
2023-01-15 23:11:59 +09:00
c5775aa452
Merge branch 'master' into song_select_nullability
2023-01-15 22:44:13 +09:00
4cf4a66858
Make MusicController a required dependency of SongSelect
2023-01-15 22:43:30 +09:00
f7af5a8115
Revert some formatting changes
2023-01-15 22:39:00 +09:00
13c1b8f5a4
Fix intermittent failure in tests with restarting player instances
2023-01-15 16:06:06 +03:00
5d2e09137c
Remove text padding in editor menu for now
2023-01-15 14:40:53 +03:00
8777d5349b
Use existing strings
2023-01-15 14:39:34 +03:00
086604cd14
Remove #nullable disable from Catch.Objects.Drawables
...
Except DrawableCatchHitObject, it complains in base(hitObject) call.
2023-01-15 17:29:35 +09:00
b88091262d
Remove #nullable disable from Catch.UI
2023-01-15 17:29:35 +09:00
b08a1e3a0b
Remove #nullable disable from misc Catch files
2023-01-15 17:29:35 +09:00
56fb315f32
Remove #nullable disable from Catch.Objects
2023-01-15 17:29:35 +09:00
2468911f4b
Remove #nullable disable from Catch.Judgements
2023-01-15 17:29:32 +09:00
3ab3f556ae
Remove #nullable disable from Catch.Difficulty
2023-01-15 17:29:32 +09:00
b049244b75
Remove #nullable disable from Catch.Beatmaps
2023-01-15 17:29:32 +09:00
a75fc5108a
Remove #nullable disable from Catch.Edit namespace
2023-01-15 17:29:32 +09:00
8f70424999
Merge pull request #22213 from Joehuu/fix-kudosu-wiki-link
...
Fix kudosu wiki link from user profile not linking to in-game overlay
2023-01-15 13:06:34 +09:00
627d1725c3
Fix kudosu wiki link from user profile not linking to in-game overlay
2023-01-14 19:56:51 -08:00
87650044bb
Localise create/save dialog
2023-01-15 01:50:47 +03:00
78e562903d
Localise part of editor
2023-01-15 01:50:47 +03:00
24df23f420
Localise background header
2023-01-15 01:49:19 +03:00
76eefc7573
Add support for localisation where it was missing
2023-01-15 01:46:11 +03:00
a68d4fe5d1
make expansion to not use scheduler
2023-01-14 21:18:51 +00:00
1480c691ae
Explain empty string in editor's footer
2023-01-14 23:42:56 +03:00
58406cae19
Make test wait for comment loading
2023-01-14 23:42:10 +03:00
c36922dd2c
Use clock to obtain a position for comment insertion
2023-01-14 22:57:51 +03:00
c2bb0949f5
Take type and id from container directly on submit
2023-01-14 22:57:23 +03:00
cdf3aafddd
Add check for any drawables in content before looking for placeholder
2023-01-14 22:37:05 +03:00
a9facc076f
Fix difficulty creation flow failing for some ruleset combinations
...
In current `master`, the difficulty creation flow would retrieve a
"reference beatmap" to copy metadata and timing points from using
`GetPlayableBeatmap()`. But, importantly, it was calling that method
using *the ruleset of the new difficulty* rather than the ruleset of the
existing one. This would make the difficulty creation flow fail if the
beatmap couldn't be converted between rulesets (like taiko to catch).
Fixing to use the reference beatmap's actual ruleset would be trivial,
but there's no real reason to do all of that work anyway when a
`WorkingBeatmap` is available. Because getting a playable beatmap is not
required to copy across metadata and timing points, remove the
`GetPlayableBeatmap()` step entirely to fix the bug.
Closes #22145 .
2023-01-14 19:46:55 +01:00
e7ab543799
Add ability to view converted beatmaps on beatmap set overlay
2023-01-14 10:26:21 -08:00
88c3eef8e1
Add test case with no existing comments
2023-01-14 20:59:13 +03:00
efe6dae672
Merge pull request #22200 from bdach/user-profile/update-design-basics
...
Update user profile appearance to closer match web
2023-01-15 02:50:11 +09:00
3102044d00
Add failing test for new difficulty creation
2023-01-14 18:46:14 +01:00
4906f37109
Merge pull request #22181 from frenzibyte/attempt-fix-song-select-test-failure
...
Fix intermittent failure in beatmap carousel tests
2023-01-15 02:35:36 +09:00
fbb674d8e9
Rename parent comment id field
2023-01-14 20:15:19 +03:00
67a3ea2c59
Fix wrong date colour of kudosu history items
2023-01-14 17:50:18 +01:00
bfca75395b
Adjust colour of top header container
2023-01-14 17:37:33 +01:00
6a9d842660
Adjust user profile header detail appearance
2023-01-14 17:37:31 +01:00
de077403e9
Adjust visual appearance of profile value displays
2023-01-14 17:37:28 +01:00
f80dddbb5e
Rearrange and adjust header components where simple
2023-01-14 17:17:28 +01:00
e39eb089ce
Update colouring of some profile section elements
2023-01-14 17:17:26 +01:00
5b1111c6b1
Adjust appearance of user profile sections
2023-01-14 17:17:24 +01:00
3f81f173fb
Adjust appearance of section navigation
2023-01-14 17:17:21 +01:00
49e08c06a6
Adjust general appearance of user profile overlay
2023-01-14 16:59:51 +01:00
3fa81a52b4
Add other profile sections to test scene
2023-01-14 16:59:47 +01:00
43c0f8b95f
Merge pull request #22191 from Joehuu/move-overlay-ruleset-selectors
...
Move overlay ruleset selectors to tab control in line with web
2023-01-14 16:01:55 +01:00
5e1ea8b34f
Merge branch 'master' into move-overlay-ruleset-selectors
2023-01-14 15:22:14 +01:00
2831db53f7
fix wrong control flow on hover lost
2023-01-14 14:19:02 +00:00
d9045b5fa8
Merge pull request #22198 from frenzibyte/fix-mgcc-test-failure
...
Fix intermittent failure in GCC seeking test
2023-01-14 13:18:14 +01:00
2f2ab445c9
Merge pull request #22182 from stanriders/status-icon
...
Update status icon design
2023-01-14 21:05:44 +09:00
