Commit Graph

56273 Commits

Author SHA1 Message Date
0a625bd879 Fix mods potentially keeping reference to runtime gameplay elements
As noticed by smoogipoo during multiplayer match on the weekend.
2022-09-19 12:18:46 +09:00
454125123d Add failing test coverage showing mod reference leak path 2022-09-19 12:18:35 +09:00
6852577dad Remove smoke from key overlay 2022-09-18 19:08:01 -07:00
0138663bdc Fix InspectCode errors 2022-09-18 18:32:33 -07:00
06178104c8 Show smoke in replays 2022-09-18 17:55:06 -07:00
5ccffe86bd Merge pull request #20339 from peppy/fix-notification-count
Fix notification count not always updating when it should
2022-09-19 02:43:56 +03:00
a413c7a3e6 Merge branch 'master' into fix-notification-count 2022-09-19 02:08:20 +03:00
a4e9c7711c Fix when flashlight shrinking takes place 2022-09-18 18:59:17 -04:00
407b104116 Revert changes
This reverts commit beef3b418a.

Revert "Use linq expression for handling breaks"

This reverts commit 8464a1941b.

Revert "renames variables to make more logical sense"

This reverts commit 3b87ecf56c.

Revert "Removes overhead when not combo based size"

This reverts commit ac4229e3d4.
2022-09-18 18:57:53 -04:00
9eb0a21d75 Correct comments 2022-09-19 00:45:23 +02:00
4263933c9e Add settings AngleSharpness and Angle variety 2022-09-18 23:43:14 +02:00
ca9fe9f240 Fixed TestCatcherCatchWidth failing 2022-09-18 22:05:09 +02:00
613564b5b9 Full legacy smoke implementation and temp default smoke 2022-09-18 12:10:01 -07:00
493efd84a3 Basic smoke path implementation 2022-09-18 12:08:34 -07:00
6d7d80a4fb Made X position value of CatchHitObject clamp to CatchPlayfield's width 2022-09-18 17:29:08 +02:00
0ac28cbecc Fix potential crash from missing DownloadProgress 2022-09-18 23:42:16 +09:00
6a06a5b1b5 Reword fallback instantiation handling comment to hopefully explain things better 2022-09-18 18:20:28 +09:00
d0b8409de5 Apply more renames 2022-09-18 18:19:00 +09:00
1914c41d0d Merge pull request #20353 from Drison64/fix-timelineZoom-zero
EditorBeatmap's TimelineZoom should never be zero
2022-09-18 18:06:26 +09:00
ada4b97ebd Merge pull request #20359 from smoogipoo/fix-room-component-memory-leak
Fix memory leak due to missing event unbind
2022-09-18 14:59:05 +09:00
2dcaf7cfd8 Fix memory leak due to missing event unbind 2022-09-18 14:25:31 +09:00
ac4229e3d4 Removes overhead when not combo based size 2022-09-18 00:38:01 -04:00
3b87ecf56c renames variables to make more logical sense 2022-09-18 00:19:40 -04:00
8464a1941b Use linq expression for handling breaks 2022-09-17 23:49:23 -04:00
beef3b418a Simplifies size calculation 2022-09-17 23:41:23 -04:00
a634ec8fdb Merge pull request #20355 from frenzibyte/api-user-score-aggregate-xmldoc
Clarify purpose of `APIUserScoreAggregate` using xmldoc
2022-09-18 11:50:06 +09:00
c075d3de08 Create a test and a check if initial zoom value of ZoomableScrollContainer is in range 2022-09-17 22:43:40 +02:00
9d94343317 Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-09-17 19:51:44 +02:00
c8768eb399 Changed == to <= on TimelineZoom check 2022-09-17 19:00:50 +02:00
88e6ce575a Merge branch 'fix-timelineZoom-zero' of https://github.com/Drison64/osu into fix-timelineZoom-zero 2022-09-17 18:57:36 +02:00
3c7ea5c8fa Update 2022-09-17 18:57:09 +02:00
9a10ecb378 Clarify purpose of APIUserScoreAggregate 2022-09-17 19:37:30 +03:00
41e69fbca6 Remove "default" prefix from naming 2022-09-18 00:15:26 +09:00
1c4e02fae8 Explicitly order default skins in dropdown to get correct order 2022-09-18 00:12:43 +09:00
1b475f9360 Ensure skin InstantiationInfo is updated when saving 2022-09-18 00:12:43 +09:00
64ee210825 Add realm migration to update skin names 2022-09-18 00:12:43 +09:00
487378f732 Fallback to default skin if instantiation fails 2022-09-17 23:57:25 +09:00
3e28ab72ce Standardise default skin names 2022-09-17 23:57:25 +09:00
51841988bf Rename references to DefaultSkin to have Triangles suffix 2022-09-17 23:57:25 +09:00
448485a56b Merge branch 'master' into fix-timelineZoom-zero 2022-09-17 16:24:18 +02:00
2dfa89c62e Clean up 2022-09-17 15:05:25 +01:00
ea0a995cc9 Merge pull request #20349 from vegguid/master
Fixed Leaderboard tooltip not following time format setting
2022-09-17 23:00:44 +09:00
0b6a77bc8b EditorBeatmap's TimelineZoom should never be zero 2022-09-17 15:59:42 +02:00
d580b07063 Refactor update condition logic 2022-09-17 14:40:36 +01:00
a1d830e47f Fix formatting 2022-09-17 22:22:56 +09:00
0bfe967452 moved BindValueChanged to LoadComplete 2022-09-17 12:58:23 +02:00
e3d5ba5301 Check if graph DrawSize changed 2022-09-17 11:44:25 +01:00
0d76f4501d Revert "Set InvalidationSource to Self"
This reverts commit 2092008251.
2022-09-17 10:10:20 +01:00
48527f2d07 Ignore case during logger name comparison 2022-09-16 22:50:49 +03:00
288cc7b201 Fixed Leaderboard tooltip not following time format setting 2022-09-16 21:36:17 +02:00