Commit Graph

423 Commits

Author SHA1 Message Date
c9dfffbc0e Merge pull request #18619 from peppy/fix-collection-performance
Fix performance overhead of large collections
2022-06-10 15:01:31 +09:00
4a5e86e451 Rename Beatmaps to BeatmapHashes for clarity 2022-06-10 14:03:51 +09:00
bf67b35ade Use new own profile statistics in difficulty recommender 2022-06-08 17:44:57 +03:00
42cd7d9e6e Change CollectionManager to only store MD5 hashes instead of full BeatmapInfo 2022-06-08 18:23:09 +09:00
0d32c94104 Add initial implementation of beatmap carousel no-results-placeholder 2022-06-07 17:25:06 +09:00
1f17652c1d Fix test failure due to async-loading of content 2022-05-20 19:08:41 +03:00
84a3cee452 Apply rate multiplier outside BPM rounding 2022-05-20 18:04:12 +03:00
de8aedf348 Add failing test case 2022-05-20 17:53:28 +03:00
76c63f1d0a Rename ModSelect{Screen -> Overlay} in place of removed old design 2022-05-10 22:56:50 +02:00
8f65e0e60f Add failing test coverage for toggling mod overlay with hotkey 2022-05-05 22:16:56 +02:00
856ca96b66 Allow right-clicking to rewind on random button 2022-04-29 10:12:24 +03:00
294340279e Add inputting test coverage 2022-04-29 04:14:09 +03:00
0146949ad6 Fix failing string comparison tests 2022-04-20 16:52:24 -07:00
3cbc6cd297 Update further tests to cache using IDialogOverlay 2022-04-18 21:04:22 +03:00
cb1ee05539 Merge pull request #17555 from peppy/remove-source-from-wedge
Remove song source from main wedge display
2022-03-30 18:57:25 +09:00
bc0b982102 Remove song source from main wedge display
This was definitely added at someone's request, since I wouldn't have
put it here. But it's displayed below in the details section already and
also not displayed in the updated "wedge" in the new design.

See https://github.com/ppy/osu/discussions/17537 for discussion.
2022-03-30 17:59:40 +09:00
b7ae431252 Add test coverage 2022-03-30 01:08:22 +03:00
810cbd745d Merge pull request #17170 from peppy/fix-top-local-rank-test-failures-realm-callback
Refactor top local rank test method to be more resilient to slow realm callbacks
2022-03-09 11:14:37 +09:00
233c8232d3 Fix TestSceneTopLocalRank.TestHighScoreSet not waiting for potentially slow realm callback
As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847.
2022-03-09 01:22:01 +09:00
286bafe326 Refactor multiple TestScenePlaySongSelect test methods to be resilient to slow realm callbacks 2022-03-09 01:18:53 +09:00
c342030b2c Add specific placeholder message for custom rulesets rather than showing network error 2022-03-02 14:10:59 +09:00
3a03833912 Merge pull request #16890 from peppy/beatmap-decoder-ruleset-store
Fix `LegacyBeatmapDecoder` not populating correct rulesets
2022-02-25 19:03:43 +09:00
15ed9ec4fa Merge scoreboard and leaderboard implementations together 2022-02-19 20:47:02 +01:00
f4d1e6f600 Add tests for timerefs 2022-02-17 10:38:29 +01:00
0138f22c8d Update existing usages to point to RealmRulesetStore 2022-02-16 17:13:54 +09:00
f012f64fd1 Add test coverage checking carousel panel visual state after ruleset filter change 2022-02-11 15:21:01 +09:00
41aa4b8cca Fix TestSelectingFilteredRuleset failing under visual tests due to using local database 2022-02-03 16:04:05 +09:00
35b7653290 Revert mod flow changes and add visual test coverage showing an overflow case 2022-02-02 09:13:19 +09:00
3ca2c90684 Add test scores in BeatmapLeaderboard test scene with more mods 2022-02-01 16:35:25 +09:00
f8939af5e6 Track loading via state as well 2022-01-31 01:12:03 +09:00
04dbb5d3c6 Disallow setting "NoScores" externally as it is handled internally 2022-01-30 16:18:19 +09:00
acc1199add Consolidate flows of Set operations, either result or error 2022-01-30 16:16:00 +09:00
c401629dd8 Also refactor placeholder logic to make more sense 2022-01-30 10:50:32 +09:00
06660ff960 Fix null beatmap in test scene 2022-01-30 03:02:56 +09:00
d21464ea61 Fix assertions to work in both directions 2022-01-30 02:54:51 +09:00
51acf79935 Change test exposure to property instead of method 2022-01-30 02:29:51 +09:00
9861c50b33 Remove pointless tests that no longer show anything valid 2022-01-30 00:03:22 +09:00
661fec7c8a Make score setter private 2022-01-29 23:58:57 +09:00
04d6ca59a3 Merge branch 'master' into song-select-scroll-position-during-delete 2022-01-27 20:46:19 +01:00
e872877185 Merge pull request #16648 from peppy/fix-song-select-tests
Fix song select tests not waiting for beatmap imports to arrive
2022-01-27 23:00:58 +09:00
fae4f8bd8e Move nulling of previous songSelect to SetUpSteps instead 2022-01-27 21:59:44 +09:00
831fa44433 Fix song select tests not waiting for beatmap imports to arrive
After the change to realm, notification fires could take a frame or two.
We aren't accounting for this.

Fixes test failures like
https://github.com/ppy/osu/runs/4963255990?check_suite_focus=true
2022-01-27 19:35:42 +09:00
f2cecad83b Add failing test coverage showing carousel deletions don't keep scroll position 2022-01-27 16:52:02 +09:00
5288eedd31 Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID 2022-01-27 15:38:03 +09:00
c0ed308016 Use more correct method of deletion in TestScenePlaySongSelect 2022-01-25 17:55:39 +09:00
778d2a71b4 Remove Task from the inner-most Import method in RealmArchiveModelImporter
One of my pending work items for post-realm merge.

The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.

Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
2022-01-25 15:30:29 +09:00
3e5c9e8436 Fix cases of Access instead of Realm 2022-01-25 12:58:15 +09:00
6eb2c28e41 Rename RealmContextFactory to RealmAccess 2022-01-24 20:38:07 +09:00
581873f944 Merge pull request #16497 from peppy/top-local-rank-optimisation
Rewrite `TopLocalRank` to use realm subscriptions
2022-01-19 14:22:12 +09:00
3e5d29ed00 Merge pull request #16505 from peppy/remove-base-difficulty-usage
Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)
2022-01-19 13:53:55 +09:00