Commit Graph

24147 Commits

Author SHA1 Message Date
9d8f0c854d Setup configuration item for editor hit animations 2021-04-21 18:05:40 +09:00
c6c91cd9a5 Refactor WaveformOpacityMenuItem to not receive whole config 2021-04-21 18:05:26 +09:00
cf55383fff Merge pull request #12486 from ekrctb/unmanaged-hit-object-entry
Associate DrawableHitObject with HitObjectLifetimeEntry rather than HitObject
2021-04-21 17:08:21 +09:00
ab2a8b5c89 Fix initial rotation not being set 2021-04-21 16:12:09 +09:00
eb20865c02 Show tablet preview with physical tablet counter-rotated for supplied user area selection
Closes https://github.com/ppy/osu/issues/12399.

Rotation animation is intentionally delayed slightly to give a better sense of what is going on (or maybe just look cool).
2021-04-21 15:55:15 +09:00
3fbeadf318 Deprecate old overload of Apply 2021-04-21 14:32:37 +09:00
73d3da1687 Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.
HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.
2021-04-21 11:32:01 +09:00
44ff08cce4 Revert "Fix wrong InitialLifetimeOffset is used for a non-pooled DHO."
This reverts commit 67fcfd9d
2021-04-21 10:02:50 +09:00
67fcfd9dbc Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.
HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.
2021-04-21 09:48:16 +09:00
e80c3c317a Rename UnmanagedHitObjectEntry -> SyntheticHitObjectEntry
"Unmanaged" was confusing because its lifetime is still managed by the HitObjectContainer.
2021-04-21 09:23:23 +09:00
a2afa38a3f Merge branch 'master' into fix-mod-customisation-input-blocking-padding 2021-04-20 19:41:25 +02:00
26430e3cb5 Merge pull request #12492 from Naxesss/bg-audio-quality-checks
Add background and audio checks
2021-04-21 00:10:32 +09:00
7fc450c620 Fix mod settings blocking input outside its visible area
Closes #12502.
2021-04-20 23:42:56 +09:00
e9dfa2860a Add xmldoc note about path being relative 2021-04-20 13:44:06 +02:00
d7a81471c8 Add xmldoc to GetPathForFile 2021-04-20 13:40:38 +02:00
3e1b6b3b34 Simplify verifier run call args
Uses the resolved working beatmap instead of resolving it every time.

Also uses the EditorBeatmap itself as playable beatmap, as it is of type `IBeatmap` already, and `.PlayableBeatmap` forwards everything anyway.
2021-04-20 13:34:12 +02:00
d28eb399a4 Fix storyboard sample lifetimes not set if seeked past 2021-04-20 17:14:48 +09:00
281c2041b2 Add failing test 2021-04-20 16:51:00 +09:00
c6ee4e900e Ensure a non-null hitobject entry has a non-null Result 2021-04-20 15:18:36 +09:00
8a8b9084ef Make single-argument overloead of DHO.Apply public 2021-04-20 10:11:36 +09:00
496df411a7 Remove now unused import 2021-04-20 02:39:11 +02:00
0e6b66f457 Merge branch 'master' into bg-audio-quality-checks 2021-04-20 02:36:13 +02:00
1478bcfa8e Improve xmldoc consistency 2021-04-20 02:30:27 +02:00
67e4fe4284 Add xmldoc to GetStream 2021-04-20 02:28:38 +02:00
1bc63a4c61 Now, DHO.lifetimeEntry can be non-null even it is not fully applied 2021-04-20 09:22:16 +09:00
4510e795e1 Fix category of audio quality check 2021-04-20 02:13:26 +02:00
c1b4aaaa03 Add doc comment 2021-04-20 08:38:02 +09:00
c633f15565 Add audio quality check 2021-04-20 01:36:03 +02:00
f168247254 Add Track as a property to IWorkingBeatmap
This is implemented by `WorkingBeatmap` already, and is much better to use than loading the track every time we need it.
2021-04-20 01:35:41 +02:00
40ae856dfc Show 2 decimals for background filesize 2021-04-20 01:34:05 +02:00
14c626ffcb Use the playable beatmap for file presence checks 2021-04-20 01:33:19 +02:00
8656176ab8 Add the playable beatmap as check argument
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.

So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.

This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
0825fc57a9 Move foreground colour helper into OsuColour 2021-04-19 18:24:48 +02:00
97573fb11d Merge branch 'master' into combo-colours-display 2021-04-19 18:21:57 +02:00
510e54ff54 Update framework 2021-04-19 23:41:21 +09:00
fc41ad65f8 Merge pull request #12447 from smoogipoo/fix-non-60fps-recording
Record every 60fps interval
2021-04-19 23:26:58 +09:00
2c487ddb70 Create synthetic LifetimeEntry for a DHO when not supplied
Now, a DHO is always associated with a HitObjectLifetimeEntry while used.
Result is always stored in the entry, and not in the DHO.
2021-04-19 21:54:19 +09:00
5afdc3ff66 Make DHO application logic clearer with Entry/HitObject separation 2021-04-19 19:56:17 +09:00
a40dcd4b8d Add a touch more space in the timing column 2021-04-19 18:53:06 +09:00
097a347533 Adjust Add different background colour for timing area 2021-04-19 18:25:30 +09:00
5bce5d2057 Update design logic 2021-04-19 18:25:20 +09:00
8fcfac7ddc Merge branch 'master' into timing-screen-ux 2021-04-19 16:44:32 +09:00
1ebc5ac5cc Remove unused legacy class 2021-04-19 16:36:00 +09:00
8da561a2a6 Soften colours and adjust padding slightly 2021-04-19 16:35:36 +09:00
f8b20ca8aa Add new display for effect row attribute 2021-04-19 16:35:36 +09:00
ec249a0edb Add new display for sample row attribute 2021-04-19 16:23:28 +09:00
6465a72060 Add bubbled word class for use in attribute rows 2021-04-19 16:23:28 +09:00
3aad0a8b9c Add new display for difficulty row attribute 2021-04-19 16:23:06 +09:00
d3cebfb6fb Use explicit label 2021-04-19 16:23:06 +09:00
a10a8680d0 Add new display for timing row attributes 2021-04-19 16:23:06 +09:00